* [PATCH] dt-bindings: power: Correct interrupt flags in examples
@ 2020-09-08 14:59 Krzysztof Kozlowski
2020-09-15 16:54 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-08 14:59 UTC (permalink / raw)
To: Sebastian Reichel, Rob Herring, linux-pm, devicetree, linux-kernel
Cc: Krzysztof Kozlowski
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning:
1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
Correct the interrupt flags, assuming the author of the code wanted some
logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
.../devicetree/bindings/power/supply/act8945a-charger.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/power/supply/act8945a-charger.txt b/Documentation/devicetree/bindings/power/supply/act8945a-charger.txt
index c7dfb7cecf40..cb737a9e1f16 100644
--- a/Documentation/devicetree/bindings/power/supply/act8945a-charger.txt
+++ b/Documentation/devicetree/bindings/power/supply/act8945a-charger.txt
@@ -33,7 +33,7 @@ Example:
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_charger_chglev &pinctrl_charger_lbo &pinctrl_charger_irq>;
interrupt-parent = <&pioA>;
- interrupts = <45 GPIO_ACTIVE_LOW>;
+ interrupts = <45 IRQ_TYPE_LEVEL_LOW>;
active-semi,chglev-gpios = <&pioA 12 GPIO_ACTIVE_HIGH>;
active-semi,lbo-gpios = <&pioA 72 GPIO_ACTIVE_LOW>;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: power: Correct interrupt flags in examples
2020-09-08 14:59 [PATCH] dt-bindings: power: Correct interrupt flags in examples Krzysztof Kozlowski
@ 2020-09-15 16:54 ` Rob Herring
2020-09-16 6:26 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Rob Herring @ 2020-09-15 16:54 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Sebastian Reichel, linux-kernel, devicetree, linux-pm, Rob Herring
On Tue, 08 Sep 2020 16:59:22 +0200, Krzysztof Kozlowski wrote:
> GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> These are simple defines so they could be used in DTS but they will not
> have the same meaning:
> 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
>
> Correct the interrupt flags, assuming the author of the code wanted some
> logical behavior behind the name "ACTIVE_xxx", this is:
> ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> ---
> .../devicetree/bindings/power/supply/act8945a-charger.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: power: Correct interrupt flags in examples
2020-09-15 16:54 ` Rob Herring
@ 2020-09-16 6:26 ` Krzysztof Kozlowski
0 siblings, 0 replies; 3+ messages in thread
From: Krzysztof Kozlowski @ 2020-09-16 6:26 UTC (permalink / raw)
To: Rob Herring
Cc: Sebastian Reichel, linux-kernel, devicetree, linux-pm, Rob Herring
On Tue, Sep 15, 2020 at 10:54:11AM -0600, Rob Herring wrote:
> On Tue, 08 Sep 2020 16:59:22 +0200, Krzysztof Kozlowski wrote:
> > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
> > These are simple defines so they could be used in DTS but they will not
> > have the same meaning:
> > 1. GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE
> > 2. GPIO_ACTIVE_LOW = 1 = IRQ_TYPE_EDGE_RISING
> >
> > Correct the interrupt flags, assuming the author of the code wanted some
> > logical behavior behind the name "ACTIVE_xxx", this is:
> > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
> >
> > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> > ---
> > .../devicetree/bindings/power/supply/act8945a-charger.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> Applied, thanks!
Hi Rob,
Did you mean Acked-by or are you taking this patch directly?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-16 6:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-08 14:59 [PATCH] dt-bindings: power: Correct interrupt flags in examples Krzysztof Kozlowski
2020-09-15 16:54 ` Rob Herring
2020-09-16 6:26 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).