* [PATCH] thermal/idle_inject: Fix comment of idle_duration_us and name of latency_ns
@ 2020-09-17 7:35 zhuguangqing83
2020-09-22 15:24 ` Daniel Lezcano
0 siblings, 1 reply; 2+ messages in thread
From: zhuguangqing83 @ 2020-09-17 7:35 UTC (permalink / raw)
To: amit.kachhap, daniel.lezcano, viresh.kumar, javi.merino,
rui.zhang, amitk, rafael.j.wysocki, zhuguangqing
Cc: linux-pm, linux-kernel
From: zhuguangqing <zhuguangqing@xiaomi.com>
The comment of idle_duration_us and the name of latency_ns can be misleading,
so fix them.
Signed-off-by: zhuguangqing <zhuguangqing@xiaomi.com>
---
drivers/thermal/cpuidle_cooling.c | 2 +-
include/linux/idle_inject.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/cpuidle_cooling.c b/drivers/thermal/cpuidle_cooling.c
index 78e3e8238116..7ecab4b16b29 100644
--- a/drivers/thermal/cpuidle_cooling.c
+++ b/drivers/thermal/cpuidle_cooling.c
@@ -30,7 +30,7 @@ static DEFINE_IDA(cpuidle_ida);
/**
* cpuidle_cooling_runtime - Running time computation
- * @idle_duration_us: the idle cooling device
+ * @idle_duration_us: CPU idle time to inject in microseconds
* @state: a percentile based number
*
* The running duration is computed from the idle injection duration
diff --git a/include/linux/idle_inject.h b/include/linux/idle_inject.h
index 91a8612b8bf9..fb88e23a99d3 100644
--- a/include/linux/idle_inject.h
+++ b/include/linux/idle_inject.h
@@ -28,6 +28,6 @@ void idle_inject_get_duration(struct idle_inject_device *ii_dev,
unsigned int *idle_duration_us);
void idle_inject_set_latency(struct idle_inject_device *ii_dev,
- unsigned int latency_ns);
+ unsigned int latency_us);
#endif /* __IDLE_INJECT_H__ */
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thermal/idle_inject: Fix comment of idle_duration_us and name of latency_ns
2020-09-17 7:35 [PATCH] thermal/idle_inject: Fix comment of idle_duration_us and name of latency_ns zhuguangqing83
@ 2020-09-22 15:24 ` Daniel Lezcano
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Lezcano @ 2020-09-22 15:24 UTC (permalink / raw)
To: zhuguangqing83, amit.kachhap, viresh.kumar, javi.merino,
rui.zhang, amitk, rafael.j.wysocki, zhuguangqing
Cc: linux-pm, linux-kernel
On 17/09/2020 09:35, zhuguangqing83@gmail.com wrote:
> From: zhuguangqing <zhuguangqing@xiaomi.com>
>
> The comment of idle_duration_us and the name of latency_ns can be misleading,
> so fix them.
>
> Signed-off-by: zhuguangqing <zhuguangqing@xiaomi.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-22 15:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 7:35 [PATCH] thermal/idle_inject: Fix comment of idle_duration_us and name of latency_ns zhuguangqing83
2020-09-22 15:24 ` Daniel Lezcano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).