* Re: [PATCH -next] cpufreq: remove unnecessary break
2020-10-23 9:58 [PATCH -next] cpufreq: remove unnecessary break Zhang Qilong
@ 2020-10-23 9:49 ` Viresh Kumar
2020-10-27 17:44 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Viresh Kumar @ 2020-10-23 9:49 UTC (permalink / raw)
To: Zhang Qilong; +Cc: rjw, linux-pm
On 23-10-20, 17:58, Zhang Qilong wrote:
> A 'break' is not needed because of previous 'return'
>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> drivers/cpufreq/e_powersaver.c | 1 -
> drivers/cpufreq/longhaul.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/cpufreq/e_powersaver.c b/drivers/cpufreq/e_powersaver.c
> index 776a58bab0ff..ab93bce8ae77 100644
> --- a/drivers/cpufreq/e_powersaver.c
> +++ b/drivers/cpufreq/e_powersaver.c
> @@ -223,7 +223,6 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
> case EPS_BRAND_C3:
> pr_cont("C3\n");
> return -ENODEV;
> - break;
> }
> /* Enable Enhanced PowerSaver */
> rdmsrl(MSR_IA32_MISC_ENABLE, val);
> diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c
> index 123fb006810d..182a4dbca095 100644
> --- a/drivers/cpufreq/longhaul.c
> +++ b/drivers/cpufreq/longhaul.c
> @@ -593,7 +593,6 @@ static void longhaul_setup_voltagescaling(void)
> break;
> default:
> return;
> - break;
> }
> if (min_vid_speed >= highest_speed)
> return;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH -next] cpufreq: remove unnecessary break
@ 2020-10-23 9:58 Zhang Qilong
2020-10-23 9:49 ` Viresh Kumar
2020-10-27 17:44 ` Rafael J. Wysocki
0 siblings, 2 replies; 3+ messages in thread
From: Zhang Qilong @ 2020-10-23 9:58 UTC (permalink / raw)
To: rjw, viresh.kumar; +Cc: linux-pm
A 'break' is not needed because of previous 'return'
Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
---
drivers/cpufreq/e_powersaver.c | 1 -
drivers/cpufreq/longhaul.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/cpufreq/e_powersaver.c b/drivers/cpufreq/e_powersaver.c
index 776a58bab0ff..ab93bce8ae77 100644
--- a/drivers/cpufreq/e_powersaver.c
+++ b/drivers/cpufreq/e_powersaver.c
@@ -223,7 +223,6 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
case EPS_BRAND_C3:
pr_cont("C3\n");
return -ENODEV;
- break;
}
/* Enable Enhanced PowerSaver */
rdmsrl(MSR_IA32_MISC_ENABLE, val);
diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c
index 123fb006810d..182a4dbca095 100644
--- a/drivers/cpufreq/longhaul.c
+++ b/drivers/cpufreq/longhaul.c
@@ -593,7 +593,6 @@ static void longhaul_setup_voltagescaling(void)
break;
default:
return;
- break;
}
if (min_vid_speed >= highest_speed)
return;
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] cpufreq: remove unnecessary break
2020-10-23 9:58 [PATCH -next] cpufreq: remove unnecessary break Zhang Qilong
2020-10-23 9:49 ` Viresh Kumar
@ 2020-10-27 17:44 ` Rafael J. Wysocki
1 sibling, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2020-10-27 17:44 UTC (permalink / raw)
To: Zhang Qilong; +Cc: Rafael J. Wysocki, Viresh Kumar, Linux PM
On Fri, Oct 23, 2020 at 11:48 AM Zhang Qilong <zhangqilong3@huawei.com> wrote:
>
> A 'break' is not needed because of previous 'return'
>
> Signed-off-by: Zhang Qilong <zhangqilong3@huawei.com>
> ---
> drivers/cpufreq/e_powersaver.c | 1 -
> drivers/cpufreq/longhaul.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/cpufreq/e_powersaver.c b/drivers/cpufreq/e_powersaver.c
> index 776a58bab0ff..ab93bce8ae77 100644
> --- a/drivers/cpufreq/e_powersaver.c
> +++ b/drivers/cpufreq/e_powersaver.c
> @@ -223,7 +223,6 @@ static int eps_cpu_init(struct cpufreq_policy *policy)
> case EPS_BRAND_C3:
> pr_cont("C3\n");
> return -ENODEV;
> - break;
> }
> /* Enable Enhanced PowerSaver */
> rdmsrl(MSR_IA32_MISC_ENABLE, val);
> diff --git a/drivers/cpufreq/longhaul.c b/drivers/cpufreq/longhaul.c
> index 123fb006810d..182a4dbca095 100644
> --- a/drivers/cpufreq/longhaul.c
> +++ b/drivers/cpufreq/longhaul.c
> @@ -593,7 +593,6 @@ static void longhaul_setup_voltagescaling(void)
> break;
> default:
> return;
> - break;
> }
> if (min_vid_speed >= highest_speed)
> return;
> --
Applied as 5.10-rc material with some subject and changelog edits, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-10-27 17:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-23 9:58 [PATCH -next] cpufreq: remove unnecessary break Zhang Qilong
2020-10-23 9:49 ` Viresh Kumar
2020-10-27 17:44 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).