linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] thermal: bcm2835: remove redundant dev_err call in bcm2835_thermal_probe()
@ 2021-04-08 10:03 Ruiqi Gong
  2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/bcm2835: Remove " thermal-bot for Ruiqi Gong
  2021-04-20  7:20 ` thermal-bot for Ruiqi Gong
  0 siblings, 2 replies; 3+ messages in thread
From: Ruiqi Gong @ 2021-04-08 10:03 UTC (permalink / raw)
  To: gongruiqi1, Zhang Rui, Daniel Lezcano, Nicolas Saenz Julienne,
	Florian Fainelli, Ray Jui, Scott Branden,
	bcm-kernel-feedback-list
  Cc: Wang Weiyang, linux-pm, linux-rpi-kernel, linux-arm-kernel,
	kernel-janitors, linux-kernel

There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
---
 drivers/thermal/broadcom/bcm2835_thermal.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
index 3199977f1e73..c8e4344d5a3d 100644
--- a/drivers/thermal/broadcom/bcm2835_thermal.c
+++ b/drivers/thermal/broadcom/bcm2835_thermal.c
@@ -184,7 +184,6 @@ static int bcm2835_thermal_probe(struct platform_device *pdev)
 	data->regs = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(data->regs)) {
 		err = PTR_ERR(data->regs);
-		dev_err(&pdev->dev, "Could not get registers: %d\n", err);
 		return err;
 	}
 


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [thermal: thermal/next] thermal/drivers/bcm2835: Remove redundant dev_err call in bcm2835_thermal_probe()
  2021-04-08 10:03 [PATCH -next] thermal: bcm2835: remove redundant dev_err call in bcm2835_thermal_probe() Ruiqi Gong
@ 2021-04-15 12:03 ` thermal-bot for Ruiqi Gong
  2021-04-20  7:20 ` thermal-bot for Ruiqi Gong
  1 sibling, 0 replies; 3+ messages in thread
From: thermal-bot for Ruiqi Gong @ 2021-04-15 12:03 UTC (permalink / raw)
  To: linux-pm; +Cc: Hulk Robot, Ruiqi Gong, Daniel Lezcano, rui.zhang, amitk

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     70955f08376c9812594730fb397dd6c5439c24fd
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//70955f08376c9812594730fb397dd6c5439c24fd
Author:        Ruiqi Gong <gongruiqi1@huawei.com>
AuthorDate:    Thu, 08 Apr 2021 06:03:29 -04:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Thu, 15 Apr 2021 13:21:43 +02:00

thermal/drivers/bcm2835: Remove redundant dev_err call in bcm2835_thermal_probe()

There is a error message within devm_ioremap_resource already, so
remove the dev_err call to avoid redundant error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210408100329.7585-1-gongruiqi1@huawei.com
---
 drivers/thermal/broadcom/bcm2835_thermal.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
index 3199977..c8e4344 100644
--- a/drivers/thermal/broadcom/bcm2835_thermal.c
+++ b/drivers/thermal/broadcom/bcm2835_thermal.c
@@ -184,7 +184,6 @@ static int bcm2835_thermal_probe(struct platform_device *pdev)
 	data->regs = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(data->regs)) {
 		err = PTR_ERR(data->regs);
-		dev_err(&pdev->dev, "Could not get registers: %d\n", err);
 		return err;
 	}
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [thermal: thermal/next] thermal/drivers/bcm2835: Remove redundant dev_err call in bcm2835_thermal_probe()
  2021-04-08 10:03 [PATCH -next] thermal: bcm2835: remove redundant dev_err call in bcm2835_thermal_probe() Ruiqi Gong
  2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/bcm2835: Remove " thermal-bot for Ruiqi Gong
@ 2021-04-20  7:20 ` thermal-bot for Ruiqi Gong
  1 sibling, 0 replies; 3+ messages in thread
From: thermal-bot for Ruiqi Gong @ 2021-04-20  7:20 UTC (permalink / raw)
  To: linux-pm; +Cc: Hulk Robot, Ruiqi Gong, Daniel Lezcano, rui.zhang, amitk

The following commit has been merged into the thermal/next branch of thermal:

Commit-ID:     d1ab7c3a33d27e7b63fd6207d88852561072ae36
Gitweb:        https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//d1ab7c3a33d27e7b63fd6207d88852561072ae36
Author:        Ruiqi Gong <gongruiqi1@huawei.com>
AuthorDate:    Thu, 08 Apr 2021 06:03:29 -04:00
Committer:     Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Tue, 20 Apr 2021 08:58:47 +02:00

thermal/drivers/bcm2835: Remove redundant dev_err call in bcm2835_thermal_probe()

There is a error message within devm_ioremap_resource already, so
remove the dev_err call to avoid redundant error message.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Ruiqi Gong <gongruiqi1@huawei.com>
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: https://lore.kernel.org/r/20210408100329.7585-1-gongruiqi1@huawei.com
---
 drivers/thermal/broadcom/bcm2835_thermal.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/thermal/broadcom/bcm2835_thermal.c b/drivers/thermal/broadcom/bcm2835_thermal.c
index 3199977..c8e4344 100644
--- a/drivers/thermal/broadcom/bcm2835_thermal.c
+++ b/drivers/thermal/broadcom/bcm2835_thermal.c
@@ -184,7 +184,6 @@ static int bcm2835_thermal_probe(struct platform_device *pdev)
 	data->regs = devm_ioremap_resource(&pdev->dev, res);
 	if (IS_ERR(data->regs)) {
 		err = PTR_ERR(data->regs);
-		dev_err(&pdev->dev, "Could not get registers: %d\n", err);
 		return err;
 	}
 

^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-04-20  7:20 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-08 10:03 [PATCH -next] thermal: bcm2835: remove redundant dev_err call in bcm2835_thermal_probe() Ruiqi Gong
2021-04-15 12:03 ` [thermal: thermal/next] thermal/drivers/bcm2835: Remove " thermal-bot for Ruiqi Gong
2021-04-20  7:20 ` thermal-bot for Ruiqi Gong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).