linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Maximilian Luz <luzmaximilian@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel test robot <lkp@intel.com>
Subject: Re: [PATCH] power: supply: surface-charger: Fix type of integer variable
Date: Fri, 4 Jun 2021 14:58:36 +0200	[thread overview]
Message-ID: <20210604125836.ew4y27ofa4bwi6uk@earth.universe> (raw)
In-Reply-To: <55aafbea-96d4-29f2-8d8b-68f8ac970c6b@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]

Hi,

On Thu, Jun 03, 2021 at 08:37:13PM +0200, Maximilian Luz wrote:
> On 5/11/21 11:24 AM, Maximilian Luz wrote:
> > The ac->state field is __le32, not u32. So change the variable we're
> > temporarily storing it in to __le32 as well.
> > 
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
> > Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
> 
> Friendly ping :)

Thanks, this has now been queued to my fixes branch.

-- Sebastian

> > ---
> >   drivers/power/supply/surface_charger.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> > index 81a5b79822c9..a060c36c7766 100644
> > --- a/drivers/power/supply/surface_charger.c
> > +++ b/drivers/power/supply/surface_charger.c
> > @@ -66,7 +66,7 @@ struct spwr_ac_device {
> >   static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
> >   {
> > -	u32 old = ac->state;
> > +	__le32 old = ac->state;
> >   	int status;
> >   	lockdep_assert_held(&ac->lock);
> > 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2021-06-04 12:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-11  9:24 [PATCH] power: supply: surface-charger: Fix type of integer variable Maximilian Luz
2021-06-03 18:37 ` Maximilian Luz
2021-06-04 12:58   ` Sebastian Reichel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210604125836.ew4y27ofa4bwi6uk@earth.universe \
    --to=sebastian.reichel@collabora.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=luzmaximilian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).