* [PATCH] power: supply: surface-charger: Fix type of integer variable
@ 2021-05-11 9:24 Maximilian Luz
2021-06-03 18:37 ` Maximilian Luz
0 siblings, 1 reply; 3+ messages in thread
From: Maximilian Luz @ 2021-05-11 9:24 UTC (permalink / raw)
To: Sebastian Reichel
Cc: Maximilian Luz, linux-pm, linux-kernel, kernel test robot
The ac->state field is __le32, not u32. So change the variable we're
temporarily storing it in to __le32 as well.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
---
drivers/power/supply/surface_charger.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
index 81a5b79822c9..a060c36c7766 100644
--- a/drivers/power/supply/surface_charger.c
+++ b/drivers/power/supply/surface_charger.c
@@ -66,7 +66,7 @@ struct spwr_ac_device {
static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
{
- u32 old = ac->state;
+ __le32 old = ac->state;
int status;
lockdep_assert_held(&ac->lock);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: surface-charger: Fix type of integer variable
2021-05-11 9:24 [PATCH] power: supply: surface-charger: Fix type of integer variable Maximilian Luz
@ 2021-06-03 18:37 ` Maximilian Luz
2021-06-04 12:58 ` Sebastian Reichel
0 siblings, 1 reply; 3+ messages in thread
From: Maximilian Luz @ 2021-06-03 18:37 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: linux-pm, linux-kernel, kernel test robot
On 5/11/21 11:24 AM, Maximilian Luz wrote:
> The ac->state field is __le32, not u32. So change the variable we're
> temporarily storing it in to __le32 as well.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
> Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Friendly ping :)
> ---
> drivers/power/supply/surface_charger.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> index 81a5b79822c9..a060c36c7766 100644
> --- a/drivers/power/supply/surface_charger.c
> +++ b/drivers/power/supply/surface_charger.c
> @@ -66,7 +66,7 @@ struct spwr_ac_device {
>
> static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
> {
> - u32 old = ac->state;
> + __le32 old = ac->state;
> int status;
>
> lockdep_assert_held(&ac->lock);
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] power: supply: surface-charger: Fix type of integer variable
2021-06-03 18:37 ` Maximilian Luz
@ 2021-06-04 12:58 ` Sebastian Reichel
0 siblings, 0 replies; 3+ messages in thread
From: Sebastian Reichel @ 2021-06-04 12:58 UTC (permalink / raw)
To: Maximilian Luz; +Cc: linux-pm, linux-kernel, kernel test robot
[-- Attachment #1: Type: text/plain, Size: 1161 bytes --]
Hi,
On Thu, Jun 03, 2021 at 08:37:13PM +0200, Maximilian Luz wrote:
> On 5/11/21 11:24 AM, Maximilian Luz wrote:
> > The ac->state field is __le32, not u32. So change the variable we're
> > temporarily storing it in to __le32 as well.
> >
> > Reported-by: kernel test robot <lkp@intel.com>
> > Fixes: e61ffb344591 ("power: supply: Add AC driver for Surface Aggregator Module")
> > Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
>
> Friendly ping :)
Thanks, this has now been queued to my fixes branch.
-- Sebastian
> > ---
> > drivers/power/supply/surface_charger.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/power/supply/surface_charger.c b/drivers/power/supply/surface_charger.c
> > index 81a5b79822c9..a060c36c7766 100644
> > --- a/drivers/power/supply/surface_charger.c
> > +++ b/drivers/power/supply/surface_charger.c
> > @@ -66,7 +66,7 @@ struct spwr_ac_device {
> > static int spwr_ac_update_unlocked(struct spwr_ac_device *ac)
> > {
> > - u32 old = ac->state;
> > + __le32 old = ac->state;
> > int status;
> > lockdep_assert_held(&ac->lock);
> >
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-06-04 12:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-05-11 9:24 [PATCH] power: supply: surface-charger: Fix type of integer variable Maximilian Luz
2021-06-03 18:37 ` Maximilian Luz
2021-06-04 12:58 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).