* [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind
@ 2022-05-12 9:38 Zheng Bin
2022-06-07 13:16 ` Zhengbin (OSKernel)
2022-06-09 22:22 ` Sebastian Reichel
0 siblings, 2 replies; 6+ messages in thread
From: Zheng Bin @ 2022-05-12 9:38 UTC (permalink / raw)
To: sre, linux-pm, linux-kernel; +Cc: zhengbin13, gaochao49
ab8500_charger_bind misses destroy_workqueue in error path,
this patch fixes that.
Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
---
drivers/power/supply/ab8500_charger.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
index d04d087caa50..a5d055a628e7 100644
--- a/drivers/power/supply/ab8500_charger.c
+++ b/drivers/power/supply/ab8500_charger.c
@@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
ret = component_bind_all(dev, di);
if (ret) {
dev_err(dev, "can't bind component devices\n");
+ destroy_workqueue(di->charger_wq);
return ret;
}
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind
2022-05-12 9:38 [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind Zheng Bin
@ 2022-06-07 13:16 ` Zhengbin (OSKernel)
2022-06-09 22:22 ` Sebastian Reichel
1 sibling, 0 replies; 6+ messages in thread
From: Zhengbin (OSKernel) @ 2022-06-07 13:16 UTC (permalink / raw)
To: sre, linux-pm, linux-kernel, sebastian.reichel, gregkh; +Cc: gaochao49
friendly ping
On 2022/5/12 17:38, Zheng Bin wrote:
> ab8500_charger_bind misses destroy_workqueue in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
> drivers/power/supply/ab8500_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index d04d087caa50..a5d055a628e7 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
> ret = component_bind_all(dev, di);
> if (ret) {
> dev_err(dev, "can't bind component devices\n");
> + destroy_workqueue(di->charger_wq);
> return ret;
> }
>
> --
> 2.31.1
>
> .
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind
2022-05-12 9:38 [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind Zheng Bin
2022-06-07 13:16 ` Zhengbin (OSKernel)
@ 2022-06-09 22:22 ` Sebastian Reichel
2022-06-16 6:10 ` Zhengbin (OSKernel)
2022-06-23 14:20 ` Linus Walleij
1 sibling, 2 replies; 6+ messages in thread
From: Sebastian Reichel @ 2022-06-09 22:22 UTC (permalink / raw)
To: Zheng Bin; +Cc: linux-pm, linux-kernel, gaochao49, Linus Walleij
[-- Attachment #1: Type: text/plain, Size: 909 bytes --]
Hi,
On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> ab8500_charger_bind misses destroy_workqueue in error path,
> this patch fixes that.
>
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
LGTM, but adding Linus to Cc and waiting a bit to give him time to
react.
-- Sebastian
> drivers/power/supply/ab8500_charger.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
> index d04d087caa50..a5d055a628e7 100644
> --- a/drivers/power/supply/ab8500_charger.c
> +++ b/drivers/power/supply/ab8500_charger.c
> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
> ret = component_bind_all(dev, di);
> if (ret) {
> dev_err(dev, "can't bind component devices\n");
> + destroy_workqueue(di->charger_wq);
> return ret;
> }
>
> --
> 2.31.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind
2022-06-09 22:22 ` Sebastian Reichel
@ 2022-06-16 6:10 ` Zhengbin (OSKernel)
2022-06-23 14:20 ` Linus Walleij
1 sibling, 0 replies; 6+ messages in thread
From: Zhengbin (OSKernel) @ 2022-06-16 6:10 UTC (permalink / raw)
To: Sebastian Reichel, Linus Walleij; +Cc: linux-pm, linux-kernel, gaochao49
On 2022/6/10 6:22, Sebastian Reichel wrote:
> Hi,
>
> On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
>> ab8500_charger_bind misses destroy_workqueue in error path,
>> this patch fixes that.
>>
>> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
>> ---
> LGTM, but adding Linus to Cc and waiting a bit to give him time to
> react.
>
> -- Sebastian
ping
>
>> drivers/power/supply/ab8500_charger.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/power/supply/ab8500_charger.c b/drivers/power/supply/ab8500_charger.c
>> index d04d087caa50..a5d055a628e7 100644
>> --- a/drivers/power/supply/ab8500_charger.c
>> +++ b/drivers/power/supply/ab8500_charger.c
>> @@ -3378,6 +3378,7 @@ static int ab8500_charger_bind(struct device *dev)
>> ret = component_bind_all(dev, di);
>> if (ret) {
>> dev_err(dev, "can't bind component devices\n");
>> + destroy_workqueue(di->charger_wq);
>> return ret;
>> }
>>
>> --
>> 2.31.1
>>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind
2022-06-09 22:22 ` Sebastian Reichel
2022-06-16 6:10 ` Zhengbin (OSKernel)
@ 2022-06-23 14:20 ` Linus Walleij
2022-07-16 23:08 ` Sebastian Reichel
1 sibling, 1 reply; 6+ messages in thread
From: Linus Walleij @ 2022-06-23 14:20 UTC (permalink / raw)
To: Sebastian Reichel; +Cc: Zheng Bin, linux-pm, linux-kernel, gaochao49
On Fri, Jun 10, 2022 at 12:22 AM Sebastian Reichel
<sebastian.reichel@collabora.com> wrote:
> On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> > ab8500_charger_bind misses destroy_workqueue in error path,
> > this patch fixes that.
> >
> > Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> > ---
>
> LGTM, but adding Linus to Cc and waiting a bit to give him time to
> react.
Don't have the original patch in my inbox so can't test it, but looks
reasonable so:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind
2022-06-23 14:20 ` Linus Walleij
@ 2022-07-16 23:08 ` Sebastian Reichel
0 siblings, 0 replies; 6+ messages in thread
From: Sebastian Reichel @ 2022-07-16 23:08 UTC (permalink / raw)
To: Linus Walleij; +Cc: Zheng Bin, linux-pm, linux-kernel, gaochao49
[-- Attachment #1: Type: text/plain, Size: 677 bytes --]
Hi,
On Thu, Jun 23, 2022 at 04:20:52PM +0200, Linus Walleij wrote:
> On Fri, Jun 10, 2022 at 12:22 AM Sebastian Reichel
> <sebastian.reichel@collabora.com> wrote:
> > On Thu, May 12, 2022 at 05:38:44PM +0800, Zheng Bin wrote:
> > > ab8500_charger_bind misses destroy_workqueue in error path,
> > > this patch fixes that.
> > >
> > > Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> > > ---
> >
> > LGTM, but adding Linus to Cc and waiting a bit to give him time to
> > react.
>
> Don't have the original patch in my inbox so can't test it, but looks
> reasonable so:
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
Thanks, queued.
-- Sebastian
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-16 23:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-12 9:38 [PATCH -next] power: supply: ab8500: add missing destroy_workqueue in ab8500_charger_bind Zheng Bin
2022-06-07 13:16 ` Zhengbin (OSKernel)
2022-06-09 22:22 ` Sebastian Reichel
2022-06-16 6:10 ` Zhengbin (OSKernel)
2022-06-23 14:20 ` Linus Walleij
2022-07-16 23:08 ` Sebastian Reichel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).