* [PATCH v2 14/14] cpufreq: CPPC: remove the acpi_disabled check
@ 2022-07-09 14:20 Perry Yuan
2022-07-11 19:29 ` Nathan Fontenot
0 siblings, 1 reply; 3+ messages in thread
From: Perry Yuan @ 2022-07-09 14:20 UTC (permalink / raw)
To: rafael.j.wysocki, viresh.kumar, Ray.Huang
Cc: Deepak.Sharma, Mario.Limonciello, Nathan.Fontenot,
Alexander.Deucher, Jinzhou.Su, Xinmei.Huang, Xiaojian.Du,
Li.Meng, linux-pm, linux-kernel, Perry Yuan
"acpi_cpc_valid" function already includes the acpi_disabled check and we can
remove the duplicated check here
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
---
drivers/cpufreq/cppc_cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
index 24eaf0ec344d..9adb7612993e 100644
--- a/drivers/cpufreq/cppc_cpufreq.c
+++ b/drivers/cpufreq/cppc_cpufreq.c
@@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void)
{
int ret;
- if ((acpi_disabled) || !acpi_cpc_valid())
+ if (!acpi_cpc_valid())
return -ENODEV;
cppc_check_hisi_workaround();
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 14/14] cpufreq: CPPC: remove the acpi_disabled check
2022-07-09 14:20 [PATCH v2 14/14] cpufreq: CPPC: remove the acpi_disabled check Perry Yuan
@ 2022-07-11 19:29 ` Nathan Fontenot
2022-07-12 4:19 ` Yuan, Perry
0 siblings, 1 reply; 3+ messages in thread
From: Nathan Fontenot @ 2022-07-11 19:29 UTC (permalink / raw)
To: Perry Yuan, rafael.j.wysocki, viresh.kumar, Ray.Huang
Cc: Deepak.Sharma, Mario.Limonciello, Nathan.Fontenot,
Alexander.Deucher, Jinzhou.Su, Xinmei.Huang, Xiaojian.Du,
Li.Meng, linux-pm, linux-kernel
On 7/9/22 09:20, Perry Yuan wrote:
> "acpi_cpc_valid" function already includes the acpi_disabled check and we can
> remove the duplicated check here
>
> Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> ---
> drivers/cpufreq/cppc_cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 24eaf0ec344d..9adb7612993e 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void)
> {
> int ret;
>
> - if ((acpi_disabled) || !acpi_cpc_valid())
> + if (!acpi_cpc_valid())
Same comment here as for patch 13/14, this change should be part of patch 11/14.
-Nathan
> return -ENODEV;
>
> cppc_check_hisi_workaround();
^ permalink raw reply [flat|nested] 3+ messages in thread
* RE: [PATCH v2 14/14] cpufreq: CPPC: remove the acpi_disabled check
2022-07-11 19:29 ` Nathan Fontenot
@ 2022-07-12 4:19 ` Yuan, Perry
0 siblings, 0 replies; 3+ messages in thread
From: Yuan, Perry @ 2022-07-12 4:19 UTC (permalink / raw)
To: Fontenot, Nathan, rafael.j.wysocki, viresh.kumar, Huang, Ray
Cc: Sharma, Deepak, Limonciello, Mario, Deucher, Alexander, Su,
Jinzhou (Joe), Huang, Shimmer, Du, Xiaojian, Meng, Li (Jassmine),
linux-pm, linux-kernel
[AMD Official Use Only - General]
Hi Nathan.
> -----Original Message-----
> From: Fontenot, Nathan <Nathan.Fontenot@amd.com>
> Sent: Tuesday, July 12, 2022 3:30 AM
> To: Yuan, Perry <Perry.Yuan@amd.com>; rafael.j.wysocki@intel.com;
> viresh.kumar@linaro.org; Huang, Ray <Ray.Huang@amd.com>
> Cc: Sharma, Deepak <Deepak.Sharma@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Fontenot, Nathan
> <Nathan.Fontenot@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>;
> Huang, Shimmer <Shimmer.Huang@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 14/14] cpufreq: CPPC: remove the acpi_disabled
> check
>
> On 7/9/22 09:20, Perry Yuan wrote:
> > "acpi_cpc_valid" function already includes the acpi_disabled check and
> > we can remove the duplicated check here
> >
> > Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
> > ---
> > drivers/cpufreq/cppc_cpufreq.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/cppc_cpufreq.c
> > b/drivers/cpufreq/cppc_cpufreq.c index 24eaf0ec344d..9adb7612993e
> > 100644
> > --- a/drivers/cpufreq/cppc_cpufreq.c
> > +++ b/drivers/cpufreq/cppc_cpufreq.c
> > @@ -947,7 +947,7 @@ static int __init cppc_cpufreq_init(void) {
> > int ret;
> >
> > - if ((acpi_disabled) || !acpi_cpc_valid())
> > + if (!acpi_cpc_valid())
>
> Same comment here as for patch 13/14, this change should be part of patch
> 11/14.
>
> -Nathan
I can do that, at first, I also want to make the changes in one patch, but I posted this patch to see if maintainers can accept this way or another way.
Perry.
>
> > return -ENODEV;
> >
> > cppc_check_hisi_workaround();
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-07-12 4:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-09 14:20 [PATCH v2 14/14] cpufreq: CPPC: remove the acpi_disabled check Perry Yuan
2022-07-11 19:29 ` Nathan Fontenot
2022-07-12 4:19 ` Yuan, Perry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).