From: Fabien Parent <fabien.parent@linaro.org>
To: ilia.lin@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, rafael@kernel.org,
viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org,
Fabien Parent <fabien.parent@linaro.org>
Subject: [PATCH 3/3] cpufreq: qcom: fix writes in read-only memory region
Date: Sat, 1 Oct 2022 19:10:27 +0200 [thread overview]
Message-ID: <20221001171027.2101923-3-fabien.parent@linaro.org> (raw)
In-Reply-To: <20221001171027.2101923-1-fabien.parent@linaro.org>
This commit fixes a kernel oops because of a write in some read-only memory:
[ 9.068287] Unable to handle kernel write to read-only memory at virtual address ffff800009240ad8
..snip..
[ 9.138790] Internal error: Oops: 9600004f [#1] PREEMPT SMP
..snip..
[ 9.269161] Call trace:
[ 9.276271] __memcpy+0x5c/0x230
[ 9.278531] snprintf+0x58/0x80
[ 9.282002] qcom_cpufreq_msm8939_name_version+0xb4/0x190
[ 9.284869] qcom_cpufreq_probe+0xc8/0x39c
..snip..
The following line defines a pointer that point to a char buffer stored
in read-only memory:
char *pvs_name = PVS_NAME;
This pointer is meant to hold a template "speedXX-pvsXX-vXX" where the
XX values get overridden by the qcom_cpufreq_krait_name_version function. Since
the template is actually stored in read-only memory, when the function
executes the following call we get an oops:
snprintf(*pvs_name, sizeof(PVS_NAME), "speed%d-pvs%d-v%d",
speed, pvs, pvs_ver);
To fix this issue, we instead store the template name onto the stack by
using the following syntax:
char pvs_name_buffer[] = PVS_NAME;
Because the `pvs_name` needs to be able to be assigned to NULL, the
template buffer is stored in the pvs_name_template and not under the
pvs_name variable.
Signed-off-by: Fabien Parent <fabien.parent@linaro.org>
---
drivers/cpufreq/qcom-cpufreq-nvmem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/cpufreq/qcom-cpufreq-nvmem.c b/drivers/cpufreq/qcom-cpufreq-nvmem.c
index 64ce077a4848..3e097262f612 100644
--- a/drivers/cpufreq/qcom-cpufreq-nvmem.c
+++ b/drivers/cpufreq/qcom-cpufreq-nvmem.c
@@ -269,7 +269,8 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
struct nvmem_cell *speedbin_nvmem;
struct device_node *np;
struct device *cpu_dev;
- char *pvs_name = PVS_NAME_TEMPLATE;
+ char pvs_name_buffer[] = PVS_NAME_TEMPLATE;
+ char *pvs_name = pvs_name_buffer;
unsigned cpu;
const struct of_device_id *match;
int ret;
--
2.37.2
next prev parent reply other threads:[~2022-10-01 17:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 17:10 [PATCH 1/3] cpufreq: qcom: fix memory leak in error path Fabien Parent
2022-10-01 17:10 ` [PATCH 2/3] cpufreq: qcom: pass pvs_name size along with its buffer Fabien Parent
2022-10-10 5:52 ` Viresh Kumar
2022-10-10 6:01 ` Viresh Kumar
2022-10-01 17:10 ` Fabien Parent [this message]
2022-10-10 6:00 ` [PATCH 3/3] cpufreq: qcom: fix writes in read-only memory region Viresh Kumar
2022-10-10 5:55 ` [PATCH 1/3] cpufreq: qcom: fix memory leak in error path Viresh Kumar
2022-10-10 6:02 ` Viresh Kumar
2022-10-15 12:57 ` Fabien Parent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221001171027.2101923-3-fabien.parent@linaro.org \
--to=fabien.parent@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=ilia.lin@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).