From: Viresh Kumar <viresh.kumar@linaro.org>
To: Fabien Parent <fabien.parent@linaro.org>
Cc: ilia.lin@kernel.org, agross@kernel.org,
bjorn.andersson@linaro.org, rafael@kernel.org,
linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] cpufreq: qcom: pass pvs_name size along with its buffer
Date: Mon, 10 Oct 2022 11:22:51 +0530 [thread overview]
Message-ID: <20221010055251.ulgevsdqudors3t3@vireshk-i7> (raw)
In-Reply-To: <20221001171027.2101923-2-fabien.parent@linaro.org>
On 01-10-22, 19:10, Fabien Parent wrote:
> @@ -265,7 +269,7 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
> struct nvmem_cell *speedbin_nvmem;
> struct device_node *np;
> struct device *cpu_dev;
> - char *pvs_name = "speedXX-pvsXX-vXX";
> + char *pvs_name = PVS_NAME_TEMPLATE;
> unsigned cpu;
> const struct of_device_id *match;
> int ret;
> @@ -306,8 +310,8 @@ static int qcom_cpufreq_probe(struct platform_device *pdev)
> goto free_drv;
> }
>
> - ret = drv->data->get_version(cpu_dev,
> - speedbin_nvmem, &pvs_name, drv);
> + ret = drv->data->get_version(cpu_dev, speedbin_nvmem, &pvs_name,
> + sizeof(PVS_NAME_TEMPLATE), drv);
Since the pvs name is always PVS_NAME_TEMPLATE, why are we even
passing it and size here ? Why not directly use it in those
get_version() implementations directly ?
> if (ret) {
> nvmem_cell_put(speedbin_nvmem);
> goto free_drv;
> --
> 2.37.2
--
viresh
next prev parent reply other threads:[~2022-10-10 5:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-01 17:10 [PATCH 1/3] cpufreq: qcom: fix memory leak in error path Fabien Parent
2022-10-01 17:10 ` [PATCH 2/3] cpufreq: qcom: pass pvs_name size along with its buffer Fabien Parent
2022-10-10 5:52 ` Viresh Kumar [this message]
2022-10-10 6:01 ` Viresh Kumar
2022-10-01 17:10 ` [PATCH 3/3] cpufreq: qcom: fix writes in read-only memory region Fabien Parent
2022-10-10 6:00 ` Viresh Kumar
2022-10-10 5:55 ` [PATCH 1/3] cpufreq: qcom: fix memory leak in error path Viresh Kumar
2022-10-10 6:02 ` Viresh Kumar
2022-10-15 12:57 ` Fabien Parent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221010055251.ulgevsdqudors3t3@vireshk-i7 \
--to=viresh.kumar@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=fabien.parent@linaro.org \
--cc=ilia.lin@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).