* [PATCH] thermal/drivers/qcom: Demote error log of thermal zone register to debug
@ 2022-10-29 5:29 Manivannan Sadhasivam
2022-12-09 15:26 ` [thermal: thermal/next] " thermal-bot for Manivannan Sadhasivam
0 siblings, 1 reply; 2+ messages in thread
From: Manivannan Sadhasivam @ 2022-10-29 5:29 UTC (permalink / raw)
To: amitk, thara.gopinath
Cc: andersson, konrad.dybcio, rafael, daniel.lezcano, rui.zhang,
linux-pm, linux-arm-msm, linux-kernel, steev,
Manivannan Sadhasivam
devm_thermal_of_zone_register() can fail with -ENODEV if thermal zone for
the channel is not represented in DT. This is perfectly fine since not all
sensors needs to be used for thermal zones but only a few in real world.
So demote the error log to debug to avoid spamming users.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
index 1b2c43eab27d..ba73336d4d41 100644
--- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
+++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
@@ -678,7 +678,7 @@ static int adc_tm5_register_tzd(struct adc_tm5_chip *adc_tm)
&adc_tm5_thermal_ops);
if (IS_ERR(tzd)) {
if (PTR_ERR(tzd) == -ENODEV) {
- dev_warn(adc_tm->dev, "thermal sensor on channel %d is not used\n",
+ dev_dbg(adc_tm->dev, "thermal sensor on channel %d is not used\n",
adc_tm->channels[i].channel);
continue;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [thermal: thermal/next] thermal/drivers/qcom: Demote error log of thermal zone register to debug
2022-10-29 5:29 [PATCH] thermal/drivers/qcom: Demote error log of thermal zone register to debug Manivannan Sadhasivam
@ 2022-12-09 15:26 ` thermal-bot for Manivannan Sadhasivam
0 siblings, 0 replies; 2+ messages in thread
From: thermal-bot for Manivannan Sadhasivam @ 2022-12-09 15:26 UTC (permalink / raw)
To: linux-pm
Cc: Manivannan Sadhasivam, Daniel Lezcano, rui.zhang, daniel.lezcano, amitk
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: ddbac90afd071aab37d7041b6b526222384d9d04
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//ddbac90afd071aab37d7041b6b526222384d9d04
Author: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
AuthorDate: Sat, 29 Oct 2022 10:59:33 +05:30
Committer: Daniel Lezcano <daniel.lezcano@kernel.org>
CommitterDate: Thu, 08 Dec 2022 14:30:44 +01:00
thermal/drivers/qcom: Demote error log of thermal zone register to debug
devm_thermal_of_zone_register() can fail with -ENODEV if thermal zone for
the channel is not represented in DT. This is perfectly fine since not all
sensors needs to be used for thermal zones but only a few in real world.
So demote the error log to debug to avoid spamming users.
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20221029052933.32421-1-manivannan.sadhasivam@linaro.org
Signed-off-by: Daniel Lezcano <daniel.lezcano@kernel.org>
---
drivers/thermal/qcom/qcom-spmi-adc-tm5.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
index 88462a4..ff47fc9 100644
--- a/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
+++ b/drivers/thermal/qcom/qcom-spmi-adc-tm5.c
@@ -678,7 +678,7 @@ static int adc_tm5_register_tzd(struct adc_tm5_chip *adc_tm)
&adc_tm5_thermal_ops);
if (IS_ERR(tzd)) {
if (PTR_ERR(tzd) == -ENODEV) {
- dev_warn(adc_tm->dev, "thermal sensor on channel %d is not used\n",
+ dev_dbg(adc_tm->dev, "thermal sensor on channel %d is not used\n",
adc_tm->channels[i].channel);
continue;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-12-09 15:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-29 5:29 [PATCH] thermal/drivers/qcom: Demote error log of thermal zone register to debug Manivannan Sadhasivam
2022-12-09 15:26 ` [thermal: thermal/next] " thermal-bot for Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).