* [PATCH 01/27] kbuild, power: reset: keystone-reset: remove MODULE_LICENSE in non-modules
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
@ 2023-02-22 12:14 ` Nick Alcock
2023-02-22 12:14 ` [PATCH 14/27] kbuild, cpufreq: tegra124: " Nick Alcock
2023-02-22 12:14 ` [PATCH 15/27] kbuild, cpufreq: " Nick Alcock
2 siblings, 0 replies; 5+ messages in thread
From: Nick Alcock @ 2023-02-22 12:14 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Santosh Shilimkar,
Sebastian Reichel, linux-pm
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Santosh Shilimkar <ssantosh@kernel.org>
Cc: Sebastian Reichel <sre@kernel.org>
Cc: linux-pm@vger.kernel.org
---
drivers/power/reset/keystone-reset.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/power/reset/keystone-reset.c b/drivers/power/reset/keystone-reset.c
index c720112db704..83a4e1c9bf94 100644
--- a/drivers/power/reset/keystone-reset.c
+++ b/drivers/power/reset/keystone-reset.c
@@ -169,5 +169,4 @@ module_platform_driver(rsctrl_driver);
MODULE_AUTHOR("Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>");
MODULE_DESCRIPTION("Texas Instruments keystone reset driver");
-MODULE_LICENSE("GPL v2");
MODULE_ALIAS("platform:" KBUILD_MODNAME);
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 14/27] kbuild, cpufreq: tegra124: remove MODULE_LICENSE in non-modules
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 01/27] kbuild, power: reset: keystone-reset: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-02-22 12:14 ` Nick Alcock
2023-02-23 4:20 ` Viresh Kumar
2023-02-22 12:14 ` [PATCH 15/27] kbuild, cpufreq: " Nick Alcock
2 siblings, 1 reply; 5+ messages in thread
From: Nick Alcock @ 2023-02-22 12:14 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Rafael J. Wysocki,
Viresh Kumar, Thierry Reding, Jonathan Hunter, linux-pm,
linux-tegra
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: Jonathan Hunter <jonathanh@nvidia.com>
Cc: linux-pm@vger.kernel.org
Cc: linux-tegra@vger.kernel.org
---
drivers/cpufreq/tegra124-cpufreq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/tegra124-cpufreq.c b/drivers/cpufreq/tegra124-cpufreq.c
index 7a1ea6fdcab6..788672c0c834 100644
--- a/drivers/cpufreq/tegra124-cpufreq.c
+++ b/drivers/cpufreq/tegra124-cpufreq.c
@@ -221,4 +221,3 @@ module_init(tegra_cpufreq_init);
MODULE_AUTHOR("Tuomas Tynkkynen <ttynkkynen@nvidia.com>");
MODULE_DESCRIPTION("cpufreq driver for NVIDIA Tegra124");
-MODULE_LICENSE("GPL v2");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 15/27] kbuild, cpufreq: remove MODULE_LICENSE in non-modules
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 01/27] kbuild, power: reset: keystone-reset: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-22 12:14 ` [PATCH 14/27] kbuild, cpufreq: tegra124: " Nick Alcock
@ 2023-02-22 12:14 ` Nick Alcock
2023-02-23 4:20 ` Viresh Kumar
2 siblings, 1 reply; 5+ messages in thread
From: Nick Alcock @ 2023-02-22 12:14 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Rafael J. Wysocki,
Viresh Kumar, linux-pm
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linux-pm@vger.kernel.org
---
drivers/cpufreq/freq_table.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/cpufreq/freq_table.c b/drivers/cpufreq/freq_table.c
index 67e56cf638ef..90bfc27ed1ba 100644
--- a/drivers/cpufreq/freq_table.c
+++ b/drivers/cpufreq/freq_table.c
@@ -367,4 +367,3 @@ int cpufreq_table_validate_and_sort(struct cpufreq_policy *policy)
MODULE_AUTHOR("Dominik Brodowski <linux@brodo.de>");
MODULE_DESCRIPTION("CPUfreq frequency table helpers");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 14/27] kbuild, cpufreq: tegra124: remove MODULE_LICENSE in non-modules
2023-02-22 12:14 ` [PATCH 14/27] kbuild, cpufreq: tegra124: " Nick Alcock
@ 2023-02-23 4:20 ` Viresh Kumar
0 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2023-02-23 4:20 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Rafael J. Wysocki, Thierry Reding, Jonathan Hunter, linux-pm,
linux-tegra
On 22-02-23, 12:14, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: Thierry Reding <thierry.reding@gmail.com>
> Cc: Jonathan Hunter <jonathanh@nvidia.com>
> Cc: linux-pm@vger.kernel.org
> Cc: linux-tegra@vger.kernel.org
> ---
> drivers/cpufreq/tegra124-cpufreq.c | 1 -
> 1 file changed, 1 deletion(-)
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 15/27] kbuild, cpufreq: remove MODULE_LICENSE in non-modules
2023-02-22 12:14 ` [PATCH 15/27] kbuild, cpufreq: " Nick Alcock
@ 2023-02-23 4:20 ` Viresh Kumar
0 siblings, 0 replies; 5+ messages in thread
From: Viresh Kumar @ 2023-02-23 4:20 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Rafael J. Wysocki, linux-pm
On 22-02-23, 12:14, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
> Cc: Luis Chamberlain <mcgrof@kernel.org>
> Cc: linux-modules@vger.kernel.org
> Cc: linux-kernel@vger.kernel.org
> Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel.org>
> Cc: Viresh Kumar <viresh.kumar@linaro.org>
> Cc: linux-pm@vger.kernel.org
> ---
> drivers/cpufreq/freq_table.c | 1 -
> 1 file changed, 1 deletion(-)
Applied. Thanks.
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-02-23 4:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20230222121453.91915-1-nick.alcock@oracle.com>
2023-02-22 12:14 ` [PATCH 01/27] kbuild, power: reset: keystone-reset: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-22 12:14 ` [PATCH 14/27] kbuild, cpufreq: tegra124: " Nick Alcock
2023-02-23 4:20 ` Viresh Kumar
2023-02-22 12:14 ` [PATCH 15/27] kbuild, cpufreq: " Nick Alcock
2023-02-23 4:20 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).