linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Sicelo A. Mhlongo" <absicsz@gmail.com>
To: sre@kernel.org, linux-pm@vger.kernel.org
Cc: maemo-leste@lists.dyne.org, pali@kernel.org,
	"Sicelo A. Mhlongo" <absicsz@gmail.com>
Subject: [PATCH] power: supply: bq2415x_charger: report online status
Date: Mon, 26 Feb 2024 21:44:32 +0200	[thread overview]
Message-ID: <20240226194432.2174095-1-absicsz@gmail.com> (raw)

Provide the Online property. This chip does not have specific flags to
indicate the presence of an input voltage, but this can be inferred from
the reported charging status.

Signed-off-by: Sicelo A. Mhlongo <absicsz@gmail.com>
---
 drivers/power/supply/bq2415x_charger.c | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/drivers/power/supply/bq2415x_charger.c b/drivers/power/supply/bq2415x_charger.c
index 6a4798a62588..5b47a1d0a51a 100644
--- a/drivers/power/supply/bq2415x_charger.c
+++ b/drivers/power/supply/bq2415x_charger.c
@@ -991,6 +991,7 @@ static enum power_supply_property bq2415x_power_supply_props[] = {
 	/* TODO: maybe add more power supply properties */
 	POWER_SUPPLY_PROP_STATUS,
 	POWER_SUPPLY_PROP_MODEL_NAME,
+	POWER_SUPPLY_PROP_ONLINE,
 };
 
 static int bq2415x_power_supply_get_property(struct power_supply *psy,
@@ -1017,6 +1018,14 @@ static int bq2415x_power_supply_get_property(struct power_supply *psy,
 	case POWER_SUPPLY_PROP_MODEL_NAME:
 		val->strval = bq->model;
 		break;
+	case POWER_SUPPLY_PROP_ONLINE:
+		ret = bq2415x_exec_command(bq, BQ2415X_CHARGE_STATUS);
+		/* Charger is Online when Charging or Full are reported. It is
+		 * also likely online for the Unknown/Fault state too, but
+		 * there is no way to be absolutely sure.
+		 */
+		val->intval = (ret == 1 || ret == 2);
+		break;
 	default:
 		return -EINVAL;
 	}
-- 
2.43.0


             reply	other threads:[~2024-02-26 19:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 19:44 Sicelo A. Mhlongo [this message]
2024-02-27 20:11 ` [PATCH] power: supply: bq2415x_charger: report online status Sebastian Reichel
2024-02-27 21:34   ` Sicelo
2024-02-28  0:00     ` Sebastian Reichel
2024-02-28  7:09       ` Sicelo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240226194432.2174095-1-absicsz@gmail.com \
    --to=absicsz@gmail.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=maemo-leste@lists.dyne.org \
    --cc=pali@kernel.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).