linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sicelo <absicsz@gmail.com>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: linux-pm@vger.kernel.org, maemo-leste@lists.dyne.org, pali@kernel.org
Subject: Re: [PATCH] power: supply: bq2415x_charger: report online status
Date: Wed, 28 Feb 2024 09:09:11 +0200	[thread overview]
Message-ID: <Zd7cF_MNCKg51f-B@tp440p.steeds.sam> (raw)
In-Reply-To: <5l3e3bkultb24kawad4vh3j4c6lo77i6hftumo234qgtwbk4jr@z7kbnrcgbdel>

Good Day

On Wed, Feb 28, 2024 at 01:00:20AM +0100, Sebastian Reichel wrote:
> > > 
> > > 011 - Poor input source or VBUS < UVLO
> > > 
> > Absolutely, yes. This particular state, which is a fault condition, clearly
> > indicates VBUS is present.
> 
> I assumed this might be set for a disconnected charger, considering
> that no input source is a poor input source / 0V is < UVLO.

The meaning of that one can be phrased as: you are supplying VBUS, but
it is not high enough for the chip to sustain charging.

> > However, looking at them more closely seems to suggest I should respin the
> > patch to also report VBUS online if a fault is reported instead of only
> > during charging and charge full states.
> 
> Right, so you can just check for BQ2415X_CHARGE_STATUS != 0.

Thanks. v2 sent.

Regards,
Sicelo

      reply	other threads:[~2024-02-28  7:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-26 19:44 [PATCH] power: supply: bq2415x_charger: report online status Sicelo A. Mhlongo
2024-02-27 20:11 ` Sebastian Reichel
2024-02-27 21:34   ` Sicelo
2024-02-28  0:00     ` Sebastian Reichel
2024-02-28  7:09       ` Sicelo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Zd7cF_MNCKg51f-B@tp440p.steeds.sam \
    --to=absicsz@gmail.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=maemo-leste@lists.dyne.org \
    --cc=pali@kernel.org \
    --cc=sebastian.reichel@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).