* [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung
@ 2014-12-02 6:34 Abhilash Kesavan
2014-12-02 6:34 ` [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection Abhilash Kesavan
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Abhilash Kesavan @ 2014-12-02 6:34 UTC (permalink / raw)
To: rui.zhang, edubezval, kgene.kim, linux-pm
Cc: linux-arm-kernel, b.zolnierkie, l.majewski, amit.daniel,
kesavan.abhilash
As samsung thermal support is enabled only for ARCH_EXYNOS, there is no
need to select ARCH_HAS_BANDGAP from the arch-specific code. Removing this
dependency will also allow the driver to be enabled on 64-bit SoCs.
Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
---
This was based on the discussion regarding adding ARCH_HAS_BANDGAP symbol for
arm64 here: http://www.spinics.net/lists/arm-kernel/msg377560.html
drivers/thermal/samsung/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
index f760389..c43306e 100644
--- a/drivers/thermal/samsung/Kconfig
+++ b/drivers/thermal/samsung/Kconfig
@@ -1,6 +1,6 @@
config EXYNOS_THERMAL
tristate "Exynos thermal management unit driver"
- depends on ARCH_HAS_BANDGAP && OF
+ depends on OF
help
If you say yes here you get support for the TMU (Thermal Management
Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection
2014-12-02 6:34 [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung Abhilash Kesavan
@ 2014-12-02 6:34 ` Abhilash Kesavan
2014-12-02 14:23 ` Bartlomiej Zolnierkiewicz
2014-12-08 9:44 ` Lukasz Majewski
2014-12-02 14:17 ` [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung Bartlomiej Zolnierkiewicz
2014-12-08 9:43 ` Lukasz Majewski
2 siblings, 2 replies; 8+ messages in thread
From: Abhilash Kesavan @ 2014-12-02 6:34 UTC (permalink / raw)
To: rui.zhang, edubezval, kgene.kim, linux-pm
Cc: linux-arm-kernel, b.zolnierkie, l.majewski, amit.daniel,
kesavan.abhilash
On removing the samsung thermal driver dependency on ARCH_HAS_BANDGAP,
selection of this symbol becomes redundant.
Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
---
arch/arm/mach-exynos/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
index e4a00ba..6ddfce7 100644
--- a/arch/arm/mach-exynos/Kconfig
+++ b/arch/arm/mach-exynos/Kconfig
@@ -9,7 +9,6 @@
menuconfig ARCH_EXYNOS
bool "Samsung EXYNOS" if ARCH_MULTI_V7
- select ARCH_HAS_BANDGAP
select ARCH_HAS_HOLES_MEMORYMODEL
select ARCH_REQUIRE_GPIOLIB
select ARM_AMBA
--
1.7.9.5
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung
2014-12-02 6:34 [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung Abhilash Kesavan
2014-12-02 6:34 ` [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection Abhilash Kesavan
@ 2014-12-02 14:17 ` Bartlomiej Zolnierkiewicz
2014-12-08 9:43 ` Lukasz Majewski
2 siblings, 0 replies; 8+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-12-02 14:17 UTC (permalink / raw)
To: Abhilash Kesavan
Cc: rui.zhang, edubezval, kgene.kim, linux-pm, linux-arm-kernel,
l.majewski, amit.daniel, kesavan.abhilash
Hi,
On Tuesday, December 02, 2014 12:04:32 PM Abhilash Kesavan wrote:
> As samsung thermal support is enabled only for ARCH_EXYNOS, there is no
> need to select ARCH_HAS_BANDGAP from the arch-specific code. Removing this
> dependency will also allow the driver to be enabled on 64-bit SoCs.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> ---
> This was based on the discussion regarding adding ARCH_HAS_BANDGAP symbol for
> arm64 here: http://www.spinics.net/lists/arm-kernel/msg377560.html
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> drivers/thermal/samsung/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/Kconfig b/drivers/thermal/samsung/Kconfig
> index f760389..c43306e 100644
> --- a/drivers/thermal/samsung/Kconfig
> +++ b/drivers/thermal/samsung/Kconfig
> @@ -1,6 +1,6 @@
> config EXYNOS_THERMAL
> tristate "Exynos thermal management unit driver"
> - depends on ARCH_HAS_BANDGAP && OF
> + depends on OF
> help
> If you say yes here you get support for the TMU (Thermal Management
> Unit) driver for SAMSUNG EXYNOS series of SoCs. This driver initialises
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection
2014-12-02 6:34 ` [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection Abhilash Kesavan
@ 2014-12-02 14:23 ` Bartlomiej Zolnierkiewicz
2014-12-08 9:44 ` Lukasz Majewski
1 sibling, 0 replies; 8+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2014-12-02 14:23 UTC (permalink / raw)
To: Abhilash Kesavan
Cc: rui.zhang, edubezval, kgene.kim, linux-pm, linux-arm-kernel,
l.majewski, amit.daniel, kesavan.abhilash
Hi,
On Tuesday, December 02, 2014 12:04:33 PM Abhilash Kesavan wrote:
> On removing the samsung thermal driver dependency on ARCH_HAS_BANDGAP,
> selection of this symbol becomes redundant.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
This has also a nice side-effect of removing TI_SOC_THERMAL availability
from Exynos only kernel configurations.
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics
> ---
> arch/arm/mach-exynos/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig b/arch/arm/mach-exynos/Kconfig
> index e4a00ba..6ddfce7 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -9,7 +9,6 @@
>
> menuconfig ARCH_EXYNOS
> bool "Samsung EXYNOS" if ARCH_MULTI_V7
> - select ARCH_HAS_BANDGAP
> select ARCH_HAS_HOLES_MEMORYMODEL
> select ARCH_REQUIRE_GPIOLIB
> select ARM_AMBA
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung
2014-12-02 6:34 [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung Abhilash Kesavan
2014-12-02 6:34 ` [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection Abhilash Kesavan
2014-12-02 14:17 ` [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung Bartlomiej Zolnierkiewicz
@ 2014-12-08 9:43 ` Lukasz Majewski
2014-12-10 3:56 ` Abhilash Kesavan
2 siblings, 1 reply; 8+ messages in thread
From: Lukasz Majewski @ 2014-12-08 9:43 UTC (permalink / raw)
To: Abhilash Kesavan
Cc: rui.zhang, edubezval, kgene.kim, linux-pm, linux-arm-kernel,
b.zolnierkie, amit.daniel, kesavan.abhilash
Hi Abhilash,
> As samsung thermal support is enabled only for ARCH_EXYNOS, there is
> no need to select ARCH_HAS_BANDGAP from the arch-specific code.
> Removing this dependency will also allow the driver to be enabled on
> 64-bit SoCs.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> ---
> This was based on the discussion regarding adding ARCH_HAS_BANDGAP
> symbol for arm64 here:
> http://www.spinics.net/lists/arm-kernel/msg377560.html
>
> drivers/thermal/samsung/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/samsung/Kconfig
> b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644
> --- a/drivers/thermal/samsung/Kconfig
> +++ b/drivers/thermal/samsung/Kconfig
> @@ -1,6 +1,6 @@
> config EXYNOS_THERMAL
> tristate "Exynos thermal management unit driver"
> - depends on ARCH_HAS_BANDGAP && OF
> + depends on OF
> help
> If you say yes here you get support for the TMU (Thermal
> Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This
> driver initialises
Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection
2014-12-02 6:34 ` [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection Abhilash Kesavan
2014-12-02 14:23 ` Bartlomiej Zolnierkiewicz
@ 2014-12-08 9:44 ` Lukasz Majewski
1 sibling, 0 replies; 8+ messages in thread
From: Lukasz Majewski @ 2014-12-08 9:44 UTC (permalink / raw)
To: Abhilash Kesavan
Cc: rui.zhang, edubezval, kgene.kim, linux-pm, linux-arm-kernel,
b.zolnierkie, amit.daniel, kesavan.abhilash
Hi Abhilash,
> On removing the samsung thermal driver dependency on ARCH_HAS_BANDGAP,
> selection of this symbol becomes redundant.
>
> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> ---
> arch/arm/mach-exynos/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm/mach-exynos/Kconfig
> b/arch/arm/mach-exynos/Kconfig index e4a00ba..6ddfce7 100644
> --- a/arch/arm/mach-exynos/Kconfig
> +++ b/arch/arm/mach-exynos/Kconfig
> @@ -9,7 +9,6 @@
>
> menuconfig ARCH_EXYNOS
> bool "Samsung EXYNOS" if ARCH_MULTI_V7
> - select ARCH_HAS_BANDGAP
> select ARCH_HAS_HOLES_MEMORYMODEL
> select ARCH_REQUIRE_GPIOLIB
> select ARM_AMBA
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
--
Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung
2014-12-08 9:43 ` Lukasz Majewski
@ 2014-12-10 3:56 ` Abhilash Kesavan
2014-12-10 14:41 ` Eduardo Valentin
0 siblings, 1 reply; 8+ messages in thread
From: Abhilash Kesavan @ 2014-12-10 3:56 UTC (permalink / raw)
To: Lukasz Majewski
Cc: Zhang Rui, Eduardo Valentin, Kukjin Kim, linux-pm,
linux-arm-kernel, Bartlomiej Zolnierkiewicz, Amit Kachhap
Hi Eduardo,
On Mon, Dec 8, 2014 at 3:13 PM, Lukasz Majewski <l.majewski@samsung.com> wrote:
> Hi Abhilash,
>
>> As samsung thermal support is enabled only for ARCH_EXYNOS, there is
>> no need to select ARCH_HAS_BANDGAP from the arch-specific code.
>> Removing this dependency will also allow the driver to be enabled on
>> 64-bit SoCs.
>>
>> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
>> ---
>> This was based on the discussion regarding adding ARCH_HAS_BANDGAP
>> symbol for arm64 here:
>> http://www.spinics.net/lists/arm-kernel/msg377560.html
>>
>> drivers/thermal/samsung/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/thermal/samsung/Kconfig
>> b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644
>> --- a/drivers/thermal/samsung/Kconfig
>> +++ b/drivers/thermal/samsung/Kconfig
>> @@ -1,6 +1,6 @@
>> config EXYNOS_THERMAL
>> tristate "Exynos thermal management unit driver"
>> - depends on ARCH_HAS_BANDGAP && OF
>> + depends on OF
>> help
>> If you say yes here you get support for the TMU (Thermal
>> Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This
>> driver initialises
>
> Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Can you pick up these 2 patches if they look OK ?
Regards,
Abhilash
>
> --
> Best regards,
>
> Lukasz Majewski
>
> Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung
2014-12-10 3:56 ` Abhilash Kesavan
@ 2014-12-10 14:41 ` Eduardo Valentin
0 siblings, 0 replies; 8+ messages in thread
From: Eduardo Valentin @ 2014-12-10 14:41 UTC (permalink / raw)
To: Abhilash Kesavan
Cc: Lukasz Majewski, Zhang Rui, Kukjin Kim, linux-pm,
linux-arm-kernel, Bartlomiej Zolnierkiewicz, Amit Kachhap
[-- Attachment #1: Type: text/plain, Size: 1730 bytes --]
On Wed, Dec 10, 2014 at 09:26:55AM +0530, Abhilash Kesavan wrote:
> Hi Eduardo,
>
> On Mon, Dec 8, 2014 at 3:13 PM, Lukasz Majewski <l.majewski@samsung.com> wrote:
> > Hi Abhilash,
> >
> >> As samsung thermal support is enabled only for ARCH_EXYNOS, there is
> >> no need to select ARCH_HAS_BANDGAP from the arch-specific code.
> >> Removing this dependency will also allow the driver to be enabled on
> >> 64-bit SoCs.
> >>
> >> Signed-off-by: Abhilash Kesavan <a.kesavan@samsung.com>
> >> ---
> >> This was based on the discussion regarding adding ARCH_HAS_BANDGAP
> >> symbol for arm64 here:
> >> http://www.spinics.net/lists/arm-kernel/msg377560.html
> >>
> >> drivers/thermal/samsung/Kconfig | 2 +-
> >> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/thermal/samsung/Kconfig
> >> b/drivers/thermal/samsung/Kconfig index f760389..c43306e 100644
> >> --- a/drivers/thermal/samsung/Kconfig
> >> +++ b/drivers/thermal/samsung/Kconfig
> >> @@ -1,6 +1,6 @@
> >> config EXYNOS_THERMAL
> >> tristate "Exynos thermal management unit driver"
> >> - depends on ARCH_HAS_BANDGAP && OF
> >> + depends on OF
> >> help
> >> If you say yes here you get support for the TMU (Thermal
> >> Management Unit) driver for SAMSUNG EXYNOS series of SoCs. This
> >> driver initialises
> >
> > Reviewed-by: Lukasz Majewski <l.majewski@samsung.com>
> > Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>
> Can you pick up these 2 patches if they look OK ?
OK. Adding to my fixes queue.
>
> Regards,
> Abhilash
> >
> > --
> > Best regards,
> >
> > Lukasz Majewski
> >
> > Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2014-12-10 14:41 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-02 6:34 [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung Abhilash Kesavan
2014-12-02 6:34 ` [PATCH 2/2] ARM: EXYNOS: Remove ARCH_HAS_BANDGAP selection Abhilash Kesavan
2014-12-02 14:23 ` Bartlomiej Zolnierkiewicz
2014-12-08 9:44 ` Lukasz Majewski
2014-12-02 14:17 ` [PATCH 1/2] drivers: thermal: Remove ARCH_HAS_BANDGAP dependency for samsung Bartlomiej Zolnierkiewicz
2014-12-08 9:43 ` Lukasz Majewski
2014-12-10 3:56 ` Abhilash Kesavan
2014-12-10 14:41 ` Eduardo Valentin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).