[PATCH] PM / devfreq: Kconfig: Drop explicit selection of PM_OPP

[PATCH] PM / devfreq: Kconfig: Drop explicit selection of PM_OPP

[Leonard Crestez]

CONFIG_PM_OPP is already selected by CONFIG_PM_DEVFREQ since
commit b9c69e043266 ("PM / devfreq: Add dependency on PM_OPP")

This means that individual drivers shouldn't "select PM_OPP" explicitly.

Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>

---
Spawned by review comments on a new driver:
https://patchwork.kernel.org/patch/11235695/#22992159

This patch shouldn't have any dependencies.

 drivers/devfreq/Kconfig | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
index defe1d438710..066e6c4efaa2 100644
--- a/drivers/devfreq/Kconfig
+++ b/drivers/devfreq/Kconfig
@@ -81,11 +81,10 @@ config ARM_EXYNOS_BUS_DEVFREQ
 	depends on ARCH_EXYNOS || COMPILE_TEST
 	select DEVFREQ_GOV_SIMPLE_ONDEMAND
 	select DEVFREQ_GOV_PASSIVE
 	select DEVFREQ_EVENT_EXYNOS_PPMU
 	select PM_DEVFREQ_EVENT
-	select PM_OPP
 	help
 	  This adds the common DEVFREQ driver for Exynos Memory bus. Exynos
 	  Memory bus has one more group of memory bus (e.g, MIF and INT block).
 	  Each memory bus group could contain many memoby bus block. It reads
 	  PPMU counters of memory controllers by using DEVFREQ-event device
@@ -96,22 +95,20 @@ config ARM_TEGRA_DEVFREQ
 	tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
 	depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
 		ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
 		ARCH_TEGRA_210_SOC || \
 		COMPILE_TEST
-	select PM_OPP
 	help
 	  This adds the DEVFREQ driver for the Tegra family of SoCs.
 	  It reads ACTMON counters of memory controllers and adjusts the
 	  operating frequencies and voltages with OPP support.
 
 config ARM_TEGRA20_DEVFREQ
 	tristate "NVIDIA Tegra20 DEVFREQ Driver"
 	depends on (TEGRA_MC && TEGRA20_EMC) || COMPILE_TEST
 	depends on COMMON_CLK
 	select DEVFREQ_GOV_SIMPLE_ONDEMAND
-	select PM_OPP
 	help
 	  This adds the DEVFREQ driver for the Tegra20 family of SoCs.
 	  It reads Memory Controller counters and adjusts the operating
 	  frequencies and voltages with OPP support.
 
@@ -119,11 +116,10 @@ config ARM_RK3399_DMC_DEVFREQ
 	tristate "ARM RK3399 DMC DEVFREQ Driver"
 	depends on ARCH_ROCKCHIP
 	select DEVFREQ_EVENT_ROCKCHIP_DFI
 	select DEVFREQ_GOV_SIMPLE_ONDEMAND
 	select PM_DEVFREQ_EVENT
-	select PM_OPP
 	help
           This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory Controller).
           It sets the frequency for the memory controller and reads the usage counts
           from hardware.
 
-- 
2.17.1

Re: [PATCH] PM / devfreq: Kconfig: Drop explicit selection of PM_OPP

[Chanwoo Choi]

On 11/12/19 3:16 AM, Leonard Crestez wrote:
> CONFIG_PM_OPP is already selected by CONFIG_PM_DEVFREQ since
> commit b9c69e043266 ("PM / devfreq: Add dependency on PM_OPP")
> This means that individual drivers shouldn't "select PM_OPP" explicitly.
> 
> Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
> 
> ---
> Spawned by review comments on a new driver:
> https://patchwork.kernel.org/patch/11235695/#22992159
> 
> This patch shouldn't have any dependencies.
> 
>  drivers/devfreq/Kconfig | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index defe1d438710..066e6c4efaa2 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -81,11 +81,10 @@ config ARM_EXYNOS_BUS_DEVFREQ
>  	depends on ARCH_EXYNOS || COMPILE_TEST
>  	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	select DEVFREQ_GOV_PASSIVE
>  	select DEVFREQ_EVENT_EXYNOS_PPMU
>  	select PM_DEVFREQ_EVENT
> -	select PM_OPP
>  	help
>  	  This adds the common DEVFREQ driver for Exynos Memory bus. Exynos
>  	  Memory bus has one more group of memory bus (e.g, MIF and INT block).
>  	  Each memory bus group could contain many memoby bus block. It reads
>  	  PPMU counters of memory controllers by using DEVFREQ-event device
> @@ -96,22 +95,20 @@ config ARM_TEGRA_DEVFREQ
>  	tristate "NVIDIA Tegra30/114/124/210 DEVFREQ Driver"
>  	depends on ARCH_TEGRA_3x_SOC || ARCH_TEGRA_114_SOC || \
>  		ARCH_TEGRA_132_SOC || ARCH_TEGRA_124_SOC || \
>  		ARCH_TEGRA_210_SOC || \
>  		COMPILE_TEST
> -	select PM_OPP
>  	help
>  	  This adds the DEVFREQ driver for the Tegra family of SoCs.
>  	  It reads ACTMON counters of memory controllers and adjusts the
>  	  operating frequencies and voltages with OPP support.
>  
>  config ARM_TEGRA20_DEVFREQ
>  	tristate "NVIDIA Tegra20 DEVFREQ Driver"
>  	depends on (TEGRA_MC && TEGRA20_EMC) || COMPILE_TEST
>  	depends on COMMON_CLK
>  	select DEVFREQ_GOV_SIMPLE_ONDEMAND
> -	select PM_OPP
>  	help
>  	  This adds the DEVFREQ driver for the Tegra20 family of SoCs.
>  	  It reads Memory Controller counters and adjusts the operating
>  	  frequencies and voltages with OPP support.
>  
> @@ -119,11 +116,10 @@ config ARM_RK3399_DMC_DEVFREQ
>  	tristate "ARM RK3399 DMC DEVFREQ Driver"
>  	depends on ARCH_ROCKCHIP
>  	select DEVFREQ_EVENT_ROCKCHIP_DFI
>  	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	select PM_DEVFREQ_EVENT
> -	select PM_OPP
>  	help
>            This adds the DEVFREQ driver for the RK3399 DMC(Dynamic Memory Controller).
>            It sets the frequency for the memory controller and reads the usage counts
>            from hardware.
>  
> 

Applied it. Thanks.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics