Re: [PATCH V15 RESEND 5/5] arm64: dts: imx: add i.MX8QXP thermal support

From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Anson Huang <anson.huang@nxp.com>
Cc: "robh+dt@kernel.org" <robh+dt@kernel.org>,
	"mark.rutland@arm.com" <mark.rutland@arm.com>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>,
	"s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
	"kernel@pengutronix.de" <kernel@pengutronix.de>,
	"festevam@gmail.com" <festevam@gmail.com>,
	"catalin.marinas@arm.com" <catalin.marinas@arm.com>,
	"will@kernel.org" <will@kernel.org>,
	"rui.zhang@intel.com" <rui.zhang@intel.com>,
	"amit.kucheria@verdurent.com" <amit.kucheria@verdurent.com>,
	Aisheng Dong <aisheng.dong@nxp.com>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
	"krzk@kernel.org" <krzk@kernel.org>,
	Andy Duan <fugang.duan@nxp.com>, Peng Fan <peng.fan@nxp.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	"olof@lixom.net" <olof@lixom.net>,
	"dinguyen@kernel.org" <dinguyen@kernel.org>,
	Leonard Crestez <leonard.crestez@nxp.com>,
	"marcin.juszkiewicz@linaro.org" <marcin.juszkiewicz@linaro.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
	dl-linux-imx <linux-imx@nxp.com>
Subject: Re: [PATCH V15 RESEND 5/5] arm64: dts: imx: add i.MX8QXP thermal support
Date: Sat, 22 Feb 2020 08:51:57 +0100	[thread overview]
Message-ID: <59784965-dba6-5878-68fa-5657f3e5f02e@linaro.org> (raw)
In-Reply-To: <DB3PR0402MB39163B3EC2B6077C51D821DEF5120@DB3PR0402MB3916.eurprd04.prod.outlook.com>

On 22/02/2020 00:53, Anson Huang wrote:
> Hi, Daniel
> 

[ ... ]

>>> +
>>> +	thermal_zones: thermal-zones {
>>> +		cpu-thermal0 {
>>> +			polling-delay-passive = <250>;
>>> +			polling-delay = <2000>;
>>> +			thermal-sensors = <&tsens IMX_SC_R_SYSTEM>;
>>> +			trips {
>>> +				cpu_alert0: trip0 {
>>> +					temperature = <107000>;
>>> +					hysteresis = <2000>;
>>> +					type = "passive";
>>> +				};
>>
>> May be you can add a 'hot' trip point before 'critical' for future use before
>> reaching the emergency shutdown.
> 
> The 'passive' trip is actually the 'hot' trip point you mentioned, and I have combined it to
> below cooling map which will throttle cpu-freq when passive (hot) point is reached.
> We all use 'passive' as 'hot' alarm and trigger cpu-freq throttle on i.MX platforms. 

Sorry, I'm not sure to get the point. A 'hot' trip point is not a
'passive' trip point. The 'hot' trip point is a critical temperature and
a notification is raised [1][2].

It is the last chance for the system to do something before the next
trip point 'critical' is reached and where an emergency shutdown is done.

The 'passive' trip point is the target temperature for mitigation in a
normal situation when the system is loaded.

[1]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/thermal/thermal_core.c#n288
[2]
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/thermal/thermal_core.c#n420

-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog