linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] PM / devfreq: Reduce log severity for informative message
@ 2021-12-14  6:31 ` Tzung-Bi Shih
  2021-12-16  2:29   ` Chanwoo Choi
  0 siblings, 1 reply; 2+ messages in thread
From: Tzung-Bi Shih @ 2021-12-14  6:31 UTC (permalink / raw)
  To: myungjoo.ham, kyungmin.park, cw00.choi; +Cc: linux-pm, tzungbi

Suppose devfreq_update_status() failure in devfreq_set_target() is not a
critical error, reduces the log severity.

Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
---
 drivers/devfreq/devfreq.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 7906220d025c..a525a609dfc6 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -382,8 +382,8 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq,
 	devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
 
 	if (devfreq_update_status(devfreq, new_freq))
-		dev_err(&devfreq->dev,
-			"Couldn't update frequency transition information.\n");
+		dev_warn(&devfreq->dev,
+			 "Couldn't update frequency transition information.\n");
 
 	devfreq->previous_freq = new_freq;
 
-- 
2.34.1.173.g76aa8bc2d0-goog


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] PM / devfreq: Reduce log severity for informative message
  2021-12-14  6:31 ` [PATCH] PM / devfreq: Reduce log severity for informative message Tzung-Bi Shih
@ 2021-12-16  2:29   ` Chanwoo Choi
  0 siblings, 0 replies; 2+ messages in thread
From: Chanwoo Choi @ 2021-12-16  2:29 UTC (permalink / raw)
  To: Tzung-Bi Shih, myungjoo.ham, kyungmin.park; +Cc: linux-pm

On 12/14/21 3:31 PM, Tzung-Bi Shih wrote:
> Suppose devfreq_update_status() failure in devfreq_set_target() is not a
> critical error, reduces the log severity.
> 
> Signed-off-by: Tzung-Bi Shih <tzungbi@google.com>
> ---
>  drivers/devfreq/devfreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index 7906220d025c..a525a609dfc6 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -382,8 +382,8 @@ static int devfreq_set_target(struct devfreq *devfreq, unsigned long new_freq,
>  	devfreq_notify_transition(devfreq, &freqs, DEVFREQ_POSTCHANGE);
>  
>  	if (devfreq_update_status(devfreq, new_freq))
> -		dev_err(&devfreq->dev,
> -			"Couldn't update frequency transition information.\n");
> +		dev_warn(&devfreq->dev,
> +			 "Couldn't update frequency transition information.\n");
>  
>  	devfreq->previous_freq = new_freq;
>  
> 

Applied it.

-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-12-16  2:07 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <CGME20211214063114epcas1p38cfb009bda86839613bc5bc7ddc4bc2e@epcas1p3.samsung.com>
2021-12-14  6:31 ` [PATCH] PM / devfreq: Reduce log severity for informative message Tzung-Bi Shih
2021-12-16  2:29   ` Chanwoo Choi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).