* [PATCH v2 0/2] Add thermal cooling support to NVIDIA Tegra devfreq
@ 2021-06-01 2:23 Dmitry Osipenko
2021-06-01 2:23 ` [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema Dmitry Osipenko
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Dmitry Osipenko @ 2021-06-01 2:23 UTC (permalink / raw)
To: Thierry Reding, Jonathan Hunter, MyungJoo Ham, Kyungmin Park,
Chanwoo Choi, Peter Geis, Matt Merhar
Cc: linux-tegra, linux-pm, Rob Herring, linux-kernel, devicetree
This series adds two remaining patches of the ACTMON cooling support
series, converting the DT binding to schema and adding cooling properties.
The rest of the patches are already applied.
Changelog:
v2: - Added back the "MEMORY CONTROLLER" section to the description of the
interconnect-names property, which was suggested by Thierry Reding.
- Added r-b from Rob Herring and acks from Chanwoo Choi and
Thierry Reding.
Dmitry Osipenko (2):
dt-bindings: devfreq: tegra30-actmon: Convert to schema
dt-bindings: devfreq: tegra30-actmon: Add cooling-cells
.../arm/tegra/nvidia,tegra30-actmon.txt | 57 --------
.../devfreq/nvidia,tegra30-actmon.yaml | 126 ++++++++++++++++++
2 files changed, 126 insertions(+), 57 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt
create mode 100644 Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml
--
2.30.2
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema 2021-06-01 2:23 [PATCH v2 0/2] Add thermal cooling support to NVIDIA Tegra devfreq Dmitry Osipenko @ 2021-06-01 2:23 ` Dmitry Osipenko 2021-06-01 2:55 ` Chanwoo Choi 2021-06-01 11:28 ` Thierry Reding 2021-06-01 2:23 ` [PATCH v2 2/2] dt-bindings: devfreq: tegra30-actmon: Add cooling-cells Dmitry Osipenko 2021-06-01 15:35 ` [PATCH v2 0/2] Add thermal cooling support to NVIDIA Tegra devfreq Chanwoo Choi 2 siblings, 2 replies; 8+ messages in thread From: Dmitry Osipenko @ 2021-06-01 2:23 UTC (permalink / raw) To: Thierry Reding, Jonathan Hunter, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Peter Geis, Matt Merhar Cc: linux-tegra, linux-pm, Rob Herring, linux-kernel, devicetree Convert NVIDIA Tegra ACTMON binding to schema. Reviewed-by: Rob Herring <robh@kernel.org> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- .../arm/tegra/nvidia,tegra30-actmon.txt | 57 --------- .../devfreq/nvidia,tegra30-actmon.yaml | 121 ++++++++++++++++++ 2 files changed, 121 insertions(+), 57 deletions(-) delete mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt create mode 100644 Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt deleted file mode 100644 index 897eedfa2bc8..000000000000 --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt +++ /dev/null @@ -1,57 +0,0 @@ -NVIDIA Tegra Activity Monitor - -The activity monitor block collects statistics about the behaviour of other -components in the system. This information can be used to derive the rate at -which the external memory needs to be clocked in order to serve all requests -from the monitored clients. - -Required properties: -- compatible: should be "nvidia,tegra<chip>-actmon" -- reg: offset and length of the register set for the device -- interrupts: standard interrupt property -- clocks: Must contain a phandle and clock specifier pair for each entry in -clock-names. See ../../clock/clock-bindings.txt for details. -- clock-names: Must include the following entries: - - actmon - - emc -- resets: Must contain an entry for each entry in reset-names. See -../../reset/reset.txt for details. -- reset-names: Must include the following entries: - - actmon -- operating-points-v2: See ../bindings/opp/opp.txt for details. -- interconnects: Should contain entries for memory clients sitting on - MC->EMC memory interconnect path. -- interconnect-names: Should include name of the interconnect path for each - interconnect entry. Consult TRM documentation for - information about available memory clients, see MEMORY - CONTROLLER section. - -For each opp entry in 'operating-points-v2' table: -- opp-supported-hw: bitfield indicating SoC speedo ID mask -- opp-peak-kBps: peak bandwidth of the memory channel - -Example: - dfs_opp_table: opp-table { - compatible = "operating-points-v2"; - - opp@12750000 { - opp-hz = /bits/ 64 <12750000>; - opp-supported-hw = <0x000F>; - opp-peak-kBps = <51000>; - }; - ... - }; - - actmon@6000c800 { - compatible = "nvidia,tegra124-actmon"; - reg = <0x0 0x6000c800 0x0 0x400>; - interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&tegra_car TEGRA124_CLK_ACTMON>, - <&tegra_car TEGRA124_CLK_EMC>; - clock-names = "actmon", "emc"; - resets = <&tegra_car 119>; - reset-names = "actmon"; - operating-points-v2 = <&dfs_opp_table>; - interconnects = <&mc TEGRA124_MC_MPCORER &emc>; - interconnect-names = "cpu"; - }; diff --git a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml new file mode 100644 index 000000000000..ba938eed28ee --- /dev/null +++ b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml @@ -0,0 +1,121 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/devfreq/nvidia,tegra30-actmon.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NVIDIA Tegra30 Activity Monitor + +maintainers: + - Dmitry Osipenko <digetx@gmail.com> + - Jon Hunter <jonathanh@nvidia.com> + - Thierry Reding <thierry.reding@gmail.com> + +description: | + The activity monitor block collects statistics about the behaviour of other + components in the system. This information can be used to derive the rate at + which the external memory needs to be clocked in order to serve all requests + from the monitored clients. + +properties: + compatible: + enum: + - nvidia,tegra30-actmon + - nvidia,tegra114-actmon + - nvidia,tegra124-actmon + - nvidia,tegra210-actmon + + reg: + maxItems: 1 + + clocks: + maxItems: 2 + + clock-names: + items: + - const: actmon + - const: emc + + resets: + maxItems: 1 + + reset-names: + items: + - const: actmon + + interrupts: + maxItems: 1 + + interconnects: + minItems: 1 + maxItems: 12 + + interconnect-names: + minItems: 1 + maxItems: 12 + description: + Should include name of the interconnect path for each interconnect + entry. Consult TRM documentation for information about available + memory clients, see MEMORY CONTROLLER and ACTIVITY MONITOR sections. + + operating-points-v2: + description: + Should contain freqs and voltages and opp-supported-hw property, which + is a bitfield indicating SoC speedo ID mask. + +required: + - compatible + - reg + - clocks + - clock-names + - resets + - reset-names + - interrupts + - interconnects + - interconnect-names + - operating-points-v2 + +additionalProperties: false + +examples: + - | + #include <dt-bindings/memory/tegra30-mc.h> + + mc: memory-controller@7000f000 { + compatible = "nvidia,tegra30-mc"; + reg = <0x7000f000 0x400>; + clocks = <&clk 32>; + clock-names = "mc"; + + interrupts = <0 77 4>; + + #iommu-cells = <1>; + #reset-cells = <1>; + #interconnect-cells = <1>; + }; + + emc: external-memory-controller@7000f400 { + compatible = "nvidia,tegra30-emc"; + reg = <0x7000f400 0x400>; + interrupts = <0 78 4>; + clocks = <&clk 57>; + + nvidia,memory-controller = <&mc>; + operating-points-v2 = <&dvfs_opp_table>; + power-domains = <&domain>; + + #interconnect-cells = <0>; + }; + + actmon@6000c800 { + compatible = "nvidia,tegra30-actmon"; + reg = <0x6000c800 0x400>; + interrupts = <0 45 4>; + clocks = <&clk 119>, <&clk 57>; + clock-names = "actmon", "emc"; + resets = <&rst 119>; + reset-names = "actmon"; + operating-points-v2 = <&dvfs_opp_table>; + interconnects = <&mc TEGRA30_MC_MPCORER &emc>; + interconnect-names = "cpu-read"; + }; -- 2.30.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema 2021-06-01 2:23 ` [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema Dmitry Osipenko @ 2021-06-01 2:55 ` Chanwoo Choi 2021-06-01 2:57 ` Dmitry Osipenko 2021-06-01 11:28 ` Thierry Reding 1 sibling, 1 reply; 8+ messages in thread From: Chanwoo Choi @ 2021-06-01 2:55 UTC (permalink / raw) To: Dmitry Osipenko, Thierry Reding, Jonathan Hunter, MyungJoo Ham, Kyungmin Park, Peter Geis, Matt Merhar Cc: linux-tegra, linux-pm, Rob Herring, linux-kernel, devicetree On 6/1/21 11:23 AM, Dmitry Osipenko wrote: > Convert NVIDIA Tegra ACTMON binding to schema. > > Reviewed-by: Rob Herring <robh@kernel.org> > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../arm/tegra/nvidia,tegra30-actmon.txt | 57 --------- > .../devfreq/nvidia,tegra30-actmon.yaml | 121 ++++++++++++++++++ > 2 files changed, 121 insertions(+), 57 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt > create mode 100644 Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml > > diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt > deleted file mode 100644 > index 897eedfa2bc8..000000000000 > --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt > +++ /dev/null > @@ -1,57 +0,0 @@ > -NVIDIA Tegra Activity Monitor > - > -The activity monitor block collects statistics about the behaviour of other > -components in the system. This information can be used to derive the rate at > -which the external memory needs to be clocked in order to serve all requests > -from the monitored clients. > - > -Required properties: > -- compatible: should be "nvidia,tegra<chip>-actmon" > -- reg: offset and length of the register set for the device > -- interrupts: standard interrupt property > -- clocks: Must contain a phandle and clock specifier pair for each entry in > -clock-names. See ../../clock/clock-bindings.txt for details. > -- clock-names: Must include the following entries: > - - actmon > - - emc > -- resets: Must contain an entry for each entry in reset-names. See > -../../reset/reset.txt for details. > -- reset-names: Must include the following entries: > - - actmon > -- operating-points-v2: See ../bindings/opp/opp.txt for details. > -- interconnects: Should contain entries for memory clients sitting on > - MC->EMC memory interconnect path. > -- interconnect-names: Should include name of the interconnect path for each > - interconnect entry. Consult TRM documentation for > - information about available memory clients, see MEMORY > - CONTROLLER section. > - > -For each opp entry in 'operating-points-v2' table: > -- opp-supported-hw: bitfield indicating SoC speedo ID mask > -- opp-peak-kBps: peak bandwidth of the memory channel > - > -Example: > - dfs_opp_table: opp-table { > - compatible = "operating-points-v2"; > - > - opp@12750000 { > - opp-hz = /bits/ 64 <12750000>; > - opp-supported-hw = <0x000F>; > - opp-peak-kBps = <51000>; > - }; > - ... > - }; > - > - actmon@6000c800 { > - compatible = "nvidia,tegra124-actmon"; > - reg = <0x0 0x6000c800 0x0 0x400>; > - interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&tegra_car TEGRA124_CLK_ACTMON>, > - <&tegra_car TEGRA124_CLK_EMC>; > - clock-names = "actmon", "emc"; > - resets = <&tegra_car 119>; > - reset-names = "actmon"; > - operating-points-v2 = <&dfs_opp_table>; > - interconnects = <&mc TEGRA124_MC_MPCORER &emc>; > - interconnect-names = "cpu"; > - }; > diff --git a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml > new file mode 100644 > index 000000000000..ba938eed28ee > --- /dev/null > +++ b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml > @@ -0,0 +1,121 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: https://protect2.fireeye.com/v1/url?k=c852e9c6-97c9d0fb-c8536289-0cc47a31309a-748d620b8cc48f8b&q=1&e=c1b6a671-e53d-468c-81f5-3e23bd2e67d9&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdevfreq%2Fnvidia%2Ctegra30-actmon.yaml%23 > +$schema: https://protect2.fireeye.com/v1/url?k=1abc12fa-45272bc7-1abd99b5-0cc47a31309a-ca738d567d90525e&q=1&e=c1b6a671-e53d-468c-81f5-3e23bd2e67d9&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 > + > +title: NVIDIA Tegra30 Activity Monitor > + > +maintainers: > + - Dmitry Osipenko <digetx@gmail.com> > + - Jon Hunter <jonathanh@nvidia.com> > + - Thierry Reding <thierry.reding@gmail.com> > + > +description: | > + The activity monitor block collects statistics about the behaviour of other > + components in the system. This information can be used to derive the rate at > + which the external memory needs to be clocked in order to serve all requests > + from the monitored clients. > + > +properties: > + compatible: > + enum: > + - nvidia,tegra30-actmon > + - nvidia,tegra114-actmon > + - nvidia,tegra124-actmon > + - nvidia,tegra210-actmon > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 2 > + > + clock-names: > + items: > + - const: actmon > + - const: emc > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: actmon > + > + interrupts: > + maxItems: 1 > + > + interconnects: > + minItems: 1 > + maxItems: 12 > + > + interconnect-names: > + minItems: 1 > + maxItems: 12 > + description: > + Should include name of the interconnect path for each interconnect > + entry. Consult TRM documentation for information about available > + memory clients, see MEMORY CONTROLLER and ACTIVITY MONITOR sections. > + > + operating-points-v2: > + description: > + Should contain freqs and voltages and opp-supported-hw property, which > + is a bitfield indicating SoC speedo ID mask. > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - resets > + - reset-names > + - interrupts > + - interconnects > + - interconnect-names > + - operating-points-v2 > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/memory/tegra30-mc.h> > + > + mc: memory-controller@7000f000 { > + compatible = "nvidia,tegra30-mc"; > + reg = <0x7000f000 0x400>; > + clocks = <&clk 32>; > + clock-names = "mc"; > + > + interrupts = <0 77 4>; > + > + #iommu-cells = <1>; > + #reset-cells = <1>; > + #interconnect-cells = <1>; > + }; > + > + emc: external-memory-controller@7000f400 { > + compatible = "nvidia,tegra30-emc"; > + reg = <0x7000f400 0x400>; > + interrupts = <0 78 4>; > + clocks = <&clk 57>; > + > + nvidia,memory-controller = <&mc>; > + operating-points-v2 = <&dvfs_opp_table>; > + power-domains = <&domain>; > + > + #interconnect-cells = <0>; > + }; > + > + actmon@6000c800 { > + compatible = "nvidia,tegra30-actmon"; > + reg = <0x6000c800 0x400>; > + interrupts = <0 45 4>; > + clocks = <&clk 119>, <&clk 57>; > + clock-names = "actmon", "emc"; > + resets = <&rst 119>; > + reset-names = "actmon"; > + operating-points-v2 = <&dvfs_opp_table>; > + interconnects = <&mc TEGRA30_MC_MPCORER &emc>; > + interconnect-names = "cpu-read"; > + }; > If tegra maintainer confirms this patch, I'll take it. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema 2021-06-01 2:55 ` Chanwoo Choi @ 2021-06-01 2:57 ` Dmitry Osipenko 0 siblings, 0 replies; 8+ messages in thread From: Dmitry Osipenko @ 2021-06-01 2:57 UTC (permalink / raw) To: Chanwoo Choi, Thierry Reding, Jonathan Hunter, MyungJoo Ham, Kyungmin Park, Peter Geis, Matt Merhar Cc: linux-tegra, linux-pm, Rob Herring, linux-kernel, devicetree 01.06.2021 05:55, Chanwoo Choi пишет: > On 6/1/21 11:23 AM, Dmitry Osipenko wrote: >> Convert NVIDIA Tegra ACTMON binding to schema. >> >> Reviewed-by: Rob Herring <robh@kernel.org> >> Acked-by: Chanwoo Choi <cw00.choi@samsung.com> >> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> >> --- >> .../arm/tegra/nvidia,tegra30-actmon.txt | 57 --------- >> .../devfreq/nvidia,tegra30-actmon.yaml | 121 ++++++++++++++++++ >> 2 files changed, 121 insertions(+), 57 deletions(-) >> delete mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt >> create mode 100644 Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml >> >> diff --git a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt b/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt >> deleted file mode 100644 >> index 897eedfa2bc8..000000000000 >> --- a/Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt >> +++ /dev/null >> @@ -1,57 +0,0 @@ >> -NVIDIA Tegra Activity Monitor >> - >> -The activity monitor block collects statistics about the behaviour of other >> -components in the system. This information can be used to derive the rate at >> -which the external memory needs to be clocked in order to serve all requests >> -from the monitored clients. >> - >> -Required properties: >> -- compatible: should be "nvidia,tegra<chip>-actmon" >> -- reg: offset and length of the register set for the device >> -- interrupts: standard interrupt property >> -- clocks: Must contain a phandle and clock specifier pair for each entry in >> -clock-names. See ../../clock/clock-bindings.txt for details. >> -- clock-names: Must include the following entries: >> - - actmon >> - - emc >> -- resets: Must contain an entry for each entry in reset-names. See >> -../../reset/reset.txt for details. >> -- reset-names: Must include the following entries: >> - - actmon >> -- operating-points-v2: See ../bindings/opp/opp.txt for details. >> -- interconnects: Should contain entries for memory clients sitting on >> - MC->EMC memory interconnect path. >> -- interconnect-names: Should include name of the interconnect path for each >> - interconnect entry. Consult TRM documentation for >> - information about available memory clients, see MEMORY >> - CONTROLLER section. >> - >> -For each opp entry in 'operating-points-v2' table: >> -- opp-supported-hw: bitfield indicating SoC speedo ID mask >> -- opp-peak-kBps: peak bandwidth of the memory channel >> - >> -Example: >> - dfs_opp_table: opp-table { >> - compatible = "operating-points-v2"; >> - >> - opp@12750000 { >> - opp-hz = /bits/ 64 <12750000>; >> - opp-supported-hw = <0x000F>; >> - opp-peak-kBps = <51000>; >> - }; >> - ... >> - }; >> - >> - actmon@6000c800 { >> - compatible = "nvidia,tegra124-actmon"; >> - reg = <0x0 0x6000c800 0x0 0x400>; >> - interrupts = <GIC_SPI 45 IRQ_TYPE_LEVEL_HIGH>; >> - clocks = <&tegra_car TEGRA124_CLK_ACTMON>, >> - <&tegra_car TEGRA124_CLK_EMC>; >> - clock-names = "actmon", "emc"; >> - resets = <&tegra_car 119>; >> - reset-names = "actmon"; >> - operating-points-v2 = <&dfs_opp_table>; >> - interconnects = <&mc TEGRA124_MC_MPCORER &emc>; >> - interconnect-names = "cpu"; >> - }; >> diff --git a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml >> new file mode 100644 >> index 000000000000..ba938eed28ee >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml >> @@ -0,0 +1,121 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: https://protect2.fireeye.com/v1/url?k=c852e9c6-97c9d0fb-c8536289-0cc47a31309a-748d620b8cc48f8b&q=1&e=c1b6a671-e53d-468c-81f5-3e23bd2e67d9&u=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdevfreq%2Fnvidia%2Ctegra30-actmon.yaml%23 >> +$schema: https://protect2.fireeye.com/v1/url?k=1abc12fa-45272bc7-1abd99b5-0cc47a31309a-ca738d567d90525e&q=1&e=c1b6a671-e53d-468c-81f5-3e23bd2e67d9&u=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23 >> + >> +title: NVIDIA Tegra30 Activity Monitor >> + >> +maintainers: >> + - Dmitry Osipenko <digetx@gmail.com> >> + - Jon Hunter <jonathanh@nvidia.com> >> + - Thierry Reding <thierry.reding@gmail.com> >> + >> +description: | >> + The activity monitor block collects statistics about the behaviour of other >> + components in the system. This information can be used to derive the rate at >> + which the external memory needs to be clocked in order to serve all requests >> + from the monitored clients. >> + >> +properties: >> + compatible: >> + enum: >> + - nvidia,tegra30-actmon >> + - nvidia,tegra114-actmon >> + - nvidia,tegra124-actmon >> + - nvidia,tegra210-actmon >> + >> + reg: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 2 >> + >> + clock-names: >> + items: >> + - const: actmon >> + - const: emc >> + >> + resets: >> + maxItems: 1 >> + >> + reset-names: >> + items: >> + - const: actmon >> + >> + interrupts: >> + maxItems: 1 >> + >> + interconnects: >> + minItems: 1 >> + maxItems: 12 >> + >> + interconnect-names: >> + minItems: 1 >> + maxItems: 12 >> + description: >> + Should include name of the interconnect path for each interconnect >> + entry. Consult TRM documentation for information about available >> + memory clients, see MEMORY CONTROLLER and ACTIVITY MONITOR sections. >> + >> + operating-points-v2: >> + description: >> + Should contain freqs and voltages and opp-supported-hw property, which >> + is a bitfield indicating SoC speedo ID mask. >> + >> +required: >> + - compatible >> + - reg >> + - clocks >> + - clock-names >> + - resets >> + - reset-names >> + - interrupts >> + - interconnects >> + - interconnect-names >> + - operating-points-v2 >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include <dt-bindings/memory/tegra30-mc.h> >> + >> + mc: memory-controller@7000f000 { >> + compatible = "nvidia,tegra30-mc"; >> + reg = <0x7000f000 0x400>; >> + clocks = <&clk 32>; >> + clock-names = "mc"; >> + >> + interrupts = <0 77 4>; >> + >> + #iommu-cells = <1>; >> + #reset-cells = <1>; >> + #interconnect-cells = <1>; >> + }; >> + >> + emc: external-memory-controller@7000f400 { >> + compatible = "nvidia,tegra30-emc"; >> + reg = <0x7000f400 0x400>; >> + interrupts = <0 78 4>; >> + clocks = <&clk 57>; >> + >> + nvidia,memory-controller = <&mc>; >> + operating-points-v2 = <&dvfs_opp_table>; >> + power-domains = <&domain>; >> + >> + #interconnect-cells = <0>; >> + }; >> + >> + actmon@6000c800 { >> + compatible = "nvidia,tegra30-actmon"; >> + reg = <0x6000c800 0x400>; >> + interrupts = <0 45 4>; >> + clocks = <&clk 119>, <&clk 57>; >> + clock-names = "actmon", "emc"; >> + resets = <&rst 119>; >> + reset-names = "actmon"; >> + operating-points-v2 = <&dvfs_opp_table>; >> + interconnects = <&mc TEGRA30_MC_MPCORER &emc>; >> + interconnect-names = "cpu-read"; >> + }; >> > > If tegra maintainer confirms this patch, I'll take it. Okay, thank you. ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema 2021-06-01 2:23 ` [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema Dmitry Osipenko 2021-06-01 2:55 ` Chanwoo Choi @ 2021-06-01 11:28 ` Thierry Reding 1 sibling, 0 replies; 8+ messages in thread From: Thierry Reding @ 2021-06-01 11:28 UTC (permalink / raw) To: Dmitry Osipenko Cc: Jonathan Hunter, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Peter Geis, Matt Merhar, linux-tegra, linux-pm, Rob Herring, linux-kernel, devicetree [-- Attachment #1: Type: text/plain, Size: 707 bytes --] On Tue, Jun 01, 2021 at 05:23:18AM +0300, Dmitry Osipenko wrote: > Convert NVIDIA Tegra ACTMON binding to schema. > > Reviewed-by: Rob Herring <robh@kernel.org> > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- > .../arm/tegra/nvidia,tegra30-actmon.txt | 57 --------- > .../devfreq/nvidia,tegra30-actmon.yaml | 121 ++++++++++++++++++ > 2 files changed, 121 insertions(+), 57 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt > create mode 100644 Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml Acked-by: Thierry Reding <treding@nvidia.com> [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 833 bytes --] ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v2 2/2] dt-bindings: devfreq: tegra30-actmon: Add cooling-cells 2021-06-01 2:23 [PATCH v2 0/2] Add thermal cooling support to NVIDIA Tegra devfreq Dmitry Osipenko 2021-06-01 2:23 ` [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema Dmitry Osipenko @ 2021-06-01 2:23 ` Dmitry Osipenko 2021-06-01 4:32 ` Dmitry Osipenko 2021-06-01 15:35 ` [PATCH v2 0/2] Add thermal cooling support to NVIDIA Tegra devfreq Chanwoo Choi 2 siblings, 1 reply; 8+ messages in thread From: Dmitry Osipenko @ 2021-06-01 2:23 UTC (permalink / raw) To: Thierry Reding, Jonathan Hunter, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Peter Geis, Matt Merhar Cc: linux-tegra, linux-pm, Rob Herring, linux-kernel, devicetree The ACTMON watches activity of memory clients. Decisions about a minimum required frequency are made based on the info from ACTMON. We can use ACTMON as a thermal cooling device by limiting the required frequency. Document new cooling-cells property of NVIDIA Tegra ACTMON hardware unit. Acked-by: Chanwoo Choi <cw00.choi@samsung.com> Acked-by: Thierry Reding <treding@nvidia.com> Signed-off-by: Dmitry Osipenko <digetx@gmail.com> --- .../devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml index ba938eed28ee..e3379d106728 100644 --- a/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml +++ b/Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml @@ -63,6 +63,9 @@ properties: Should contain freqs and voltages and opp-supported-hw property, which is a bitfield indicating SoC speedo ID mask. + "#cooling-cells": + const: 2 + required: - compatible - reg @@ -74,6 +77,7 @@ required: - interconnects - interconnect-names - operating-points-v2 + - "#cooling-cells" additionalProperties: false @@ -118,4 +122,5 @@ examples: operating-points-v2 = <&dvfs_opp_table>; interconnects = <&mc TEGRA30_MC_MPCORER &emc>; interconnect-names = "cpu-read"; + #cooling-cells = <2>; }; -- 2.30.2 ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v2 2/2] dt-bindings: devfreq: tegra30-actmon: Add cooling-cells 2021-06-01 2:23 ` [PATCH v2 2/2] dt-bindings: devfreq: tegra30-actmon: Add cooling-cells Dmitry Osipenko @ 2021-06-01 4:32 ` Dmitry Osipenko 0 siblings, 0 replies; 8+ messages in thread From: Dmitry Osipenko @ 2021-06-01 4:32 UTC (permalink / raw) To: Thierry Reding, Jonathan Hunter, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Peter Geis, Matt Merhar Cc: linux-tegra, linux-pm, Rob Herring, linux-kernel, devicetree 01.06.2021 05:23, Dmitry Osipenko пишет: > The ACTMON watches activity of memory clients. Decisions about a minimum > required frequency are made based on the info from ACTMON. We can use > ACTMON as a thermal cooling device by limiting the required frequency. > Document new cooling-cells property of NVIDIA Tegra ACTMON hardware unit. > > Acked-by: Chanwoo Choi <cw00.choi@samsung.com> > Acked-by: Thierry Reding <treding@nvidia.com> > Signed-off-by: Dmitry Osipenko <digetx@gmail.com> > --- I missed to add Rob's r-b to this patch that he gave to v1: Reviewed-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v2 0/2] Add thermal cooling support to NVIDIA Tegra devfreq 2021-06-01 2:23 [PATCH v2 0/2] Add thermal cooling support to NVIDIA Tegra devfreq Dmitry Osipenko 2021-06-01 2:23 ` [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema Dmitry Osipenko 2021-06-01 2:23 ` [PATCH v2 2/2] dt-bindings: devfreq: tegra30-actmon: Add cooling-cells Dmitry Osipenko @ 2021-06-01 15:35 ` Chanwoo Choi 2 siblings, 0 replies; 8+ messages in thread From: Chanwoo Choi @ 2021-06-01 15:35 UTC (permalink / raw) To: Dmitry Osipenko, Thierry Reding, Jonathan Hunter, MyungJoo Ham, Kyungmin Park, Chanwoo Choi, Peter Geis, Matt Merhar Cc: linux-tegra, linux-pm, Rob Herring, linux-kernel, devicetree On 21. 6. 1. 오전 11:23, Dmitry Osipenko wrote: > This series adds two remaining patches of the ACTMON cooling support > series, converting the DT binding to schema and adding cooling properties. > The rest of the patches are already applied. > > Changelog: > > v2: - Added back the "MEMORY CONTROLLER" section to the description of the > interconnect-names property, which was suggested by Thierry Reding. > > - Added r-b from Rob Herring and acks from Chanwoo Choi and > Thierry Reding. > > Dmitry Osipenko (2): > dt-bindings: devfreq: tegra30-actmon: Convert to schema > dt-bindings: devfreq: tegra30-actmon: Add cooling-cells > > .../arm/tegra/nvidia,tegra30-actmon.txt | 57 -------- > .../devfreq/nvidia,tegra30-actmon.yaml | 126 ++++++++++++++++++ > 2 files changed, 126 insertions(+), 57 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/arm/tegra/nvidia,tegra30-actmon.txt > create mode 100644 Documentation/devicetree/bindings/devfreq/nvidia,tegra30-actmon.yaml > Applied them. Thanks. -- Best Regards, Samsung Electronics Chanwoo Choi ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-06-01 15:35 UTC | newest] Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-06-01 2:23 [PATCH v2 0/2] Add thermal cooling support to NVIDIA Tegra devfreq Dmitry Osipenko 2021-06-01 2:23 ` [PATCH v2 1/2] dt-bindings: devfreq: tegra30-actmon: Convert to schema Dmitry Osipenko 2021-06-01 2:55 ` Chanwoo Choi 2021-06-01 2:57 ` Dmitry Osipenko 2021-06-01 11:28 ` Thierry Reding 2021-06-01 2:23 ` [PATCH v2 2/2] dt-bindings: devfreq: tegra30-actmon: Add cooling-cells Dmitry Osipenko 2021-06-01 4:32 ` Dmitry Osipenko 2021-06-01 15:35 ` [PATCH v2 0/2] Add thermal cooling support to NVIDIA Tegra devfreq Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).