From: Leonard Crestez <leonard.crestez@nxp.com>
To: Stephen Boyd <sboyd@kernel.org>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Rob Herring <robh+dt@kernel.org>
Cc: "Shawn Guo" <shawnguo@kernel.org>,
"Michael Turquette" <mturquette@baylibre.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Artur Świgoń" <a.swigon@partner.samsung.com>,
"Saravana Kannan" <saravanak@google.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Alexandre Bailon" <abailon@baylibre.com>,
"Georgi Djakov" <georgi.djakov@linaro.org>,
"Dong Aisheng" <aisheng.dong@nxp.com>,
"Abel Vesa" <abel.vesa@nxp.com>, "Jacky Bai" <ping.bai@nxp.com>,
"Anson Huang" <Anson.Huang@nxp.com>,
"Fabio Estevam" <fabio.estevam@nxp.com>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Will Deacon" <will@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
linux-imx@nxp.com, kernel@pengutronix.de,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH 6/7] PM / devfreq: imx-ddrc: Measure bandwidth with perf
Date: Mon, 12 Aug 2019 21:49:50 +0300 [thread overview]
Message-ID: <6d8762453bf6020b8f1ec8c06bb5713a3d3d635e.1565633880.git.leonard.crestez@nxp.com> (raw)
In-Reply-To: <cover.1565633880.git.leonard.crestez@nxp.com>
In-Reply-To: <cover.1565633880.git.leonard.crestez@nxp.com>
The imx8m ddrc has a performance monitoring block attached which can
be used to measure bandwidth usage and automatically adjust frequency.
There is already a perf driver for that block so instead of implementing
a devfreq events driver use the in-kernel perf API to implement
get_dev_status directly.
Signed-off-by: Leonard Crestez <leonard.crestez@nxp.com>
---
drivers/devfreq/imx-ddrc.c | 136 ++++++++++++++++++++++++++++++++++++-
1 file changed, 134 insertions(+), 2 deletions(-)
diff --git a/drivers/devfreq/imx-ddrc.c b/drivers/devfreq/imx-ddrc.c
index e46a1e711bc6..d7f27cdce697 100644
--- a/drivers/devfreq/imx-ddrc.c
+++ b/drivers/devfreq/imx-ddrc.c
@@ -11,10 +11,13 @@
#include <linux/pm_opp.h>
#include <linux/clk.h>
#include <linux/clk-provider.h>
#include <linux/arm-smccc.h>
+#include <asm/perf_event.h>
+#include <linux/perf_event.h>
+
#define IMX_SIP_DDR_DVFS 0xc2000004
/* Values starting from 0 switch to specific frequency */
#define IMX_SIP_DDR_FREQ_SET_HIGH 0x00
@@ -81,10 +84,22 @@ struct imx_ddrc {
struct clk *dram_alt;
struct clk *dram_apb;
int freq_count;
struct imx_ddrc_freq freq_table[IMX_DDRC_MAX_FREQ_COUNT];
+
+ /* For measuring load with perf events: */
+ struct platform_device* pmu_pdev;
+ struct pmu *pmu;
+
+ struct perf_event_attr rd_event_attr;
+ struct perf_event_attr wr_event_attr;
+ struct perf_event *rd_event;
+ struct perf_event *wr_event;
+
+ u64 last_rd_val, last_rd_ena, last_rd_run;
+ u64 last_wr_val, last_wr_ena, last_wr_run;
};
static struct imx_ddrc_freq* imx_ddrc_find_freq(struct imx_ddrc* priv,
unsigned long rate)
{
@@ -233,17 +248,117 @@ static int imx_ddrc_get_cur_freq(struct device *dev, unsigned long *freq)
static int imx_ddrc_get_dev_status(struct device *dev,
struct devfreq_dev_status *stat)
{
struct imx_ddrc *priv = dev_get_drvdata(dev);
- stat->busy_time = 0;
- stat->total_time = 0;
stat->current_frequency = clk_get_rate(priv->dram_core);
+ if (priv->rd_event && priv->wr_event) {
+ u64 rd_delta, rd_val, rd_ena, rd_run;
+ u64 wr_delta, wr_val, wr_ena, wr_run;
+
+ rd_val = perf_event_read_value(priv->rd_event, &rd_ena, &rd_run);
+ wr_val = perf_event_read_value(priv->wr_event, &wr_ena, &wr_run);
+
+ rd_delta = (rd_val - priv->last_rd_val) * (rd_ena - priv->last_rd_ena) / (rd_run - priv->last_rd_run);
+ priv->last_rd_val = rd_val;
+ priv->last_rd_ena = rd_ena;
+ priv->last_rd_run = rd_run;
+ wr_delta = (wr_val - priv->last_wr_val) * (wr_ena - priv->last_wr_ena) / (wr_run - priv->last_wr_run);
+ priv->last_wr_val = wr_val;
+ priv->last_wr_ena = wr_ena;
+ priv->last_wr_run = wr_run;
+
+ /* magic numbers, possibly wrong */
+ stat->busy_time = 4 * (rd_delta + wr_delta);
+ stat->total_time = stat->current_frequency;
+ } else {
+ stat->busy_time = 0;
+ stat->total_time = 0;
+ }
+
+ return 0;
+}
+
+static int imx_ddrc_perf_disable(struct imx_ddrc *priv)
+{
+ /* release and set to NULL */
+ if (!IS_ERR_OR_NULL(priv->rd_event))
+ perf_event_release_kernel(priv->rd_event);
+ if (!IS_ERR_OR_NULL(priv->wr_event))
+ perf_event_release_kernel(priv->wr_event);
+ priv->rd_event = NULL;
+ priv->wr_event = NULL;
+
return 0;
}
+static int imx_ddrc_perf_enable(struct imx_ddrc *priv)
+{
+ int ret;
+
+ priv->rd_event_attr.size = sizeof(priv->rd_event_attr);
+ priv->rd_event_attr.type = priv->pmu->type;
+ priv->rd_event_attr.config = 0x2a;
+
+ priv->rd_event = perf_event_create_kernel_counter(
+ &priv->rd_event_attr, 0, NULL, NULL, NULL);
+ if (IS_ERR(priv->rd_event)) {
+ ret = PTR_ERR(priv->rd_event);
+ goto err;
+ }
+
+ priv->wr_event_attr.size = sizeof(priv->wr_event_attr);
+ priv->wr_event_attr.type = priv->pmu->type;
+ priv->wr_event_attr.config = 0x2b;
+
+ priv->wr_event = perf_event_create_kernel_counter(
+ &priv->wr_event_attr, 0, NULL, NULL, NULL);
+ if (IS_ERR(priv->wr_event)) {
+ ret = PTR_ERR(priv->wr_event);
+ goto err;
+ }
+
+ return 0;
+
+err:
+ imx_ddrc_perf_disable(priv);
+ return ret;
+}
+
+static int imx_ddrc_init_events(struct device *dev,
+ struct device_node* events_node)
+{
+ struct imx_ddrc *priv = dev_get_drvdata(dev);
+ struct device_driver *driver;
+
+ /*
+ * We need pmu->type for perf_event_attr but there is no API for
+ * mapping device_node to pmu. Fetch private data for imx-ddr-pmu and
+ * cast that to a struct pmu instead.
+ */
+ priv->pmu_pdev = of_find_device_by_node(events_node);
+ if (!priv->pmu_pdev)
+ return -EPROBE_DEFER;
+ driver = priv->pmu_pdev->dev.driver;
+ if (!driver)
+ return -EPROBE_DEFER;
+ if (strcmp(driver->name, "imx-ddr-pmu")) {
+ dev_warn(dev, "devfreq-events node %pOF has unexpected driver %s\n",
+ events_node, driver->name);
+ return -ENODEV;
+ }
+
+ priv->pmu = platform_get_drvdata(priv->pmu_pdev);
+ if (!priv->pmu)
+ return -EINVAL;
+
+ dev_info(dev, "events from pmu %s\n", priv->pmu->name);
+
+ return imx_ddrc_perf_enable(priv);
+}
+
static int imx_ddrc_init_freq_info(struct device *dev)
{
struct imx_ddrc *priv = dev_get_drvdata(dev);
struct arm_smccc_res res;
int index;
@@ -291,10 +406,13 @@ static int imx_ddrc_init_freq_info(struct device *dev)
static void imx_ddrc_exit(struct device *dev)
{
struct imx_ddrc *priv = dev_get_drvdata(dev);
+ imx_ddrc_perf_disable(priv);
+ platform_device_put(priv->pmu_pdev);
+
return dev_pm_opp_of_remove_table(dev);
}
static int imx_ddrc_probe(struct platform_device *pdev)
{
@@ -342,10 +460,22 @@ static int imx_ddrc_probe(struct platform_device *pdev)
priv->profile.get_dev_status = imx_ddrc_get_dev_status;
priv->profile.exit = imx_ddrc_exit;
priv->profile.get_cur_freq = imx_ddrc_get_cur_freq;
priv->profile.initial_freq = clk_get_rate(priv->dram_core);
+ /* Handle devfreq-events */
+ events_node = of_parse_phandle(dev->of_node, "devfreq-events", 0);
+ if (events_node) {
+ ret = imx_ddrc_init_events(dev, events_node);
+ of_node_put(events_node);
+ if (ret) {
+ dev_warn(dev, "failed to init perf events: %d\n", ret);
+ goto err;
+ }
+ gov = DEVFREQ_GOV_SIMPLE_ONDEMAND;
+ }
+
priv->devfreq = devm_devfreq_add_device(dev, &priv->profile,
gov, NULL);
if (IS_ERR(priv->devfreq)) {
ret = PTR_ERR(priv->devfreq);
dev_err(dev, "failed to add devfreq device: %d\n", ret);
@@ -353,10 +483,12 @@ static int imx_ddrc_probe(struct platform_device *pdev)
}
return 0;
err:
+ imx_ddrc_perf_disable(priv);
+ platform_device_put(priv->pmu_pdev);
dev_pm_opp_of_remove_table(dev);
return ret;
}
static const struct of_device_id imx_ddrc_of_match[] = {
--
2.17.1
next prev parent reply other threads:[~2019-08-12 18:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-12 18:49 [PATCH 0/7] PM / devfreq: Add initial imx support Leonard Crestez
2019-08-12 18:49 ` [PATCH 1/7] clk: imx8m: Set CLK_GET_RATE_NOCACHE on dram_alt/apb Leonard Crestez
2019-08-12 18:49 ` [PATCH 2/7] dt-bindings: devfreq: Add bindings for generic imx buses Leonard Crestez
2019-08-12 19:46 ` Rob Herring
2019-08-13 1:32 ` Leonard Crestez
2019-08-13 14:06 ` Rob Herring
2019-08-13 14:59 ` Leonard Crestez
2019-08-12 18:49 ` [PATCH 3/7] PM / devfreq: Add generic imx bus driver Leonard Crestez
2019-08-12 18:49 ` [PATCH 4/7] dt-bindings: devfreq: Add bindings for imx ddr controller Leonard Crestez
2019-08-12 19:51 ` Rob Herring
2019-08-12 18:49 ` [PATCH 5/7] PM / devfreq: Add dynamic scaling " Leonard Crestez
2019-08-12 18:49 ` Leonard Crestez [this message]
2019-08-12 18:49 ` [PATCH 7/7] arm64: dts: imx8mm: Add devfreq nodes Leonard Crestez
[not found] ` <CGME20190812185002epcas1p1c528b12d20771cf4887907fdfd716e22@epcms1p2>
2019-08-13 2:25 ` [PATCH 2/7] dt-bindings: devfreq: Add bindings for generic imx buses MyungJoo Ham
[not found] ` <CGME20190812185005epcas3p10a9a3dbb90489534222e093c63f27900@epcms1p3>
2019-08-13 2:33 ` [PATCH 3/7] PM / devfreq: Add generic imx bus driver MyungJoo Ham
2019-08-13 3:02 ` Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d8762453bf6020b8f1ec8c06bb5713a3d3d635e.1565633880.git.leonard.crestez@nxp.com \
--to=leonard.crestez@nxp.com \
--cc=Anson.Huang@nxp.com \
--cc=a.swigon@partner.samsung.com \
--cc=abailon@baylibre.com \
--cc=abel.vesa@nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=fabio.estevam@nxp.com \
--cc=georgi.djakov@linaro.org \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=myungjoo.ham@samsung.com \
--cc=ping.bai@nxp.com \
--cc=robh+dt@kernel.org \
--cc=saravanak@google.com \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).