linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Lukasz Luba <lukasz.luba@arm.com>
To: Morten Rasmussen <morten.rasmussen@arm.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
	amitk@kernel.org, corbet@lwn.net, daniel.lezcano@linaro.org,
	Dietmar.Eggemann@arm.com, qperret@google.com,
	dianders@chromium.org, mka@chromium.org, rnayak@codeaurora.org,
	rafael@kernel.org, sudeep.holla@arm.com, viresh.kumar@linaro.org,
	sboyd@kernel.org, nm@ti.com
Subject: Re: [PATCH v4 1/4] PM / EM: Add a flag indicating units of power values in Energy Model
Date: Thu, 5 Nov 2020 12:55:34 +0000	[thread overview]
Message-ID: <7740a2a1-2e6a-1e04-91ff-364ea21540d6@arm.com> (raw)
In-Reply-To: <20201105105633.GB8237@e123083-lin>



On 11/5/20 10:56 AM, Morten Rasmussen wrote:
> On Thu, Nov 05, 2020 at 10:09:05AM +0000, Lukasz Luba wrote:
>>
>>
>> On 11/5/20 9:18 AM, Morten Rasmussen wrote:
>>> On Tue, Nov 03, 2020 at 09:05:57AM +0000, Lukasz Luba wrote:
>>>> @@ -79,7 +82,8 @@ struct em_data_callback {
>>>>    struct em_perf_domain *em_cpu_get(int cpu);
>>>>    struct em_perf_domain *em_pd_get(struct device *dev);
>>>>    int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states,
>>>> -				struct em_data_callback *cb, cpumask_t *span);
>>>> +				struct em_data_callback *cb, cpumask_t *spani,
>>>
>>> "spani" looks like a typo?
>>>
>>
>> Good catch, yes, the vim 'i'.
>>
>> Thank you Morten. I will resend this patch when you don't
>> find other issues in the rest of patches.
> 
> The rest of the series looks okay to me.

Thank you for checking the whole series. I have re-sent this patch only.

Lukasz

> 
> Morten
> 

  reply	other threads:[~2020-11-05 12:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-03  9:05 [PATCH v4 0/4] Clarify abstract scale usage for power values in Energy Model, EAS and IPA Lukasz Luba
2020-11-03  9:05 ` [PATCH v4 1/4] PM / EM: Add a flag indicating units of power values in Energy Model Lukasz Luba
2020-11-05  9:18   ` Morten Rasmussen
2020-11-05 10:09     ` Lukasz Luba
2020-11-05 10:56       ` Morten Rasmussen
2020-11-05 12:55         ` Lukasz Luba [this message]
2020-11-03  9:05 ` [PATCH v4 2/4] docs: Clarify abstract scale usage for " Lukasz Luba
2020-11-03  9:05 ` [PATCH v4 3/4] PM / EM: update the comments related to power scale Lukasz Luba
2020-11-03  9:06 ` [PATCH v4 4/4] docs: power: Update Energy Model with new flag indicating " Lukasz Luba
2020-11-04 10:58 ` [PATCH v4 0/4] Clarify abstract scale usage for power values in Energy Model, EAS and IPA Lukasz Luba
2020-11-10 19:32   ` Rafael J. Wysocki
2020-11-17  9:24     ` Lukasz Luba
2020-11-05 12:50 ` [RESEND][PATCH v4 1/4] PM / EM: Add a flag indicating units of power values in Energy Model Lukasz Luba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7740a2a1-2e6a-1e04-91ff-364ea21540d6@arm.com \
    --to=lukasz.luba@arm.com \
    --cc=Dietmar.Eggemann@arm.com \
    --cc=amitk@kernel.org \
    --cc=corbet@lwn.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mka@chromium.org \
    --cc=morten.rasmussen@arm.com \
    --cc=nm@ti.com \
    --cc=qperret@google.com \
    --cc=rafael@kernel.org \
    --cc=rnayak@codeaurora.org \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=sudeep.holla@arm.com \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).