From: Lukasz Luba <lukasz.luba@arm.com>
To: rafael@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
linux-doc@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, robh+dt@kernel.org,
amitk@kernel.org, corbet@lwn.net, daniel.lezcano@linaro.org,
Dietmar.Eggemann@arm.com, morten.rasmussen@arm.com,
qperret@google.com, dianders@chromium.org, mka@chromium.org,
rnayak@codeaurora.org, sudeep.holla@arm.com,
viresh.kumar@linaro.org, sboyd@kernel.org, nm@ti.com
Subject: Re: [PATCH v4 0/4] Clarify abstract scale usage for power values in Energy Model, EAS and IPA
Date: Wed, 4 Nov 2020 10:58:43 +0000 [thread overview]
Message-ID: <9382ea70-cc50-7b78-f5de-716678bdefbf@arm.com> (raw)
In-Reply-To: <20201103090600.29053-1-lukasz.luba@arm.com>
Hi Rafael,
On 11/3/20 9:05 AM, Lukasz Luba wrote:
> Hi all,
>
> The Energy Model supports power values expressed in an abstract scale.
> This has an impact on Intelligent Power Allocation (IPA) and should be
> documented properly. Kernel sub-systems like EAS, IPA and DTPM
> (new comming PowerCap framework) would use the new flag to capture
> potential miss-configuration where the devices have registered different
> power scales, thus cannot operate together.
>
> There was a discussion below v2 of this patch series, which might help
> you to get context of these changes [2].
>
> The agreed approach is to have the DT as a source of power values expressed
> always in milli-Watts and the only way to submit with abstract scale values
> is via the em_dev_register_perf_domain() API.
>
> Changes:
> v4:
> - change bool to int type for 'miliwatts' in struct em_perf_domain
> (suggested by Quentin)
> - removed one sentence from patch 2/4 in IPA doc power_allocator.rst
> (suggested by Quentin)
> - added reviewed-by from Quentin to 1/4, 3/4, 4/4 patches
There was no major objections in the v3 and this v4 just addressed
minor comments. The important discussions mostly happen in v2.
Could you take the patches via your tree, please?
Regards,
Lukasz
next prev parent reply other threads:[~2020-11-04 10:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 9:05 [PATCH v4 0/4] Clarify abstract scale usage for power values in Energy Model, EAS and IPA Lukasz Luba
2020-11-03 9:05 ` [PATCH v4 1/4] PM / EM: Add a flag indicating units of power values in Energy Model Lukasz Luba
2020-11-05 9:18 ` Morten Rasmussen
2020-11-05 10:09 ` Lukasz Luba
2020-11-05 10:56 ` Morten Rasmussen
2020-11-05 12:55 ` Lukasz Luba
2020-11-03 9:05 ` [PATCH v4 2/4] docs: Clarify abstract scale usage for " Lukasz Luba
2020-11-03 9:05 ` [PATCH v4 3/4] PM / EM: update the comments related to power scale Lukasz Luba
2020-11-03 9:06 ` [PATCH v4 4/4] docs: power: Update Energy Model with new flag indicating " Lukasz Luba
2020-11-04 10:58 ` Lukasz Luba [this message]
2020-11-10 19:32 ` [PATCH v4 0/4] Clarify abstract scale usage for power values in Energy Model, EAS and IPA Rafael J. Wysocki
2020-11-17 9:24 ` Lukasz Luba
2020-11-05 12:50 ` [RESEND][PATCH v4 1/4] PM / EM: Add a flag indicating units of power values in Energy Model Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9382ea70-cc50-7b78-f5de-716678bdefbf@arm.com \
--to=lukasz.luba@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=amitk@kernel.org \
--cc=corbet@lwn.net \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=morten.rasmussen@arm.com \
--cc=nm@ti.com \
--cc=qperret@google.com \
--cc=rafael@kernel.org \
--cc=rnayak@codeaurora.org \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).