* [PATCH v3] thermal: rcar_gen3_thermal: improve logging during probe
@ 2022-06-10 20:04 Wolfram Sang
2022-06-12 21:32 ` Niklas Söderlund
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Wolfram Sang @ 2022-06-10 20:04 UTC (permalink / raw)
To: linux-renesas-soc
Cc: Wolfram Sang, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, linux-pm, linux-kernel
When setting up a new board, a plain "Can't register thermal zone"
didn't help me much because the thermal zones in DT were all fine. I
just had a sensor entry too much in the parent TSC node. Reword the
failure/success messages to contain the sensor number to make it easier
to understand which sensor is affected. Example output now:
rcar_gen3_thermal e6198000.thermal: Sensor 0: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 1: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 2: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
Change since v2:
* don't add plural-'s' at runtime to allow for a greppable string
(Thanks, Niklas!)
drivers/thermal/rcar_gen3_thermal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
index ccdf8a24ddc7..cda7c52f2319 100644
--- a/drivers/thermal/rcar_gen3_thermal.c
+++ b/drivers/thermal/rcar_gen3_thermal.c
@@ -511,7 +511,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
zone = devm_thermal_zone_of_sensor_register(dev, i, tsc,
&rcar_gen3_tz_of_ops);
if (IS_ERR(zone)) {
- dev_err(dev, "Can't register thermal zone\n");
+ dev_err(dev, "Sensor %u: Can't register thermal zone\n", i);
ret = PTR_ERR(zone);
goto error_unregister;
}
@@ -533,7 +533,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
if (ret < 0)
goto error_unregister;
- dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret);
+ dev_info(dev, "Sensor %u: Loaded %d trip points\n", i, ret);
}
if (!priv->num_tscs) {
--
2.35.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3] thermal: rcar_gen3_thermal: improve logging during probe
2022-06-10 20:04 [PATCH v3] thermal: rcar_gen3_thermal: improve logging during probe Wolfram Sang
@ 2022-06-12 21:32 ` Niklas Söderlund
2022-06-13 9:07 ` Geert Uytterhoeven
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Niklas Söderlund @ 2022-06-12 21:32 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-renesas-soc, Rafael J. Wysocki, Daniel Lezcano,
Amit Kucheria, Zhang Rui, linux-pm, linux-kernel
Hi Wolfram,
Thanks for your work.
On 2022-06-10 22:04:59 +0200, Wolfram Sang wrote:
> When setting up a new board, a plain "Can't register thermal zone"
> didn't help me much because the thermal zones in DT were all fine. I
> just had a sensor entry too much in the parent TSC node. Reword the
> failure/success messages to contain the sensor number to make it easier
> to understand which sensor is affected. Example output now:
>
> rcar_gen3_thermal e6198000.thermal: Sensor 0: Loaded 1 trip points
> rcar_gen3_thermal e6198000.thermal: Sensor 1: Loaded 1 trip points
> rcar_gen3_thermal e6198000.thermal: Sensor 2: Loaded 1 trip points
> rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>
> Change since v2:
>
> * don't add plural-'s' at runtime to allow for a greppable string
> (Thanks, Niklas!)
>
> drivers/thermal/rcar_gen3_thermal.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
> index ccdf8a24ddc7..cda7c52f2319 100644
> --- a/drivers/thermal/rcar_gen3_thermal.c
> +++ b/drivers/thermal/rcar_gen3_thermal.c
> @@ -511,7 +511,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
> zone = devm_thermal_zone_of_sensor_register(dev, i, tsc,
> &rcar_gen3_tz_of_ops);
> if (IS_ERR(zone)) {
> - dev_err(dev, "Can't register thermal zone\n");
> + dev_err(dev, "Sensor %u: Can't register thermal zone\n", i);
> ret = PTR_ERR(zone);
> goto error_unregister;
> }
> @@ -533,7 +533,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
> if (ret < 0)
> goto error_unregister;
>
> - dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret);
> + dev_info(dev, "Sensor %u: Loaded %d trip points\n", i, ret);
> }
>
> if (!priv->num_tscs) {
> --
> 2.35.1
>
--
Kind Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] thermal: rcar_gen3_thermal: improve logging during probe
2022-06-10 20:04 [PATCH v3] thermal: rcar_gen3_thermal: improve logging during probe Wolfram Sang
2022-06-12 21:32 ` Niklas Söderlund
@ 2022-06-13 9:07 ` Geert Uytterhoeven
2022-06-14 18:45 ` Daniel Lezcano
2022-07-28 15:41 ` [thermal: thermal/next] drivers/thermal/rcar_gen3_thermal: Improve " thermal-bot for Wolfram Sang
3 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-06-13 9:07 UTC (permalink / raw)
To: Wolfram Sang
Cc: Linux-Renesas, Niklas Söderlund, Rafael J. Wysocki,
Daniel Lezcano, Amit Kucheria, Zhang Rui, Linux PM list,
Linux Kernel Mailing List
On Fri, Jun 10, 2022 at 10:08 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> When setting up a new board, a plain "Can't register thermal zone"
> didn't help me much because the thermal zones in DT were all fine. I
> just had a sensor entry too much in the parent TSC node. Reword the
> failure/success messages to contain the sensor number to make it easier
> to understand which sensor is affected. Example output now:
>
> rcar_gen3_thermal e6198000.thermal: Sensor 0: Loaded 1 trip points
> rcar_gen3_thermal e6198000.thermal: Sensor 1: Loaded 1 trip points
> rcar_gen3_thermal e6198000.thermal: Sensor 2: Loaded 1 trip points
> rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Change since v2:
>
> * don't add plural-'s' at runtime to allow for a greppable string
> (Thanks, Niklas!)
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3] thermal: rcar_gen3_thermal: improve logging during probe
2022-06-10 20:04 [PATCH v3] thermal: rcar_gen3_thermal: improve logging during probe Wolfram Sang
2022-06-12 21:32 ` Niklas Söderlund
2022-06-13 9:07 ` Geert Uytterhoeven
@ 2022-06-14 18:45 ` Daniel Lezcano
2022-07-28 15:41 ` [thermal: thermal/next] drivers/thermal/rcar_gen3_thermal: Improve " thermal-bot for Wolfram Sang
3 siblings, 0 replies; 5+ messages in thread
From: Daniel Lezcano @ 2022-06-14 18:45 UTC (permalink / raw)
To: Wolfram Sang, linux-renesas-soc
Cc: Niklas Söderlund, Rafael J. Wysocki, Amit Kucheria,
Zhang Rui, linux-pm, linux-kernel
On 10/06/2022 22:04, Wolfram Sang wrote:
> When setting up a new board, a plain "Can't register thermal zone"
> didn't help me much because the thermal zones in DT were all fine. I
> just had a sensor entry too much in the parent TSC node. Reword the
> failure/success messages to contain the sensor number to make it easier
> to understand which sensor is affected. Example output now:
>
> rcar_gen3_thermal e6198000.thermal: Sensor 0: Loaded 1 trip points
> rcar_gen3_thermal e6198000.thermal: Sensor 1: Loaded 1 trip points
> rcar_gen3_thermal e6198000.thermal: Sensor 2: Loaded 1 trip points
> rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 5+ messages in thread
* [thermal: thermal/next] drivers/thermal/rcar_gen3_thermal: Improve logging during probe
2022-06-10 20:04 [PATCH v3] thermal: rcar_gen3_thermal: improve logging during probe Wolfram Sang
` (2 preceding siblings ...)
2022-06-14 18:45 ` Daniel Lezcano
@ 2022-07-28 15:41 ` thermal-bot for Wolfram Sang
3 siblings, 0 replies; 5+ messages in thread
From: thermal-bot for Wolfram Sang @ 2022-07-28 15:41 UTC (permalink / raw)
To: linux-pm
Cc: Wolfram Sang, Geert Uytterhoeven, niklas.soderlund+renesas,
Daniel Lezcano, rui.zhang, amitk
The following commit has been merged into the thermal/next branch of thermal:
Commit-ID: 404dd7dfb13028d315514f63ed3cf9da46307a39
Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git//404dd7dfb13028d315514f63ed3cf9da46307a39
Author: Wolfram Sang <wsa+renesas@sang-engineering.com>
AuthorDate: Fri, 10 Jun 2022 22:04:59 +02:00
Committer: Daniel Lezcano <daniel.lezcano@linaro.org>
CommitterDate: Thu, 28 Jul 2022 17:29:44 +02:00
drivers/thermal/rcar_gen3_thermal: Improve logging during probe
When setting up a new board, a plain "Can't register thermal zone"
didn't help me much because the thermal zones in DT were all fine. I
just had a sensor entry too much in the parent TSC node. Reword the
failure/success messages to contain the sensor number to make it easier
to understand which sensor is affected. Example output now:
rcar_gen3_thermal e6198000.thermal: Sensor 0: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 1: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 2: Loaded 1 trip points
rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Link: https://lore.kernel.org/r/20220610200500.6727-1-wsa+renesas@sang-engineering.com
Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
---
drivers/thermal/rcar_gen3_thermal.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c
index 43eb25b..e2020c6 100644
--- a/drivers/thermal/rcar_gen3_thermal.c
+++ b/drivers/thermal/rcar_gen3_thermal.c
@@ -507,7 +507,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
zone = devm_thermal_zone_of_sensor_register(dev, i, tsc,
&rcar_gen3_tz_of_ops);
if (IS_ERR(zone)) {
- dev_err(dev, "Can't register thermal zone\n");
+ dev_err(dev, "Sensor %u: Can't register thermal zone\n", i);
ret = PTR_ERR(zone);
goto error_unregister;
}
@@ -529,7 +529,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev)
if (ret < 0)
goto error_unregister;
- dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret);
+ dev_info(dev, "Sensor %u: Loaded %d trip points\n", i, ret);
}
if (!priv->num_tscs) {
^ permalink raw reply related [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-28 15:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-10 20:04 [PATCH v3] thermal: rcar_gen3_thermal: improve logging during probe Wolfram Sang
2022-06-12 21:32 ` Niklas Söderlund
2022-06-13 9:07 ` Geert Uytterhoeven
2022-06-14 18:45 ` Daniel Lezcano
2022-07-28 15:41 ` [thermal: thermal/next] drivers/thermal/rcar_gen3_thermal: Improve " thermal-bot for Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).