linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Xin Hao <xhao@linux.alibaba.com>
To: rjw@rjwysocki.net
Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] cpufreq: CPPC: simply the code access 'highest_perf' value in cppc_perf_caps struct
Date: Tue, 4 Aug 2020 10:37:47 +0800	[thread overview]
Message-ID: <8643d122-c069-192e-8f3a-dc18f84eed9a@linux.alibaba.com> (raw)
In-Reply-To: <20200701042007.13333-1-xhao@linux.alibaba.com>

Hi everyone:

I want to know why my patch didn't merge into upstream ?


Thanks

在 2020/7/1 下午12:20, Xin Hao 写道:
>   The 'caps' variable has been defined, so there is no need to get
>   'highest_perf' value through 'cpu->caps.highest_perf', you can use
>   'caps->highest_perf' instead.
>
> Signed-off-by: Xin Hao <xhao@linux.alibaba.com>
> ---
>   drivers/cpufreq/cppc_cpufreq.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c
> index 257d726a4456..051d0e56c67a 100644
> --- a/drivers/cpufreq/cppc_cpufreq.c
> +++ b/drivers/cpufreq/cppc_cpufreq.c
> @@ -161,7 +161,7 @@ static unsigned int cppc_cpufreq_perf_to_khz(struct cppc_cpudata *cpu,
>   		if (!max_khz)
>   			max_khz = cppc_get_dmi_max_khz();
>   		mul = max_khz;
> -		div = cpu->perf_caps.highest_perf;
> +		div = caps->highest_perf;
>   	}
>   	return (u64)perf * mul / div;
>   }
> @@ -184,7 +184,7 @@ static unsigned int cppc_cpufreq_khz_to_perf(struct cppc_cpudata *cpu,
>   	} else {
>   		if (!max_khz)
>   			max_khz = cppc_get_dmi_max_khz();
> -		mul = cpu->perf_caps.highest_perf;
> +		mul = caps->highest_perf;
>   		div = max_khz;
>   	}
>   

  parent reply	other threads:[~2020-08-04  2:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-01  4:20 [PATCH v3] cpufreq: CPPC: simply the code access 'highest_perf' value in cppc_perf_caps struct Xin Hao
2020-07-01  4:52 ` Viresh Kumar
2020-07-01 12:16   ` Rafael J. Wysocki
2020-07-02  2:37     ` Viresh Kumar
2020-07-02 11:06       ` Rafael J. Wysocki
2020-07-02 11:09         ` Viresh Kumar
2020-08-04  2:37 ` Xin Hao [this message]
2020-08-04  4:37   ` Viresh Kumar
2020-08-04  4:47     ` Xin Hao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8643d122-c069-192e-8f3a-dc18f84eed9a@linux.alibaba.com \
    --to=xhao@linux.alibaba.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@rjwysocki.net \
    --cc=viresh.kumar@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).