linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yannik Sembritzki <yannik@sembritzki.me>
To: Jonas Meurer <jonas@freesources.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
	Linux PM <linux-pm@vger.kernel.org>, Pavel Machek <pavel@ucw.cz>,
	Len Brown <len.brown@intel.com>,
	Tim Dittler <tim.dittler@systemli.org>
Subject: Re: [RFC PATCH] PM: Add a switch for disabling/enabling sync() before suspend
Date: Mon, 2 Dec 2019 15:12:00 +0100	[thread overview]
Message-ID: <86d9ea4b-5f51-4c39-6b6e-6c19b5559da1@sembritzki.me> (raw)
In-Reply-To: <355b0fb4-47da-3ab8-bc65-5191cd8882d6@freesources.org>

Hi Jonas,

thanks for the patch, it looks promising to me.

I'd suggest you send it to lkml for additional feedback.

Best regards
Yannik

On 12.11.19 12:00, Jonas Meurer wrote:
> Hi Rafael,
>
> Jonas Meurer:
>> Jonas Meurer:
>>> Rafael J. Wysocki:
>>>> On Mon, Oct 21, 2019 at 12:47 PM Jonas Meurer <jonas@freesources.org> wrote:
>>>>> Hi Rafael and linux-pm maintainers,
>>>>>
>>>>> sorry for the noise, but again: is there a chance to get a brief review
>>>>> of my patchset?
>>>>>
>>>>> Probably it was a bad idea to rename the build-time flag, right? Should
>>>>> I revert that part of the patch?
>>>> Sorry for the delay, I'll get to your patches in the next couple of days.
>>> No worries. Thanks a lot for looking into it. It's no problem at all for
>>> me/us if it takes a few more days. Just wanted to make sure that it
>>> doesn't get lost.
>>>
>>> If you find a minute to give a quick comment on whether I should revert
>>> the renaming of build-time flag CONFIG_SUSPEND_SKIP_SYNC to
>>> CONFIG_SKIP_SYNC_ON_SUSPEND, then I could do that in advance to your
>>> thorough review.
>> I went ahead now and reverted the renaming of build-time flag
>> CONFIG_SUSPEND_SKIP_SYNC[1]. There's no reason to do so and it breaks
>> backwards-compability.
>>
>> Rafael, could you take a look at the patches anytime soon? I'd like to
>> propose them for inclusion into the Linux Kernel within the next weeks.
>> Again the question: would you sign them (if you consider them sensible)?
>> It's my first Linux Kernel contribution, so I'm unsure about the
>> process. My understanding is that a subsystem maintainer should approve
>> the patches first before they can be proposed for upstream integration,
>> right?
> Just another friendly reminder: do you think you find time to look into
> my patchset anytime soon? Or shall I re-send them with lkml in the loop
> as they are?
>
> Kind regards
>  jonas
>


  reply	other threads:[~2019-12-02 14:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-07 10:50 [RFC PATCH] PM: Add a switch for disabling/enabling sync() before suspend Jonas Meurer
2019-10-10 15:00 ` Jonas Meurer
2019-10-11 10:22 ` Rafael J. Wysocki
2019-10-14 17:46   ` Jonas Meurer
2019-10-14 17:48     ` [PATCH v2 1/2] " Jonas Meurer
2019-10-14 17:49     ` [PATCH v2 2/2] PM: Change CONFIG_SUSPEND_SKIP_SYNC to CONFIG_SKIP_SYNC_ON_SUSPEND Jonas Meurer
2019-11-04 10:51       ` [PATCH v3 2/2] PM: CONFIG_SUSPEND_SKIP_SYNC sets default for '/sys/power/sync_on_suspend' Jonas Meurer
2019-10-21 10:47     ` [RFC PATCH] PM: Add a switch for disabling/enabling sync() before suspend Jonas Meurer
2019-10-21 21:47       ` Rafael J. Wysocki
2019-10-22  8:54         ` Jonas Meurer
2019-11-04 10:57           ` Jonas Meurer
2019-11-12 11:00             ` Jonas Meurer
2019-12-02 14:12               ` Yannik Sembritzki [this message]
2019-12-02 17:05                 ` Jonas Meurer
2019-10-22 10:39       ` Pavel Machek
2019-10-31 15:56         ` Jonas Meurer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86d9ea4b-5f51-4c39-6b6e-6c19b5559da1@sembritzki.me \
    --to=yannik@sembritzki.me \
    --cc=jonas@freesources.org \
    --cc=len.brown@intel.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rafael@kernel.org \
    --cc=tim.dittler@systemli.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).