Re: [PATCH V3 2/2] thermal: Add HiSilicon Kunpeng thermal driver

[Daniel Lezcano <daniel.lezcano@linaro.org>]

On 09/05/2020 09:35, Zhou Wang wrote:
> On 2020/4/28 22:02, Daniel Lezcano wrote:
>> On 28/04/2020 13:58, shenyang (M) wrote:
>>> On 2020/4/27 20:13, Daniel Lezcano wrote:
>>>> On 21/04/2020 09:44, Yang Shen wrote:
>>>>> Support HiSilicon Kunpeng tsensor. the driver will report the max
>>>>> temperature for each core.
>>>>
>>>> As this is a new driver, can you give a bit more details of the hardware
>>>> in this description.
>>>>
>>>> A subsidiary question, why do you want to aggregate the temperatures in
>>>> this driver ?
>>>>
>>>
>>> OK. In fact, there are five temperature sensors distributed in the SOC.
>>> And our strategy is to collect all temperatures and return the max to
>>> the interface.
>>
>> The aggregation should be done in the thermal framework not in the driver.
>>
>> Why not create one sensor per thermal zone, so giving the opportunity to
>> create different configurations with different cooling device ?
> 
> Hi Daniel,
> 
> In our SoC, we use IMU(Intelligent Management Unit) which is an out of band
> management processor to control cooling device. We use fans to cool CPU, one
> fan is for one SoC. So getting one temperature for one SoC is enough here.
> 
> We also want to report temperature of the SoC from kernel thermal subsystem,
> so users get get SoC temperature from sysfs or user space tool, like Im-sensor.
> The goal of this driver is just to do this.

Are you saying you don't care of any cooling devices from the kernel as
the IMU is taking care of it ?

Do you have a pointer to a DT where the thermal zones are defined?

[ ... ]


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog