* [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put()
@ 2019-12-14 18:11 Yangtao Li
2019-12-14 18:11 ` [PATCH 2/2] PM / devfreq: rk3399_dmc: " Yangtao Li
2019-12-15 15:30 ` [PATCH 1/2] PM / devfreq: rockchip-dfi: " Chanwoo Choi
0 siblings, 2 replies; 5+ messages in thread
From: Yangtao Li @ 2019-12-14 18:11 UTC (permalink / raw)
To: cw00.choi, myungjoo.ham, kyungmin.park, heiko
Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, Yangtao Li
of_node_put needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/devfreq/event/rockchip-dfi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
index 5d1042188727..45b190e443d8 100644
--- a/drivers/devfreq/event/rockchip-dfi.c
+++ b/drivers/devfreq/event/rockchip-dfi.c
@@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
node = of_parse_phandle(np, "rockchip,pmu", 0);
if (node) {
data->regmap_pmu = syscon_node_to_regmap(node);
+ of_node_put(node);
if (IS_ERR(data->regmap_pmu))
return PTR_ERR(data->regmap_pmu);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] PM / devfreq: rk3399_dmc: add missing of_node_put()
2019-12-14 18:11 [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put() Yangtao Li
@ 2019-12-14 18:11 ` Yangtao Li
2019-12-15 15:31 ` Chanwoo Choi
2019-12-15 15:30 ` [PATCH 1/2] PM / devfreq: rockchip-dfi: " Chanwoo Choi
1 sibling, 1 reply; 5+ messages in thread
From: Yangtao Li @ 2019-12-14 18:11 UTC (permalink / raw)
To: cw00.choi, myungjoo.ham, kyungmin.park, heiko
Cc: linux-pm, linux-arm-kernel, linux-rockchip, linux-kernel, Yangtao Li
of_node_put() needs to be called when the device node which is got
from of_parse_phandle has finished using.
Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
---
drivers/devfreq/rk3399_dmc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
index 2e65d7279d79..2f1027c5b647 100644
--- a/drivers/devfreq/rk3399_dmc.c
+++ b/drivers/devfreq/rk3399_dmc.c
@@ -372,6 +372,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
node = of_parse_phandle(np, "rockchip,pmu", 0);
if (node) {
data->regmap_pmu = syscon_node_to_regmap(node);
+ of_node_put(node);
if (IS_ERR(data->regmap_pmu))
return PTR_ERR(data->regmap_pmu);
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put()
2019-12-14 18:11 [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put() Yangtao Li
2019-12-14 18:11 ` [PATCH 2/2] PM / devfreq: rk3399_dmc: " Yangtao Li
@ 2019-12-15 15:30 ` Chanwoo Choi
2019-12-15 15:42 ` Frank Lee
1 sibling, 1 reply; 5+ messages in thread
From: Chanwoo Choi @ 2019-12-15 15:30 UTC (permalink / raw)
To: Yangtao Li
Cc: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, Heiko Stübner,
Linux PM list, linux-arm-kernel, open list:ARM/Rockchip SoC...,
linux-kernel
2019년 12월 15일 (일) 오전 3:12, Yangtao Li <tiny.windzz@gmail.com>님이 작성:
>
> of_node_put needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/devfreq/event/rockchip-dfi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> index 5d1042188727..45b190e443d8 100644
> --- a/drivers/devfreq/event/rockchip-dfi.c
> +++ b/drivers/devfreq/event/rockchip-dfi.c
> @@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
> node = of_parse_phandle(np, "rockchip,pmu", 0);
> if (node) {
> data->regmap_pmu = syscon_node_to_regmap(node);
> + of_node_put(node);
> if (IS_ERR(data->regmap_pmu))
> return PTR_ERR(data->regmap_pmu);
> }
> --
> 2.17.1
>
Applied it. Better to use the capital letter for first char of sentence.
--
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] PM / devfreq: rk3399_dmc: add missing of_node_put()
2019-12-14 18:11 ` [PATCH 2/2] PM / devfreq: rk3399_dmc: " Yangtao Li
@ 2019-12-15 15:31 ` Chanwoo Choi
0 siblings, 0 replies; 5+ messages in thread
From: Chanwoo Choi @ 2019-12-15 15:31 UTC (permalink / raw)
To: Yangtao Li
Cc: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, Heiko Stübner,
Linux PM list, linux-arm-kernel, open list:ARM/Rockchip SoC...,
linux-kernel
2019년 12월 15일 (일) 오전 3:12, Yangtao Li <tiny.windzz@gmail.com>님이 작성:
>
> of_node_put() needs to be called when the device node which is got
> from of_parse_phandle has finished using.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> drivers/devfreq/rk3399_dmc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/devfreq/rk3399_dmc.c b/drivers/devfreq/rk3399_dmc.c
> index 2e65d7279d79..2f1027c5b647 100644
> --- a/drivers/devfreq/rk3399_dmc.c
> +++ b/drivers/devfreq/rk3399_dmc.c
> @@ -372,6 +372,7 @@ static int rk3399_dmcfreq_probe(struct platform_device *pdev)
> node = of_parse_phandle(np, "rockchip,pmu", 0);
> if (node) {
> data->regmap_pmu = syscon_node_to_regmap(node);
> + of_node_put(node);
> if (IS_ERR(data->regmap_pmu))
> return PTR_ERR(data->regmap_pmu);
> }
> --
> 2.17.1
>
Applied it.
--
Best Regards,
Chanwoo Choi
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put()
2019-12-15 15:30 ` [PATCH 1/2] PM / devfreq: rockchip-dfi: " Chanwoo Choi
@ 2019-12-15 15:42 ` Frank Lee
0 siblings, 0 replies; 5+ messages in thread
From: Frank Lee @ 2019-12-15 15:42 UTC (permalink / raw)
To: Chanwoo Choi
Cc: Chanwoo Choi, MyungJoo Ham, Kyungmin Park, Heiko Stübner,
Linux PM list, linux-arm-kernel, open list:ARM/Rockchip SoC...,
linux-kernel
On Sun, Dec 15, 2019 at 11:31 PM Chanwoo Choi <chanwoo@kernel.org> wrote:
>
> 2019년 12월 15일 (일) 오전 3:12, Yangtao Li <tiny.windzz@gmail.com>님이 작성:
> >
> > of_node_put needs to be called when the device node which is got
> > from of_parse_phandle has finished using.
> >
> > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> > ---
> > drivers/devfreq/event/rockchip-dfi.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/devfreq/event/rockchip-dfi.c b/drivers/devfreq/event/rockchip-dfi.c
> > index 5d1042188727..45b190e443d8 100644
> > --- a/drivers/devfreq/event/rockchip-dfi.c
> > +++ b/drivers/devfreq/event/rockchip-dfi.c
> > @@ -200,6 +200,7 @@ static int rockchip_dfi_probe(struct platform_device *pdev)
> > node = of_parse_phandle(np, "rockchip,pmu", 0);
> > if (node) {
> > data->regmap_pmu = syscon_node_to_regmap(node);
> > + of_node_put(node);
> > if (IS_ERR(data->regmap_pmu))
> > return PTR_ERR(data->regmap_pmu);
> > }
> > --
> > 2.17.1
> >
>
> Applied it. Better to use the capital letter for first char of sentence.
Thx!
Yangtao
>
> --
> Best Regards,
> Chanwoo Choi
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-12-15 15:42 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-14 18:11 [PATCH 1/2] PM / devfreq: rockchip-dfi: add missing of_node_put() Yangtao Li
2019-12-14 18:11 ` [PATCH 2/2] PM / devfreq: rk3399_dmc: " Yangtao Li
2019-12-15 15:31 ` Chanwoo Choi
2019-12-15 15:30 ` [PATCH 1/2] PM / devfreq: rockchip-dfi: " Chanwoo Choi
2019-12-15 15:42 ` Frank Lee
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).