Re: [PATCH v1 1/5] dt-bindings: power: Add bindings for a power domain controlled by a regulator

From: Max Krummenacher <max.oss.09@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Max Krummenacher <max.krummenacher@toradex.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Linux PM list <linux-pm@vger.kernel.org>,
	Francesco Dolcini <francesco.dolcini@toradex.com>,
	Mark Brown <broonie@kernel.org>,
	"Rafael J . Wysocki" <rafael@kernel.org>,
	Kevin Hilman <khilman@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 1/5] dt-bindings: power: Add bindings for a power domain controlled by a regulator
Date: Wed, 15 Jun 2022 17:18:54 +0200	[thread overview]
Message-ID: <CAEHkU3Vw-Yt6COpJ=K-98CA5dH-iD6AnSHwuBFmQg8yfNsgb-w@mail.gmail.com> (raw)
In-Reply-To: <CAMuHMdWm5WV7L=HJnysw76ObG_QPWicSH1kGg4k-GL8nNHd_SQ@mail.gmail.com>

Hi

On Tue, Jun 14, 2022 at 9:24 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Max,
>
> On Thu, Jun 9, 2022 at 5:16 PM Max Krummenacher <max.oss.09@gmail.com> wrote:
> > From: Max Krummenacher <max.krummenacher@toradex.com>
> >
> > Adds binding for a power domain provider which uses a regulator to control
> > the power domain.
> >
> > Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com>
>
> Thanks for your patch!
>
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/regulator-power-domain.yaml
> > @@ -0,0 +1,58 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/power/regulator-power-domain.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Power domain controlled by a regulator
> > +
> > +maintainers:
> > +  - Max Krummenacher <max.krummenacher@toradex.com>
> > +
> > +description: |+
> > +  Power domain provider which uses a regulator to control
> > +  the power domain.
> > +
> > +allOf:
> > +  - $ref: "power-domain.yaml#"
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - regulator-pm-pd
> > +
> > +  power-supply:
> > +    description: The regulator used to control the power domain.
>
> I guess there can be more than one?

The proposed implementation currently only uses one.

When I did it I considered more than one regulator a rare use case and
I was under the impression that the generic power domain code
can handle multiple power domains. With that in mind I assumed that
one would create multiple regulator-pm-pd instances each controlling
one regulator and add all of them to the power-domains property of
the power domain consumer.

But it seems the implementation requires the power domain consumer
to handle that case in its code rather than relying on the generic code. [1]

Do you see a real world use case to handle multiple regulators?

Max

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/base/power/domain.c?id=8cb1cbd644d5bba5b72eedd632f249c1c677b792#n2290

>
> Gr{oetje,eeting}s,
>
>                         Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds