* [PATCH] power: avs: qcom-cpr: Fix error code in cpr_fuse_corner_init()
@ 2020-01-08 5:34 Dan Carpenter
2020-01-08 22:29 ` Rafael J. Wysocki
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2020-01-08 5:34 UTC (permalink / raw)
To: Andy Gross, Niklas Cassel
Cc: Bjorn Andersson, Kevin Hilman, Nishanth Menon, Rafael J. Wysocki,
Jorge Ramirez-Ortiz, Ulf Hansson, linux-pm, linux-arm-msm,
linux-kernel, kernel-janitors
We're returning the wrong variable. "ret" isn't initialized.
Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/power/avs/qcom-cpr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
index 9247f53550b3..0321729431a5 100644
--- a/drivers/power/avs/qcom-cpr.c
+++ b/drivers/power/avs/qcom-cpr.c
@@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv)
uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage,
step_volt, drv);
if (uV < 0)
- return ret;
+ return uV;
fuse->min_uV = fdata->min_uV;
fuse->max_uV = fdata->max_uV;
--
2.11.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] power: avs: qcom-cpr: Fix error code in cpr_fuse_corner_init()
2020-01-08 5:34 [PATCH] power: avs: qcom-cpr: Fix error code in cpr_fuse_corner_init() Dan Carpenter
@ 2020-01-08 22:29 ` Rafael J. Wysocki
0 siblings, 0 replies; 2+ messages in thread
From: Rafael J. Wysocki @ 2020-01-08 22:29 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Gross, Niklas Cassel, Bjorn Andersson, Kevin Hilman,
Nishanth Menon, Rafael J. Wysocki, Jorge Ramirez-Ortiz,
Ulf Hansson, Linux PM, linux-arm-msm, Linux Kernel Mailing List,
kernel-janitors
On Wed, Jan 8, 2020 at 6:34 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> We're returning the wrong variable. "ret" isn't initialized.
>
> Fixes: bf6910abf548 ("power: avs: Add support for CPR (Core Power Reduction)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/power/avs/qcom-cpr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/avs/qcom-cpr.c b/drivers/power/avs/qcom-cpr.c
> index 9247f53550b3..0321729431a5 100644
> --- a/drivers/power/avs/qcom-cpr.c
> +++ b/drivers/power/avs/qcom-cpr.c
> @@ -922,7 +922,7 @@ static int cpr_fuse_corner_init(struct cpr_drv *drv)
> uV = cpr_read_fuse_uV(desc, fdata, fuses->init_voltage,
> step_volt, drv);
> if (uV < 0)
> - return ret;
> + return uV;
>
> fuse->min_uV = fdata->min_uV;
> fuse->max_uV = fdata->max_uV;
> --
Thanks for the fix, but this issue has been fixed already.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-01-08 22:29 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-01-08 5:34 [PATCH] power: avs: qcom-cpr: Fix error code in cpr_fuse_corner_init() Dan Carpenter
2020-01-08 22:29 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).