From: "Rafael J. Wysocki" <rafael@kernel.org>
To: Shiyang Ruan <ruansy.fnst@cn.fujitsu.com>
Cc: "the arch/x86 maintainers" <x86@kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <len.brown@intel.com>, Pavel Machek <pavel@ucw.cz>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Cao jin <caoj.fnst@cn.fujitsu.com>
Subject: Re: [RFC PATCH] x86/acpi: Drop duplicate BOOT table initialization
Date: Fri, 15 Nov 2019 10:09:06 +0100 [thread overview]
Message-ID: <CAJZ5v0jmQEKip=7530mTSzeY_bRSyJv_Y7B49AJuLiDaTjJqSQ@mail.gmail.com> (raw)
In-Reply-To: <20191115050613.1556-1-ruansy.fnst@cn.fujitsu.com>
On Fri, Nov 15, 2019 at 6:06 AM Shiyang Ruan <ruansy.fnst@cn.fujitsu.com> wrote:
>
> From: Cao jin <caoj.fnst@cn.fujitsu.com>
>
> ACPI BOOT table is initialized in both acpi_boot_table_init &
> acpi_boot_init of setup_arch, but its usage is quite late at the end of
> start_kernel. It should be safe to drop one of them. Since it is less
> related with table init, drop it from there.
>
> Signed-off-by: Cao jin <caoj.fnst@cn.fujitsu.com>
Please resend with a CC to linux-acpi@vger.kernel.org
> ---
> arch/x86/kernel/acpi/boot.c | 2 --
> 1 file changed, 2 deletions(-)
>
> It existed since git repo is built, so it might has its reason? The
> patch is not tested since I don't have BOOT table in my firmware.
>
> diff --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
> index 04205ce127a1..ca1c15bb0b48 100644
> --- a/arch/x86/kernel/acpi/boot.c
> +++ b/arch/x86/kernel/acpi/boot.c
> @@ -1558,8 +1558,6 @@ void __init acpi_boot_table_init(void)
> return;
> }
>
> - acpi_table_parse(ACPI_SIG_BOOT, acpi_parse_sbf);
> -
> /*
> * blacklist may disable ACPI entirely
> */
> --
> 2.21.0
>
>
>
next prev parent reply other threads:[~2019-11-15 9:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-15 5:06 [RFC PATCH] x86/acpi: Drop duplicate BOOT table initialization Shiyang Ruan
2019-11-15 9:09 ` Rafael J. Wysocki [this message]
2019-11-15 9:18 ` Cao jin
2019-11-15 9:24 Shiyang Ruan
2019-11-29 11:11 ` Cao jin
2019-12-12 22:03 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJZ5v0jmQEKip=7530mTSzeY_bRSyJv_Y7B49AJuLiDaTjJqSQ@mail.gmail.com' \
--to=rafael@kernel.org \
--cc=bp@alien8.de \
--cc=caoj.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ruansy.fnst@cn.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).