From: Viresh Kumar <viresh.kumar@linaro.org>
To: Nicholas Krause <xerofoify@gmail.com>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers:cpufreq: Change policy->cpuinfo.transition_latency to correct value
Date: Thu, 27 Nov 2014 09:27:12 +0530 [thread overview]
Message-ID: <CAKohpokKJB9wHNQLpBNnmupLp-oLCgn2XgL_u__S-Bszy5vNKw@mail.gmail.com> (raw)
In-Reply-To: <1417038987-3164-1-git-send-email-xerofoify@gmail.com>
On 27 November 2014 at 03:26, Nicholas Krause <xerofoify@gmail.com> wrote:
> Changes policy->cpuinfo.transition_latency for 1000 to 1000000 nanoseconds
> as we are assuming the latency is 1 millisecond.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
> drivers/cpufreq/pxa3xx-cpufreq.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
> index e24269a..2b894aa 100644
> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
> init_sdram_rows();
>
> /* set default policy and cpuinfo */
> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
> + policy->cpuinfo.transition_latency = 1000000;
> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
> + policy->cpuinfo.transition_latency = 1000000;
I believe the FIXMEs are still valid and shouldn't be removed. As we are still
running under the assumption here instead of finding out how much is the
latency.
parent reply other threads:[~2014-11-27 3:57 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1417038987-3164-1-git-send-email-xerofoify@gmail.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKohpokKJB9wHNQLpBNnmupLp-oLCgn2XgL_u__S-Bszy5vNKw@mail.gmail.com \
--to=viresh.kumar@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).