* Re: [PATCH] drivers:cpufreq: Change policy->cpuinfo.transition_latency to correct value
[not found] <1417038987-3164-1-git-send-email-xerofoify@gmail.com>
@ 2014-11-27 3:57 ` Viresh Kumar
0 siblings, 0 replies; only message in thread
From: Viresh Kumar @ 2014-11-27 3:57 UTC (permalink / raw)
To: Nicholas Krause; +Cc: Rafael J. Wysocki, linux-pm, Linux Kernel Mailing List
On 27 November 2014 at 03:26, Nicholas Krause <xerofoify@gmail.com> wrote:
> Changes policy->cpuinfo.transition_latency for 1000 to 1000000 nanoseconds
> as we are assuming the latency is 1 millisecond.
>
> Signed-off-by: Nicholas Krause <xerofoify@gmail.com>
> ---
> drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
> drivers/cpufreq/pxa3xx-cpufreq.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
> index e24269a..2b894aa 100644
> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
> init_sdram_rows();
>
> /* set default policy and cpuinfo */
> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
> + policy->cpuinfo.transition_latency = 1000000;
> - policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
> + policy->cpuinfo.transition_latency = 1000000;
I believe the FIXMEs are still valid and shouldn't be removed. As we are still
running under the assumption here instead of finding out how much is the
latency.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-11-27 3:57 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1417038987-3164-1-git-send-email-xerofoify@gmail.com>
2014-11-27 3:57 ` [PATCH] drivers:cpufreq: Change policy->cpuinfo.transition_latency to correct value Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).