* [RFC PATCH linus] drivers: thermal: tsens: tsens_critical_irq_thread() can be static
[not found] <202006281417.GPpEXCGD%lkp@intel.com>
@ 2020-06-28 6:04 ` kernel test robot
2020-06-29 6:48 ` Amit Kucheria
0 siblings, 1 reply; 2+ messages in thread
From: kernel test robot @ 2020-06-28 6:04 UTC (permalink / raw)
To: Amit Kucheria
Cc: kbuild-all, linux-kernel, Daniel Lezcano, Bjorn Andersson,
Andy Gross, Zhang Rui, linux-pm, linux-arm-msm
Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into tsens.c")
Signed-off-by: kernel test robot <lkp@intel.com>
---
tsens.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
index 8d3e94d2a9ed4..39c4462e38f62 100644
--- a/drivers/thermal/qcom/tsens.c
+++ b/drivers/thermal/qcom/tsens.c
@@ -382,7 +382,7 @@ static inline u32 masked_irq(u32 hw_id, u32 mask, enum tsens_ver ver)
*
* Return: IRQ_HANDLED
*/
-irqreturn_t tsens_critical_irq_thread(int irq, void *data)
+static irqreturn_t tsens_critical_irq_thread(int irq, void *data)
{
struct tsens_priv *priv = data;
struct tsens_irq_data d;
@@ -452,7 +452,7 @@ irqreturn_t tsens_critical_irq_thread(int irq, void *data)
*
* Return: IRQ_HANDLED
*/
-irqreturn_t tsens_irq_thread(int irq, void *data)
+static irqreturn_t tsens_irq_thread(int irq, void *data)
{
struct tsens_priv *priv = data;
struct tsens_irq_data d;
@@ -520,7 +520,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
return IRQ_HANDLED;
}
-int tsens_set_trips(void *_sensor, int low, int high)
+static int tsens_set_trips(void *_sensor, int low, int high)
{
struct tsens_sensor *s = _sensor;
struct tsens_priv *priv = s->priv;
@@ -557,7 +557,7 @@ int tsens_set_trips(void *_sensor, int low, int high)
return 0;
}
-int tsens_enable_irq(struct tsens_priv *priv)
+static int tsens_enable_irq(struct tsens_priv *priv)
{
int ret;
int val = tsens_version(priv) > VER_1_X ? 7 : 1;
@@ -570,7 +570,7 @@ int tsens_enable_irq(struct tsens_priv *priv)
return ret;
}
-void tsens_disable_irq(struct tsens_priv *priv)
+static void tsens_disable_irq(struct tsens_priv *priv)
{
regmap_field_write(priv->rf[INT_EN], 0);
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [RFC PATCH linus] drivers: thermal: tsens: tsens_critical_irq_thread() can be static
2020-06-28 6:04 ` [RFC PATCH linus] drivers: thermal: tsens: tsens_critical_irq_thread() can be static kernel test robot
@ 2020-06-29 6:48 ` Amit Kucheria
0 siblings, 0 replies; 2+ messages in thread
From: Amit Kucheria @ 2020-06-29 6:48 UTC (permalink / raw)
To: kernel test robot
Cc: kbuild-all, Linux Kernel Mailing List, Daniel Lezcano,
Bjorn Andersson, Andy Gross, Zhang Rui, Linux PM list,
linux-arm-msm
Hi,
A patch to fix this was already submitted on 27th May.
I believe Daniel plans to send it as fixes for -rc4.
Regards,
Amit
On Sun, Jun 28, 2020 at 11:34 AM kernel test robot <lkp@intel.com> wrote:
>
>
> Fixes: a7ff82976122 ("drivers: thermal: tsens: Merge tsens-common.c into tsens.c")
> Signed-off-by: kernel test robot <lkp@intel.com>
> ---
> tsens.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c
> index 8d3e94d2a9ed4..39c4462e38f62 100644
> --- a/drivers/thermal/qcom/tsens.c
> +++ b/drivers/thermal/qcom/tsens.c
> @@ -382,7 +382,7 @@ static inline u32 masked_irq(u32 hw_id, u32 mask, enum tsens_ver ver)
> *
> * Return: IRQ_HANDLED
> */
> -irqreturn_t tsens_critical_irq_thread(int irq, void *data)
> +static irqreturn_t tsens_critical_irq_thread(int irq, void *data)
> {
> struct tsens_priv *priv = data;
> struct tsens_irq_data d;
> @@ -452,7 +452,7 @@ irqreturn_t tsens_critical_irq_thread(int irq, void *data)
> *
> * Return: IRQ_HANDLED
> */
> -irqreturn_t tsens_irq_thread(int irq, void *data)
> +static irqreturn_t tsens_irq_thread(int irq, void *data)
> {
> struct tsens_priv *priv = data;
> struct tsens_irq_data d;
> @@ -520,7 +520,7 @@ irqreturn_t tsens_irq_thread(int irq, void *data)
> return IRQ_HANDLED;
> }
>
> -int tsens_set_trips(void *_sensor, int low, int high)
> +static int tsens_set_trips(void *_sensor, int low, int high)
> {
> struct tsens_sensor *s = _sensor;
> struct tsens_priv *priv = s->priv;
> @@ -557,7 +557,7 @@ int tsens_set_trips(void *_sensor, int low, int high)
> return 0;
> }
>
> -int tsens_enable_irq(struct tsens_priv *priv)
> +static int tsens_enable_irq(struct tsens_priv *priv)
> {
> int ret;
> int val = tsens_version(priv) > VER_1_X ? 7 : 1;
> @@ -570,7 +570,7 @@ int tsens_enable_irq(struct tsens_priv *priv)
> return ret;
> }
>
> -void tsens_disable_irq(struct tsens_priv *priv)
> +static void tsens_disable_irq(struct tsens_priv *priv)
> {
> regmap_field_write(priv->rf[INT_EN], 0);
> }
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-29 20:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <202006281417.GPpEXCGD%lkp@intel.com>
2020-06-28 6:04 ` [RFC PATCH linus] drivers: thermal: tsens: tsens_critical_irq_thread() can be static kernel test robot
2020-06-29 6:48 ` Amit Kucheria
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).