* [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release and acquire
@ 2022-07-09 14:19 Perry Yuan
2022-07-11 0:39 ` Viresh Kumar
0 siblings, 1 reply; 5+ messages in thread
From: Perry Yuan @ 2022-07-09 14:19 UTC (permalink / raw)
To: rafael.j.wysocki, viresh.kumar, Ray.Huang
Cc: Deepak.Sharma, Mario.Limonciello, Nathan.Fontenot,
Alexander.Deucher, Jinzhou.Su, Xinmei.Huang, Xiaojian.Du,
Li.Meng, linux-pm, linux-kernel, Perry Yuan
"cpufreq_cpu_release" and "cpufreq_cpu_acquire" are only used internally by
drivers/cpufreq/cpufreq.c currently.
Export them so that other drivers such as the AMD P-state driver can use them as well.
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
---
drivers/cpufreq/cpufreq.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 73432360e6e9..4d3c83da29b7 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -262,6 +262,7 @@ void cpufreq_cpu_release(struct cpufreq_policy *policy)
cpufreq_cpu_put(policy);
}
+EXPORT_SYMBOL_GPL(cpufreq_cpu_release);
/**
* cpufreq_cpu_acquire - Find policy for a CPU, mark it as busy and lock it.
@@ -291,6 +292,7 @@ struct cpufreq_policy *cpufreq_cpu_acquire(unsigned int cpu)
return policy;
}
+EXPORT_SYMBOL_GPL(cpufreq_cpu_acquire);
/*********************************************************************
* EXTERNALLY AFFECTING FREQUENCY CHANGES *
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release and acquire
2022-07-09 14:19 [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release and acquire Perry Yuan
@ 2022-07-11 0:39 ` Viresh Kumar
2022-07-11 1:39 ` Yuan, Perry
0 siblings, 1 reply; 5+ messages in thread
From: Viresh Kumar @ 2022-07-11 0:39 UTC (permalink / raw)
To: Perry Yuan
Cc: rafael.j.wysocki, Ray.Huang, Deepak.Sharma, Mario.Limonciello,
Nathan.Fontenot, Alexander.Deucher, Jinzhou.Su, Xinmei.Huang,
Xiaojian.Du, Li.Meng, linux-pm, linux-kernel
On 09-07-22, 10:19, Perry Yuan wrote:
> "cpufreq_cpu_release" and "cpufreq_cpu_acquire" are only used internally by
> drivers/cpufreq/cpufreq.c currently.
> Export them so that other drivers such as the AMD P-state driver can use them as well.
I don't see your driver using them, what am I missing ?
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release and acquire
2022-07-11 0:39 ` Viresh Kumar
@ 2022-07-11 1:39 ` Yuan, Perry
2022-07-11 1:40 ` Viresh Kumar
0 siblings, 1 reply; 5+ messages in thread
From: Yuan, Perry @ 2022-07-11 1:39 UTC (permalink / raw)
To: Viresh Kumar
Cc: rafael.j.wysocki, Huang, Ray, Sharma, Deepak, Limonciello, Mario,
Fontenot, Nathan, Deucher, Alexander, Su, Jinzhou (Joe),
Huang, Shimmer, Du, Xiaojian, Meng, Li (Jassmine),
linux-pm, linux-kernel
[AMD Official Use Only - General]
Hi Viresh:
> -----Original Message-----
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Sent: Monday, July 11, 2022 8:40 AM
> To: Yuan, Perry <Perry.Yuan@amd.com>
> Cc: rafael.j.wysocki@intel.com; Huang, Ray <Ray.Huang@amd.com>;
> Sharma, Deepak <Deepak.Sharma@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Fontenot, Nathan
> <Nathan.Fontenot@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>;
> Huang, Shimmer <Shimmer.Huang@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release
> and acquire
>
> [CAUTION: External Email]
>
> On 09-07-22, 10:19, Perry Yuan wrote:
> > "cpufreq_cpu_release" and "cpufreq_cpu_acquire" are only used
> > internally by drivers/cpufreq/cpufreq.c currently.
> > Export them so that other drivers such as the AMD P-state driver can use
> them as well.
>
> I don't see your driver using them, what am I missing ?
>
> --
> viresh
The amd-pstate for EPP mode is under testing, I will push that patchset in a few days for reviewing.
If this patch makes confusing, maybe I need to move this patch to coming patchset.
Perry.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release and acquire
2022-07-11 1:39 ` Yuan, Perry
@ 2022-07-11 1:40 ` Viresh Kumar
2022-07-11 1:44 ` Yuan, Perry
0 siblings, 1 reply; 5+ messages in thread
From: Viresh Kumar @ 2022-07-11 1:40 UTC (permalink / raw)
To: Yuan, Perry
Cc: rafael.j.wysocki, Huang, Ray, Sharma, Deepak, Limonciello, Mario,
Fontenot, Nathan, Deucher, Alexander, Su, Jinzhou (Joe),
Huang, Shimmer, Du, Xiaojian, Meng, Li (Jassmine),
linux-pm, linux-kernel
On 11-07-22, 01:39, Yuan, Perry wrote:
> The amd-pstate for EPP mode is under testing, I will push that patchset in a few days for reviewing.
> If this patch makes confusing, maybe I need to move this patch to coming patchset.
Yeah, it should come with users and not like this.
--
viresh
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release and acquire
2022-07-11 1:40 ` Viresh Kumar
@ 2022-07-11 1:44 ` Yuan, Perry
0 siblings, 0 replies; 5+ messages in thread
From: Yuan, Perry @ 2022-07-11 1:44 UTC (permalink / raw)
To: Viresh Kumar
Cc: rafael.j.wysocki, Huang, Ray, Sharma, Deepak, Limonciello, Mario,
Fontenot, Nathan, Deucher, Alexander, Su, Jinzhou (Joe),
Huang, Shimmer, Du, Xiaojian, Meng, Li (Jassmine),
linux-pm, linux-kernel
[AMD Official Use Only - General]
Hi Viresh,
> -----Original Message-----
> From: Viresh Kumar <viresh.kumar@linaro.org>
> Sent: Monday, July 11, 2022 9:40 AM
> To: Yuan, Perry <Perry.Yuan@amd.com>
> Cc: rafael.j.wysocki@intel.com; Huang, Ray <Ray.Huang@amd.com>;
> Sharma, Deepak <Deepak.Sharma@amd.com>; Limonciello, Mario
> <Mario.Limonciello@amd.com>; Fontenot, Nathan
> <Nathan.Fontenot@amd.com>; Deucher, Alexander
> <Alexander.Deucher@amd.com>; Su, Jinzhou (Joe) <Jinzhou.Su@amd.com>;
> Huang, Shimmer <Shimmer.Huang@amd.com>; Du, Xiaojian
> <Xiaojian.Du@amd.com>; Meng, Li (Jassmine) <Li.Meng@amd.com>; linux-
> pm@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release
> and acquire
>
> [CAUTION: External Email]
>
> On 11-07-22, 01:39, Yuan, Perry wrote:
> > The amd-pstate for EPP mode is under testing, I will push that patchset in
> a few days for reviewing.
> > If this patch makes confusing, maybe I need to move this patch to coming
> patchset.
>
> Yeah, it should come with users and not like this.
>
> --
> viresh
Thanks a lot for your feedback
Will remove this patch from current patchset in V3.
Perry.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-07-11 1:44 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-09 14:19 [PATCH v2 10/14] cpufreq: cpufreq: export cpufreq cpu release and acquire Perry Yuan
2022-07-11 0:39 ` Viresh Kumar
2022-07-11 1:39 ` Yuan, Perry
2022-07-11 1:40 ` Viresh Kumar
2022-07-11 1:44 ` Yuan, Perry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).