From: "Pandruvada, Srinivas" <srinivas.pandruvada@intel.com>
To: "Zhang, Rui" <rui.zhang@intel.com>,
"daniel.lezcano@linaro.org" <daniel.lezcano@linaro.org>,
"tiwai@suse.de" <tiwai@suse.de>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: [PATCH] thermal: int340x_thermal: Use scnprintf() for avoiding potential buffer overflow
Date: Thu, 19 Mar 2020 16:05:34 +0000 [thread overview]
Message-ID: <d35022db86c4abd69bb1a2c3a0c8a25e35b69258.camel@intel.com> (raw)
In-Reply-To: <s5hfte4uyx1.wl-tiwai@suse.de>
On Thu, 2020-03-19 at 16:50 +0100, Takashi Iwai wrote:
> On Wed, 11 Mar 2020 10:27:18 +0100,
> Takashi Iwai wrote:
> > Since snprintf() returns the would-be-output size instead of the
> > actual output size, the succeeding calls may go beyond the given
> > buffer limit. Fix it by replacing with scnprintf().
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
Reviewed-by: Pandruvada, Srinivas <srinivas.pandruvada@linux.intel.com>
> A gentle reminder for this forgotten patch.
> Let me know if any further change is needed.
>
>
> thanks,
>
> Takashi
>
> > ---
> > drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> > b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> > index efae0c02d898..529df7174239 100644
> > --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> > +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> > @@ -65,7 +65,7 @@ static ssize_t available_uuids_show(struct device
> > *dev,
> > for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; i++) {
> > if (priv->uuid_bitmap & (1 << i))
> > if (PAGE_SIZE - length > 0)
> > - length += snprintf(&buf[length],
> > + length += scnprintf(&buf[length],
> > PAGE_SIZE - length,
> > "%s\n",
> > int3400_thermal_uuid
> > s[i]);
> > --
> > 2.16.4
> >
prev parent reply other threads:[~2020-03-19 16:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-11 9:27 [PATCH] thermal: int340x_thermal: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-19 15:50 ` Takashi Iwai
2020-03-19 16:05 ` Pandruvada, Srinivas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d35022db86c4abd69bb1a2c3a0c8a25e35b69258.camel@intel.com \
--to=srinivas.pandruvada@intel.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).