* [PATCH] thermal: int340x_thermal: Use scnprintf() for avoiding potential buffer overflow
@ 2020-03-11 9:27 Takashi Iwai
2020-03-19 15:50 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2020-03-11 9:27 UTC (permalink / raw)
To: Zhang Rui, Daniel Lezcano; +Cc: linux-pm
Since snprintf() returns the would-be-output size instead of the
actual output size, the succeeding calls may go beyond the given
buffer limit. Fix it by replacing with scnprintf().
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
index efae0c02d898..529df7174239 100644
--- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
+++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
@@ -65,7 +65,7 @@ static ssize_t available_uuids_show(struct device *dev,
for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; i++) {
if (priv->uuid_bitmap & (1 << i))
if (PAGE_SIZE - length > 0)
- length += snprintf(&buf[length],
+ length += scnprintf(&buf[length],
PAGE_SIZE - length,
"%s\n",
int3400_thermal_uuids[i]);
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] thermal: int340x_thermal: Use scnprintf() for avoiding potential buffer overflow
2020-03-11 9:27 [PATCH] thermal: int340x_thermal: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
@ 2020-03-19 15:50 ` Takashi Iwai
2020-03-19 16:05 ` Pandruvada, Srinivas
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2020-03-19 15:50 UTC (permalink / raw)
To: Zhang Rui, Daniel Lezcano; +Cc: linux-pm
On Wed, 11 Mar 2020 10:27:18 +0100,
Takashi Iwai wrote:
>
> Since snprintf() returns the would-be-output size instead of the
> actual output size, the succeeding calls may go beyond the given
> buffer limit. Fix it by replacing with scnprintf().
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
A gentle reminder for this forgotten patch.
Let me know if any further change is needed.
thanks,
Takashi
> ---
> drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> index efae0c02d898..529df7174239 100644
> --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> @@ -65,7 +65,7 @@ static ssize_t available_uuids_show(struct device *dev,
> for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; i++) {
> if (priv->uuid_bitmap & (1 << i))
> if (PAGE_SIZE - length > 0)
> - length += snprintf(&buf[length],
> + length += scnprintf(&buf[length],
> PAGE_SIZE - length,
> "%s\n",
> int3400_thermal_uuids[i]);
> --
> 2.16.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] thermal: int340x_thermal: Use scnprintf() for avoiding potential buffer overflow
2020-03-19 15:50 ` Takashi Iwai
@ 2020-03-19 16:05 ` Pandruvada, Srinivas
0 siblings, 0 replies; 3+ messages in thread
From: Pandruvada, Srinivas @ 2020-03-19 16:05 UTC (permalink / raw)
To: Zhang, Rui, daniel.lezcano, tiwai; +Cc: linux-pm
On Thu, 2020-03-19 at 16:50 +0100, Takashi Iwai wrote:
> On Wed, 11 Mar 2020 10:27:18 +0100,
> Takashi Iwai wrote:
> > Since snprintf() returns the would-be-output size instead of the
> > actual output size, the succeeding calls may go beyond the given
> > buffer limit. Fix it by replacing with scnprintf().
> >
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
>
Reviewed-by: Pandruvada, Srinivas <srinivas.pandruvada@linux.intel.com>
> A gentle reminder for this forgotten patch.
> Let me know if any further change is needed.
>
>
> thanks,
>
> Takashi
>
> > ---
> > drivers/thermal/intel/int340x_thermal/int3400_thermal.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> > b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> > index efae0c02d898..529df7174239 100644
> > --- a/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> > +++ b/drivers/thermal/intel/int340x_thermal/int3400_thermal.c
> > @@ -65,7 +65,7 @@ static ssize_t available_uuids_show(struct device
> > *dev,
> > for (i = 0; i < INT3400_THERMAL_MAXIMUM_UUID; i++) {
> > if (priv->uuid_bitmap & (1 << i))
> > if (PAGE_SIZE - length > 0)
> > - length += snprintf(&buf[length],
> > + length += scnprintf(&buf[length],
> > PAGE_SIZE - length,
> > "%s\n",
> > int3400_thermal_uuid
> > s[i]);
> > --
> > 2.16.4
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-19 16:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-11 9:27 [PATCH] thermal: int340x_thermal: Use scnprintf() for avoiding potential buffer overflow Takashi Iwai
2020-03-19 15:50 ` Takashi Iwai
2020-03-19 16:05 ` Pandruvada, Srinivas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).