From: Sumit Gupta <sumitg@nvidia.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <rjw@rjwysocki.net>, <catalin.marinas@arm.com>, <will@kernel.org>,
<thierry.reding@gmail.com>, <jonathanh@nvidia.com>,
<talho@nvidia.com>, <linux-pm@vger.kernel.org>,
<linux-tegra@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <bbasu@nvidia.com>,
<mperttunen@nvidia.com>
Subject: Re: [TEGRA194_CPUFREQ Patch 2/3] cpufreq: Add Tegra194 cpufreq driver
Date: Wed, 15 Apr 2020 16:55:53 +0530 [thread overview]
Message-ID: <d6e0eed6-4267-fca9-59e1-02d16e17ff34@nvidia.com> (raw)
In-Reply-To: <20200414054504.e3qn2cnxqur4sclw@vireshk-i7>
On 14/04/20 11:15 AM, Viresh Kumar wrote:
> External email: Use caution opening links or attachments
>
>
> On 13-04-20, 17:50, Sumit Gupta wrote:
>> This was done considering long delay value as explained previously.
>> Do you think that smp_call_function_single() would be better than work queue
>> here?
>
> Don't work with assumptions, you should test both and see which one
> works better. Workqueue should never be faster than
> smp_call_function_single() with my understanding.
Checked the time taken and its almost same in both cases.
Earlier we used smp_call_function_single(), but delay time period was
small in that SOC. In T194, the time period was more. So, this is an
optimization done because using work queue has advantage as interrupts
will not be disabled for that period.
If you think work queue is not required, then can remove it. The
functionality works fine in both cases.
>
> --
> viresh
>
next prev parent reply other threads:[~2020-04-15 11:25 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 17:32 [TEGRA194_CPUFREQ Patch 1/3] firmware: tegra: adding function to get BPMP data Sumit Gupta
2019-12-03 17:32 ` [TEGRA194_CPUFREQ Patch 2/3] cpufreq: Add Tegra194 cpufreq driver Sumit Gupta
2019-12-04 5:40 ` Viresh Kumar
2019-12-04 10:55 ` sumitg
2019-12-04 11:27 ` Viresh Kumar
2019-12-04 13:57 ` Dmitry Osipenko
2019-12-05 2:51 ` Viresh Kumar
2019-12-05 12:55 ` Dmitry Osipenko
2020-03-25 23:59 ` sumitg
2019-12-04 13:59 ` Dmitry Osipenko
2019-12-05 14:15 ` Dmitry Osipenko
2020-03-26 11:50 ` Viresh Kumar
2020-04-04 18:38 ` sumitg
2020-04-06 2:55 ` Viresh Kumar
2020-04-07 18:18 ` sumitg
2020-04-08 5:53 ` Viresh Kumar
2020-04-08 11:24 ` sumitg
2020-04-09 7:44 ` Viresh Kumar
2020-04-09 11:21 ` Sumit Gupta
2020-04-13 6:21 ` Viresh Kumar
2020-04-13 12:20 ` Sumit Gupta
2020-04-14 5:45 ` Viresh Kumar
2020-04-15 11:25 ` Sumit Gupta [this message]
2020-04-16 3:37 ` Viresh Kumar
2020-04-16 7:06 ` Sumit Gupta
2019-12-03 17:32 ` [TEGRA194_CPUFREQ Patch 3/3] arm64: defconfig: Enable CONFIG_ARM_TEGRA194_CPUFREQ Sumit Gupta
2019-12-03 17:42 ` [TEGRA194_CPUFREQ Patch 1/3] firmware: tegra: adding function to get BPMP data Thierry Reding
2019-12-04 8:45 ` Mikko Perttunen
2019-12-04 9:17 ` Viresh Kumar
2019-12-04 9:33 ` Thierry Reding
2019-12-04 9:51 ` Viresh Kumar
2020-04-07 10:05 ` Thierry Reding
2020-04-27 7:18 ` Thierry Reding
2020-04-29 8:21 ` Sumit Gupta
2020-05-06 16:58 ` Thierry Reding
2020-05-20 14:43 ` Rob Herring
2020-05-20 15:38 ` Thierry Reding
2020-05-20 16:21 ` Rob Herring
2019-12-04 10:21 ` Mikko Perttunen
2019-12-04 10:26 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6e0eed6-4267-fca9-59e1-02d16e17ff34@nvidia.com \
--to=sumitg@nvidia.com \
--cc=bbasu@nvidia.com \
--cc=catalin.marinas@arm.com \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mperttunen@nvidia.com \
--cc=rjw@rjwysocki.net \
--cc=talho@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=viresh.kumar@linaro.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).