From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: YueHaibing <yuehaibing@huawei.com>,
rui.zhang@intel.com, edubezval@gmail.com,
amit.kucheria@verdurent.com, qperret@google.com,
viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 -next] thermal: power_allocator: Fix Kconfig warning
Date: Wed, 4 Dec 2019 16:49:53 +0100 [thread overview]
Message-ID: <f89d6a79-2ac6-0bea-f2a0-bd376835e785@linaro.org> (raw)
In-Reply-To: <20191113105313.41616-1-yuehaibing@huawei.com>
On 13/11/2019 11:53, YueHaibing wrote:
> When do randbuiding, we got this:
>
> WARNING: unmet direct dependencies detected for THERMAL_GOV_POWER_ALLOCATOR
> Depends on [n]: THERMAL [=y] && ENERGY_MODEL [=n]
> Selected by [y]:
> - THERMAL_DEFAULT_GOV_POWER_ALLOCATOR [=y] && <choice>
>
> Make THERMAL_DEFAULT_GOV_POWER_ALLOCATOR depend on
> THERMAL_DEFAULT_GOV_POWER_ALLOCATOR to fix this warning.
>
> Suggested-by: Quentin Perret <qperret@google.com>
> Fixes: a4e893e802e6 ("thermal: cpu_cooling: Migrate to using the EM framework")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied with a slight message clarification.
Thanks for the fix.
> ---
> drivers/thermal/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/thermal/Kconfig b/drivers/thermal/Kconfig
> index 59b79fc..79b2786 100644
> --- a/drivers/thermal/Kconfig
> +++ b/drivers/thermal/Kconfig
> @@ -108,7 +108,7 @@ config THERMAL_DEFAULT_GOV_USER_SPACE
>
> config THERMAL_DEFAULT_GOV_POWER_ALLOCATOR
> bool "power_allocator"
> - select THERMAL_GOV_POWER_ALLOCATOR
> + depends on THERMAL_GOV_POWER_ALLOCATOR
> help
> Select this if you want to control temperature based on
> system and device power allocation. This governor can only
>
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
prev parent reply other threads:[~2019-12-04 15:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-12 14:51 [PATCH -next] thermal: power_allocator: Fix Kconfig warning YueHaibing
2019-11-12 15:13 ` Quentin Perret
2019-11-12 15:28 ` Quentin Perret
2019-11-13 10:53 ` [PATCH v2 " YueHaibing
2019-12-04 15:49 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f89d6a79-2ac6-0bea-f2a0-bd376835e785@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amit.kucheria@verdurent.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=qperret@google.com \
--cc=rui.zhang@intel.com \
--cc=viresh.kumar@linaro.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).