From: James Carlson <carlsonj@workingcode.com>
To: linux-ppp@vger.kernel.org
Subject: Re: [bug report] ppp: fix 'ppp_mp_reconstruct bad seq' errors
Date: Sat, 31 Jul 2021 18:36:03 +0000 [thread overview]
Message-ID: <f2558693-c7e4-8a70-94f0-09119b146e1c@workingcode.com> (raw)
In-Reply-To: <20210729141617.GC1267@kili>
On 7/30/21 1:15 PM, James Carlson wrote:
> On 7/30/21 4:48 AM, Dan Carpenter wrote:
>>> --> 2840 ppp->nextseq = PPP_MP_CB(tail)->sequence + 1;
>>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>>
>> Here is where Smatch complains.
>
> If that's Smatch's analysis of the situation, then Smatch is wrong.
> It's a bogus warning.
For what it's worth, it's not my code, and I agree that it's at least a
bit hard to follow, and may well harbor bugs. If you're suggesting
either some kind of suppression directive (I tried looking for some
Smatch documentation but couldn't find much to suggest that's possible,
though I guess now that you'd be the one who knows for sure), or adding
something like "u32 nextseq = PPP_CB(tail)->sequence + 1;" around line
2795, and then using "ppp->nextseq = nextseq;" on 2840, then I'd be in
favor of that, at least to make the tool happy.
Is there an equivalent of "/* LINTED: tail pointer still ok */" here?
--
James Carlson 42.703N 71.076W <carlsonj@workingcode.com>
next prev parent reply other threads:[~2021-07-31 18:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-29 14:16 [bug report] ppp: fix 'ppp_mp_reconstruct bad seq' errors Dan Carpenter
2021-07-29 21:08 ` James Carlson
2021-07-30 8:48 ` Dan Carpenter
2021-07-30 17:15 ` James Carlson
2021-07-31 18:36 ` James Carlson [this message]
2021-08-02 11:43 ` Dan Carpenter
2021-08-02 12:37 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2558693-c7e4-8a70-94f0-09119b146e1c@workingcode.com \
--to=carlsonj@workingcode.com \
--cc=linux-ppp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).