From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: thierry.reding@gmail.com
Cc: u.kleine-koenig@pengutronix.de, matthias.bgg@gmail.com,
weiqing.kong@mediatek.com, jitao.shi@mediatek.com,
linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot
Date: Wed, 8 Mar 2023 12:46:07 +0100 [thread overview]
Message-ID: <06909bd8-3da2-1cf0-82ac-3ed4f3e63def@collabora.com> (raw)
In-Reply-To: <06918fde-64ea-37b2-da1a-1c8316457223@collabora.com>
Il 23/02/23 15:16, AngeloGioacchino Del Regno ha scritto:
> Il 23/01/23 17:06, AngeloGioacchino Del Regno ha scritto:
>> Since the pwm-mtk-disp driver was fixed to get PWM_EN state from the
>> right register, an old two-wrongs-make-one-right issue emerged: as a
>> result, MT8192 Asurada Spherion got no backlight at boot unless a
>> suspend/resume cycle was performed.
>> Also, the backlight would sometimes not get updated with the requested
>> value, requiring the user to change it back and forth until it worked.
>>
>> This series fixes both of the aforementioned issues found on MT8192.
>>
>> AngeloGioacchino Del Regno (2):
>> pwm: mtk-disp: Disable shadow registers before setting backlight
>> values
>> pwm: mtk-disp: Configure double buffering before reading in
>> .get_state()
>>
>> drivers/pwm/pwm-mtk-disp.c | 34 +++++++++++++++++++++++-----------
>> 1 file changed, 23 insertions(+), 11 deletions(-)
>>
>
> Gentle ping for this one: this is fixing backlight issues on multiple MediaTek
> SoCs and was well tested.
>
> Thanks,
> Angelo
Since this series was sent more than one month ago, and since this fixes broken
backlight on a number of Chromebooks with MT8183 and MT8192 SoCs, and seen the
urgency of getting these fixes in, I'm adding Greg to the loop.
Regards,
Angelo
next prev parent reply other threads:[~2023-03-08 11:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 16:06 [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot AngeloGioacchino Del Regno
2023-01-23 16:06 ` [PATCH 1/2] pwm: mtk-disp: Disable shadow registers before setting backlight values AngeloGioacchino Del Regno
2023-01-26 15:06 ` Nícolas F. R. A. Prado
2023-01-26 15:20 ` AngeloGioacchino Del Regno
2023-01-23 16:06 ` [PATCH 2/2] pwm: mtk-disp: Configure double buffering before reading in .get_state() AngeloGioacchino Del Regno
2023-01-26 15:19 ` Nícolas F. R. A. Prado
2023-01-26 15:24 ` AngeloGioacchino Del Regno
2023-01-26 16:09 ` Nícolas F. R. A. Prado
2023-01-26 16:16 ` AngeloGioacchino Del Regno
2023-01-26 15:31 ` [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot Adrian Ratiu
2023-02-23 14:16 ` AngeloGioacchino Del Regno
2023-03-08 11:46 ` AngeloGioacchino Del Regno [this message]
2023-03-08 14:50 ` Greg Kroah-Hartman
2023-03-08 14:55 ` AngeloGioacchino Del Regno
2023-03-08 15:43 ` Greg Kroah-Hartman
2023-03-08 16:04 ` AngeloGioacchino Del Regno
2023-03-08 16:07 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=06909bd8-3da2-1cf0-82ac-3ed4f3e63def@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=gregkh@linuxfoundation.org \
--cc=jitao.shi@mediatek.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=weiqing.kong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).