From: "Nícolas F. R. A. Prado" <nfraprado@collabora.com>
To: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de,
matthias.bgg@gmail.com, weiqing.kong@mediatek.com,
jitao.shi@mediatek.com, linux-pwm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel@collabora.com
Subject: Re: [PATCH 1/2] pwm: mtk-disp: Disable shadow registers before setting backlight values
Date: Thu, 26 Jan 2023 10:06:50 -0500 [thread overview]
Message-ID: <20230126150203.dnsbw2l2fzyg3oi5@notapiano> (raw)
In-Reply-To: <20230123160615.375969-2-angelogioacchino.delregno@collabora.com>
On Mon, Jan 23, 2023 at 05:06:14PM +0100, AngeloGioacchino Del Regno wrote:
> If shadow registers usage is not desired, disable that before performing
> any write to CON0/1 registers in the .apply() callback, otherwise we may
> lose clkdiv or period/width updates.
>
> Fixes: cd4b45ac449a ("pwm: Add MediaTek MT2701 display PWM driver support")
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
> ---
> drivers/pwm/pwm-mtk-disp.c | 24 +++++++++++++-----------
> 1 file changed, 13 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/pwm/pwm-mtk-disp.c b/drivers/pwm/pwm-mtk-disp.c
> index 692a06121b28..82b430d881a2 100644
> --- a/drivers/pwm/pwm-mtk-disp.c
> +++ b/drivers/pwm/pwm-mtk-disp.c
> @@ -138,6 +138,19 @@ static int mtk_disp_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> high_width = mul_u64_u64_div_u64(state->duty_cycle, rate, div);
> value = period | (high_width << PWM_HIGH_WIDTH_SHIFT);
>
> + if (mdp->data->bls_debug && !mdp->data->has_commit) {
> + /*
> + * For MT2701, disable double buffer before writing register
Not necessarily part of this series, but I guess it would make sense to remove
the "For MT2701". It's no longer exclusive to that SoC and the condition in the
if above makes it clear when this happens.
Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Tested-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
On MT8192 Asurada Spherion.
Thanks,
Nícolas
> + * and select manual mode and use PWM_PERIOD/PWM_HIGH_WIDTH.
> + */
> + mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
> + mdp->data->bls_debug_mask,
> + mdp->data->bls_debug_mask);
> + mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
> + mdp->data->con0_sel,
> + mdp->data->con0_sel);
> + }
> +
> mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
> PWM_CLKDIV_MASK,
> clk_div << PWM_CLKDIV_SHIFT);
> @@ -152,17 +165,6 @@ static int mtk_disp_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
> mtk_disp_pwm_update_bits(mdp, mdp->data->commit,
> mdp->data->commit_mask,
> 0x0);
> - } else {
> - /*
> - * For MT2701, disable double buffer before writing register
> - * and select manual mode and use PWM_PERIOD/PWM_HIGH_WIDTH.
> - */
> - mtk_disp_pwm_update_bits(mdp, mdp->data->bls_debug,
> - mdp->data->bls_debug_mask,
> - mdp->data->bls_debug_mask);
> - mtk_disp_pwm_update_bits(mdp, mdp->data->con0,
> - mdp->data->con0_sel,
> - mdp->data->con0_sel);
> }
>
> mtk_disp_pwm_update_bits(mdp, DISP_PWM_EN, mdp->data->enable_mask,
> --
> 2.39.0
>
>
next prev parent reply other threads:[~2023-01-26 15:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-23 16:06 [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot AngeloGioacchino Del Regno
2023-01-23 16:06 ` [PATCH 1/2] pwm: mtk-disp: Disable shadow registers before setting backlight values AngeloGioacchino Del Regno
2023-01-26 15:06 ` Nícolas F. R. A. Prado [this message]
2023-01-26 15:20 ` AngeloGioacchino Del Regno
2023-01-23 16:06 ` [PATCH 2/2] pwm: mtk-disp: Configure double buffering before reading in .get_state() AngeloGioacchino Del Regno
2023-01-26 15:19 ` Nícolas F. R. A. Prado
2023-01-26 15:24 ` AngeloGioacchino Del Regno
2023-01-26 16:09 ` Nícolas F. R. A. Prado
2023-01-26 16:16 ` AngeloGioacchino Del Regno
2023-01-26 15:31 ` [PATCH 0/2] pwm: mtk-disp: Fix backlight configuration at boot Adrian Ratiu
2023-02-23 14:16 ` AngeloGioacchino Del Regno
2023-03-08 11:46 ` AngeloGioacchino Del Regno
2023-03-08 14:50 ` Greg Kroah-Hartman
2023-03-08 14:55 ` AngeloGioacchino Del Regno
2023-03-08 15:43 ` Greg Kroah-Hartman
2023-03-08 16:04 ` AngeloGioacchino Del Regno
2023-03-08 16:07 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126150203.dnsbw2l2fzyg3oi5@notapiano \
--to=nfraprado@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=jitao.shi@mediatek.com \
--cc=kernel@collabora.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pwm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=weiqing.kong@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).