From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Michael Walle <michael@walle.cc>,
linux-pwm@vger.kernel.org, Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller
Date: Mon, 27 Jul 2020 10:48:26 +0200 [thread overview]
Message-ID: <20200727084826.vwnnvdzi2ldpgvcg@pengutronix.de> (raw)
In-Reply-To: <20200727073027.GA2781612@ulmo>
[-- Attachment #1: Type: text/plain, Size: 1580 bytes --]
[stripping recipents as most probably won't be interested in this]
Hello Thierry,
On Mon, Jul 27, 2020 at 09:30:27AM +0200, Thierry Reding wrote:
> On Sun, Jul 26, 2020 at 01:18:27AM +0200, Michael Walle wrote:
> > + /* Polarity inversion is not supported */
> > + if (state->polarity != PWM_POLARITY_NORMAL)
> > + return -EINVAL;
>
> Just a note to myself since this just occurred to me: in the legacy API
> we used to have a ->set_polarity() callback that indicated whether or
> not a controller supports inversion. Since that criterion can no longer
> be used with the atomic API we may want to consider adding some sort of
> capability flags so that these checks can be performed in the core.
I'm not (yet?) convinced this is a good idea because these concepts are
somewhat blurry. For example a controller that only supports normal
polarity (probably) still can generate the wave corresponding to:
.enabled = true,
.polarity = PWM_POLARITY_INVERSED,
.duty_cycle = 0,
.period = 5000,
and unless we refuse this request at the core level (should we?) the
driver must be aware of .polarity anyhow. Ditto for .enabled = false.
> Looks good to me. I assume Lee will want to merge this along with the
> other changes through the MFD tree? If so:
I'd like to have another go through the patch. Will do so (hopefully)
later today. So please don't apply yet.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-07-27 8:48 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-25 23:18 [PATCH v6 00/13] Add support for Kontron sl28cpld Michael Walle
2020-07-25 23:18 ` [PATCH v6 01/13] mfd: add simple regmap based I2C driver Michael Walle
2020-07-28 7:19 ` Lee Jones
2020-07-28 7:42 ` Michael Walle
2020-07-28 8:15 ` Lee Jones
2020-07-28 8:27 ` Michael Walle
2020-07-28 8:35 ` Lee Jones
2020-07-25 23:18 ` [PATCH v6 02/13] dt-bindings: mfd: Add bindings for sl28cpld Michael Walle
2020-07-28 7:24 ` Lee Jones
2020-07-28 7:57 ` Michael Walle
2020-07-28 8:27 ` Lee Jones
2020-07-28 8:38 ` Michael Walle
2020-07-28 8:56 ` Lee Jones
2020-07-28 9:06 ` Michael Walle
2020-07-28 9:20 ` Lee Jones
2020-07-28 9:39 ` Michael Walle
2020-07-25 23:18 ` [PATCH v6 03/13] mfd: simple-mfd-i2c: add sl28cpld support Michael Walle
2020-07-28 7:25 ` Lee Jones
2020-07-25 23:18 ` [PATCH v6 04/13] irqchip: add sl28cpld interrupt controller support Michael Walle
2020-07-25 23:18 ` [PATCH v6 05/13] watchdog: add support for sl28cpld watchdog Michael Walle
2020-07-25 23:18 ` [PATCH v6 06/13] pwm: add support for sl28cpld PWM controller Michael Walle
2020-07-27 7:30 ` Thierry Reding
2020-07-27 8:48 ` Uwe Kleine-König [this message]
2020-07-28 7:43 ` Uwe Kleine-König
2020-07-28 8:21 ` Michael Walle
2020-07-28 9:47 ` Uwe Kleine-König
2020-07-28 10:51 ` Lee Jones
2020-07-25 23:18 ` [PATCH v6 07/13] gpio: add support for the sl28cpld GPIO controller Michael Walle
2020-07-26 9:16 ` Andy Shevchenko
2020-07-25 23:18 ` [PATCH v6 08/13] hwmon: add support for the sl28cpld hardware monitoring controller Michael Walle
2020-07-26 9:18 ` Andy Shevchenko
2020-07-25 23:18 ` [PATCH v6 09/13] arm64: dts: freescale: sl28: enable sl28cpld Michael Walle
2020-07-25 23:18 ` [PATCH v6 10/13] arm64: dts: freescale: sl28: map GPIOs to input events Michael Walle
2020-07-25 23:18 ` [PATCH v6 11/13] arm64: dts: freescale: sl28: enable LED support Michael Walle
2020-07-25 23:18 ` [PATCH v6 12/13] arm64: dts: freescale: sl28: enable fan support Michael Walle
2020-07-25 23:18 ` [PATCH v6 13/13] arm64: defconfig: enable the sl28cpld board management controller Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200727084826.vwnnvdzi2ldpgvcg@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=lee.jones@linaro.org \
--cc=linux-pwm@vger.kernel.org \
--cc=michael@walle.cc \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).