linux-pwm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chun-Kuang Hu <chunkuang.hu@kernel.org>
To: Alexandre Mergnat <amergnat@baylibre.com>
Cc: "Chun-Kuang Hu" <chunkuang.hu@kernel.org>,
	"Daniel Vetter" <daniel@ffwll.ch>, "CK Hu" <ck.hu@mediatek.com>,
	"Jitao Shi" <jitao.shi@mediatek.com>,
	"Thierry Reding" <thierry.reding@gmail.com>,
	"Philipp Zabel" <p.zabel@pengutronix.de>,
	"Sam Ravnborg" <sam@ravnborg.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"David Airlie" <airlied@gmail.com>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Xinlei Lee" <xinlei.lee@mediatek.com>,
	"Guillaume La Roque" <glaroque@baylibre.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org,
	dri-devel@lists.freedesktop.org,
	"Fabien Parent" <fparent@baylibre.com>,
	"Neil Armstrong" <neil.armstrong@linaro.org>,
	linux-pwm@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock
Date: Wed, 15 Mar 2023 22:17:11 +0800	[thread overview]
Message-ID: <CAAOTY_-TfXBpVbWw54yORqQ9Ubft-6PKofS2VznMi4-jfbA7Mg@mail.gmail.com> (raw)
In-Reply-To: <CAFGrd9pa3c3eZcuGg7AmHL8kOAkyx96hwjwnMuO-G9BR1ORJ_w@mail.gmail.com>

Hi, Alexandre:

Alexandre Mergnat <amergnat@baylibre.com> 於 2023年3月15日 週三 下午5:36寫道:
>
> Le lun. 13 mars 2023 à 16:21, Chun-Kuang Hu <chunkuang.hu@kernel.org> a écrit :
> >
> > >
> > > +       dpi->dpi_clk = devm_clk_get_optional(dev, "dpi");
> >
> > For MT8365, DPI clock is not optional, so make sure that MT8365 DPI
> > should have this clock.
>
> This should be check and notified at build time thanks to the
> device-tree binding. Do you prefer this?:
> #IF MT8365_SOC
>     dpi->dpi_clk = devm_clk_get(dev, "dpi");

Add one member in struct mtk_dpi_conf for dpi_clk. In
mtk_dpi_of_ids[], add one item for mt8365

{ .compatible = "mediatek,mt8365-dpi",
 .data = &mt8365_conf,
},

Regards,
Chun-Kuang.

>
> Regards,
> Alex

  reply	other threads:[~2023-03-15 14:17 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20230220-display-v1-0-45cbc68e188b@baylibre.com>
     [not found] ` <20230220-display-v1-21-45cbc68e188b@baylibre.com>
2023-03-09 14:51   ` [PATCH 21/21] panel: startek-kd070fhfid015: add support of this display Neil Armstrong
2023-03-15 15:59     ` Alexandre Mergnat
2023-03-15 17:12       ` neil.armstrong
     [not found] ` <20230220-display-v1-2-45cbc68e188b@baylibre.com>
2023-03-10  8:29   ` [PATCH 02/21] dt-bindings: display: mediatek: ccorr: add binding for MT8365 SoC Krzysztof Kozlowski
2023-03-13 14:54   ` Chun-Kuang Hu
     [not found] ` <20230220-display-v1-3-45cbc68e188b@baylibre.com>
2023-03-10  8:35   ` [PATCH 03/21] dt-bindings: display: mediatek: color: " Krzysztof Kozlowski
2023-03-13 14:58   ` Chun-Kuang Hu
     [not found] ` <20230220-display-v1-7-45cbc68e188b@baylibre.com>
2023-03-10  8:38   ` [PATCH 07/21] dt-bindings: display: mediatek: dpi: add binding for MT8365 Krzysztof Kozlowski
2023-03-13 15:17   ` Chun-Kuang Hu
2023-03-15  9:26     ` Alexandre Mergnat
     [not found] ` <20230220-display-v1-9-45cbc68e188b@baylibre.com>
2023-03-10  8:38   ` [PATCH 09/21] dt-bindings: display: mediatek: ovl: add binding for MT8365 SoC Krzysztof Kozlowski
2023-03-13 15:08   ` Chun-Kuang Hu
     [not found] ` <20230220-display-v1-10-45cbc68e188b@baylibre.com>
2023-03-10  8:38   ` [PATCH 10/21] dt-bindings: display: mediatek: rdma: " Krzysztof Kozlowski
2023-03-13 15:09   ` Chun-Kuang Hu
     [not found] ` <20230220-display-v1-13-45cbc68e188b@baylibre.com>
2023-03-10  8:38   ` [PATCH 13/21] dt-bindings: pwm: add binding for mt8365 SoC Krzysztof Kozlowski
     [not found] ` <20230220-display-v1-15-45cbc68e188b@baylibre.com>
2023-03-10  8:39   ` [PATCH 15/21] dt-bindings: soc: mediatek: add display mutex for MT8365 SoC Krzysztof Kozlowski
2023-03-15  8:01     ` Alexandre Mergnat
2023-03-15  8:17       ` Alexandre Mergnat
2023-03-15 13:17       ` Krzysztof Kozlowski
2023-03-15 13:22   ` Krzysztof Kozlowski
2023-03-31 17:51   ` Matthias Brugger
     [not found] ` <20230220-display-v1-4-45cbc68e188b@baylibre.com>
2023-03-10  8:35   ` [PATCH 04/21] dt-bindings: display: mediatek: dither: add binding " Krzysztof Kozlowski
2023-03-13 14:59   ` Chun-Kuang Hu
     [not found] ` <20230220-display-v1-5-45cbc68e188b@baylibre.com>
2023-03-10  8:35   ` [PATCH 05/21] dt-bindings: display: mediatek: dsi: " Krzysztof Kozlowski
2023-03-13 15:00   ` Chun-Kuang Hu
     [not found] ` <20230220-display-v1-1-45cbc68e188b@baylibre.com>
2023-03-10  8:41   ` [PATCH 01/21] dt-bindings: display: mediatek: aal: " Krzysztof Kozlowski
2023-03-13 15:02   ` Chun-Kuang Hu
2023-03-31 14:55     ` Matthias Brugger
2023-04-03  3:25       ` Chun-Kuang Hu
     [not found] ` <20230220-display-v1-8-45cbc68e188b@baylibre.com>
2023-03-10  8:38   ` [PATCH 08/21] dt-bindings: display: mediatek: gamma: " Krzysztof Kozlowski
2023-03-13 15:07   ` Chun-Kuang Hu
     [not found] ` <20230220-display-v1-19-45cbc68e188b@baylibre.com>
2023-03-13 15:21   ` [PATCH 19/21] drm/mediatek: dpi: add support for dpi clock Chun-Kuang Hu
2023-03-15  9:35     ` Alexandre Mergnat
2023-03-15 14:17       ` Chun-Kuang Hu [this message]
     [not found] ` <20230220-display-v1-18-45cbc68e188b@baylibre.com>
2023-03-27 15:37   ` [PATCH 18/21] drm/mediatek: dsi: Improves the DSI lane setup robustness Chun-Kuang Hu
     [not found] ` <20230220-display-v1-14-45cbc68e188b@baylibre.com>
2023-03-31 14:42   ` [PATCH 14/21] dt-bindings: soc: mediatek: specify which compatible requires clocks property Matthias Brugger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAAOTY_-TfXBpVbWw54yORqQ9Ubft-6PKofS2VznMi4-jfbA7Mg@mail.gmail.com \
    --to=chunkuang.hu@kernel.org \
    --cc=airlied@gmail.com \
    --cc=amergnat@baylibre.com \
    --cc=ck.hu@mediatek.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=fparent@baylibre.com \
    --cc=glaroque@baylibre.com \
    --cc=jitao.shi@mediatek.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=linux-pwm@vger.kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=neil.armstrong@linaro.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=sam@ravnborg.org \
    --cc=thierry.reding@gmail.com \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=xinlei.lee@mediatek.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).