Linux-Raid Archives on
 help / color / Atom feed
* [PATCH] super1.c: avoid useless sync when bitmap switches from clustered to none
@ 2021-02-02 13:53 Zhao Heming
  0 siblings, 0 replies; only message in thread
From: Zhao Heming @ 2021-02-02 13:53 UTC (permalink / raw)
  To: linux-raid, jes; +Cc: Zhao Heming, xni, lidong.zhong

With kernel commit 480523feae58 ("md: only call set_in_sync() when it
is expected to succeed."), mddev->in_sync in clustered array is always
zero. It makes metadata resync_offset to always zero.
When assembling a clusterd array with "-U no-bitmap" option, kernel
md layer "mddev->resync_offset == 0" and "mddev->bitmap == NULL" will
trigger raid1 do sync on every bitmap chunk. the sync action is useless,
we should avoid it.

Related kernel flow:
   md_bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, 1)
    __bitmap_start_sync(bitmap, offset,&blocks1, degraded)
      if (bitmap == NULL) {/* FIXME or bitmap set as 'failed' */
        *blocks = 1024;
        return 1; /* always resync if no bitmap */

Reprodusible steps:
mdadm -C /dev/md0 -b clustered -e 1.2 -n 2 -l mirror /dev/sd{a,b}
mdadm -Ss
(in another shell, executing: watch -n 1 'cat /proc/mdstat')
mdadm -A -U no-bitmap /dev/md0 /dev/sd{a,b}

Signed-off-by: Zhao Heming <>
 super1.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/super1.c b/super1.c
index 19fe6f5..92047d5 100644
--- a/super1.c
+++ b/super1.c
@@ -1318,6 +1318,8 @@ static int update_super1(struct supertype *st, struct mdinfo *info,
 			memcpy(bms->uuid, sb->set_uuid, 16);
 	} else if (strcmp(update, "no-bitmap") == 0) {
 		sb->feature_map &= ~__cpu_to_le32(MD_FEATURE_BITMAP_OFFSET);
+		if (bms->version == BITMAP_MAJOR_CLUSTERED)
+			sb->resync_offset = MaxSector;
 	} else if (strcmp(update, "bbl") == 0) {
 		/* only possible if there is room after the bitmap, or if
 		 * there is no bitmap

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, back to index

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-02 13:53 [PATCH] super1.c: avoid useless sync when bitmap switches from clustered to none Zhao Heming

Linux-Raid Archives on

Archives are clonable:
	git clone --mirror linux-raid/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-raid linux-raid/ \
	public-inbox-index linux-raid

Example config snippet for mirrors

Newsgroup available over NNTP:

AGPL code for this site: git clone