* [PATCH] md/raid1: Initialize conf->raid_disks before using it.
@ 2012-10-24 8:00 majianpeng
2012-10-24 22:56 ` NeilBrown
0 siblings, 1 reply; 2+ messages in thread
From: majianpeng @ 2012-10-24 8:00 UTC (permalink / raw)
To: NeilBrown; +Cc: linux-raid
Because the conf->raid_disks is zero at first,so if there is a
replacement disk, func setup_conf will abort.
Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
---
drivers/md/raid1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
index 8034fbd..4eec567 100644
--- a/drivers/md/raid1.c
+++ b/drivers/md/raid1.c
@@ -2703,6 +2703,7 @@ static struct r1conf *setup_conf(struct mddev *mddev)
err = -EINVAL;
spin_lock_init(&conf->device_lock);
+ conf->raid_disks = mddev->raid_disks;
rdev_for_each(rdev, mddev) {
struct request_queue *q;
int disk_idx = rdev->raid_disk;
@@ -2724,7 +2725,6 @@ static struct r1conf *setup_conf(struct mddev *mddev)
disk->head_position = 0;
disk->seq_start = MaxSector;
}
- conf->raid_disks = mddev->raid_disks;
conf->mddev = mddev;
INIT_LIST_HEAD(&conf->retry_list);
--
1.7.9.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] md/raid1: Initialize conf->raid_disks before using it.
2012-10-24 8:00 [PATCH] md/raid1: Initialize conf->raid_disks before using it majianpeng
@ 2012-10-24 22:56 ` NeilBrown
0 siblings, 0 replies; 2+ messages in thread
From: NeilBrown @ 2012-10-24 22:56 UTC (permalink / raw)
To: majianpeng; +Cc: linux-raid
[-- Attachment #1: Type: text/plain, Size: 1169 bytes --]
On Wed, 24 Oct 2012 16:00:53 +0800 majianpeng <majianpeng@gmail.com> wrote:
> Because the conf->raid_disks is zero at first,so if there is a
> replacement disk, func setup_conf will abort.
>
> Signed-off-by: Jianpeng Ma <majianpeng@gmail.com>
> ---
> drivers/md/raid1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 8034fbd..4eec567 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -2703,6 +2703,7 @@ static struct r1conf *setup_conf(struct mddev *mddev)
>
> err = -EINVAL;
> spin_lock_init(&conf->device_lock);
> + conf->raid_disks = mddev->raid_disks;
> rdev_for_each(rdev, mddev) {
> struct request_queue *q;
> int disk_idx = rdev->raid_disk;
> @@ -2724,7 +2725,6 @@ static struct r1conf *setup_conf(struct mddev *mddev)
> disk->head_position = 0;
> disk->seq_start = MaxSector;
> }
> - conf->raid_disks = mddev->raid_disks;
> conf->mddev = mddev;
> INIT_LIST_HEAD(&conf->retry_list);
>
Thanks. I had already discovered that bug and have a fix in my tree. I just
haven't pushed it out yet.
NeilBrown
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-10-24 22:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-10-24 8:00 [PATCH] md/raid1: Initialize conf->raid_disks before using it majianpeng
2012-10-24 22:56 ` NeilBrown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).