From: Jakub Radtke <jakub.radtke@linux.intel.com>
To: jes@trained-monkey.org
Cc: linux-raid@vger.kernel.org
Subject: [PATCH 5/8] Add "bitmap" to allowed command-line values
Date: Fri, 15 Jan 2021 00:46:58 -0500 [thread overview]
Message-ID: <20210115054701.92064-6-jakub.radtke@linux.intel.com> (raw)
In-Reply-To: <20210115054701.92064-1-jakub.radtke@linux.intel.com>
From: Jakub Radtke <jakub.radtke@intel.com>
Currently, the sysfs interface allows bitmap setup only when volume
is in an inactive state.
For external metadata to add bitmap to existing volume instead of
GROW, the UPDATE operation can be done.
The patch adds a "bitmap" argument to the allowed values for UPDATE.
Signed-off-by: Jakub Radtke <jakub.radtke@intel.com>
Change-Id: Ic46fdc6cc39eba2097a7e4956c44f4a9970e7b05
---
mdadm.8.in | 13 +++++++++++--
mdadm.c | 4 +++-
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/mdadm.8.in b/mdadm.8.in
index 34a93a8f..c89d901e 100644
--- a/mdadm.8.in
+++ b/mdadm.8.in
@@ -2408,9 +2408,11 @@ or
.B \-\-update=
option. The supported options are
.BR name ,
-.B ppl
+.BR ppl ,
+.BR no\-ppl ,
+.BR bitmap
and
-.BR no\-ppl .
+.BR no\-bitmap .
The
.B name
@@ -2428,6 +2430,13 @@ and
options enable and disable PPL in the metadata. Currently supported only for
IMSM subarrays.
+The
+.B bitmap
+and
+.B no\-bitmap
+options enable and disable write-intent bitmap in the metadata. Currently supported only for
+IMSM subarrays.
+
.TP
.B \-\-examine
The device should be a component of an md array.
diff --git a/mdadm.c b/mdadm.c
index 493d70e4..9a4317d5 100644
--- a/mdadm.c
+++ b/mdadm.c
@@ -779,6 +779,8 @@ int main(int argc, char *argv[])
continue;
if (strcmp(c.update, "devicesize") == 0)
continue;
+ if (strcmp(c.update, "bitmap") == 0)
+ continue;
if (strcmp(c.update, "no-bitmap") == 0)
continue;
if (strcmp(c.update, "bbl") == 0)
@@ -827,7 +829,7 @@ int main(int argc, char *argv[])
fprintf(outf, "Valid --update options are:\n"
" 'sparc2.2', 'super-minor', 'uuid', 'name', 'nodes', 'resync',\n"
" 'summaries', 'homehost', 'home-cluster', 'byteorder', 'devicesize',\n"
- " 'no-bitmap', 'metadata', 'revert-reshape'\n"
+ " 'bitmap', 'no-bitmap', 'metadata', 'revert-reshape'\n"
" 'bbl', 'no-bbl', 'force-no-bbl', 'ppl', 'no-ppl'\n"
" 'layout-original', 'layout-alternate', 'layout-unspecified'\n"
);
--
2.26.2
next prev parent reply other threads:[~2021-01-15 13:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 5:46 [PATCH 0/8] Write-intent bitmap support for IMSM metadata Jakub Radtke
2021-01-15 5:46 ` [PATCH 1/8] Modify mdstat parsing for volumes with the bitmap Jakub Radtke
2021-01-15 5:46 ` [PATCH 2/8] Enable bitmap support for external metadata Jakub Radtke
2021-01-15 5:46 ` [PATCH 3/8] imsm: Write-intent bitmap support Jakub Radtke
2021-01-15 5:46 ` [PATCH 4/8] imsm: Adding a spare to an existing array with bitmap Jakub Radtke
2021-01-15 5:46 ` Jakub Radtke [this message]
2021-01-15 5:46 ` [PATCH 6/8] imsm: Update-subarray for write-intent bitmap Jakub Radtke
2021-01-15 5:47 ` [PATCH 7/8] Create: Block automatic enabling bitmap for external metadata Jakub Radtke
2021-01-15 5:47 ` [PATCH 8/8] Grow: Block reshape when external metadata and write-intent bitmap Jakub Radtke
2021-03-10 14:50 ` [PATCH 0/8] Write-intent bitmap support for IMSM metadata Jes Sorensen
-- strict thread matches above, loose matches on Subject: below --
2020-09-25 0:02 Jakub Radtke
2020-09-25 0:03 ` [PATCH 5/8] Add "bitmap" to allowed command-line values Jakub Radtke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115054701.92064-6-jakub.radtke@linux.intel.com \
--to=jakub.radtke@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).