From: Jakub Radtke <jakub.radtke@linux.intel.com>
To: jes@trained-monkey.org
Cc: linux-raid@vger.kernel.org
Subject: [PATCH 7/8] Create: Block automatic enabling bitmap for external metadata
Date: Fri, 15 Jan 2021 00:47:00 -0500 [thread overview]
Message-ID: <20210115054701.92064-8-jakub.radtke@linux.intel.com> (raw)
In-Reply-To: <20210115054701.92064-1-jakub.radtke@linux.intel.com>
From: Jakub Radtke <jakub.radtke@intel.com>
For external metadata, bitmap should be added only when
explicitly set by the administrator.
They could be additional requirements to consider before
enabling the external metadata's functionality
(e.g., kernel support).
Change-Id: I3973464b4c73f77b9c2ebc9cbb5f501a14d5eb02
Signed-off-by: Jakub Radtke <jakub.radtke@intel.com>
---
Create.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/Create.c b/Create.c
index 751f18c1..7df3b7e2 100644
--- a/Create.c
+++ b/Create.c
@@ -540,6 +540,7 @@ int Create(struct supertype *st, char *mddev,
}
if (!s->bitmap_file &&
+ !st->ss->external &&
s->level >= 1 &&
st->ss->add_internal_bitmap &&
s->journaldisks == 0 &&
--
2.26.2
next prev parent reply other threads:[~2021-01-15 13:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-15 5:46 [PATCH 0/8] Write-intent bitmap support for IMSM metadata Jakub Radtke
2021-01-15 5:46 ` [PATCH 1/8] Modify mdstat parsing for volumes with the bitmap Jakub Radtke
2021-01-15 5:46 ` [PATCH 2/8] Enable bitmap support for external metadata Jakub Radtke
2021-01-15 5:46 ` [PATCH 3/8] imsm: Write-intent bitmap support Jakub Radtke
2021-01-15 5:46 ` [PATCH 4/8] imsm: Adding a spare to an existing array with bitmap Jakub Radtke
2021-01-15 5:46 ` [PATCH 5/8] Add "bitmap" to allowed command-line values Jakub Radtke
2021-01-15 5:46 ` [PATCH 6/8] imsm: Update-subarray for write-intent bitmap Jakub Radtke
2021-01-15 5:47 ` Jakub Radtke [this message]
2021-01-15 5:47 ` [PATCH 8/8] Grow: Block reshape when external metadata and " Jakub Radtke
2021-03-10 14:50 ` [PATCH 0/8] Write-intent bitmap support for IMSM metadata Jes Sorensen
-- strict thread matches above, loose matches on Subject: below --
2020-09-25 0:02 Jakub Radtke
2020-09-25 0:03 ` [PATCH 7/8] Create: Block automatic enabling bitmap for external metadata Jakub Radtke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210115054701.92064-8-jakub.radtke@linux.intel.com \
--to=jakub.radtke@linux.intel.com \
--cc=jes@trained-monkey.org \
--cc=linux-raid@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).