* [GIT PULL] md-fixes 20210922
@ 2021-09-22 16:10 Song Liu
2021-09-22 16:14 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Song Liu @ 2021-09-22 16:10 UTC (permalink / raw)
To: Jens Axboe, linux-raid; +Cc: Christoph Hellwig, Luis Chamberlain
Hi Jens,
Please consider pulling the following changes for md-fixes on top of your
block-5.15 branch. The changes are:
1. Fix lock order reversal in md_alloc. (Christoph)
2. Handle add_disk error in md_alloc. (Luis)
3. Refactor md sysfs attrs, included because of dependency with 1 and 2.
(Christoph).
Thanks,
Song
The following changes since commit 858560b27645e7e97aca37ee8f232cccd658fbd2:
blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd (2021-09-15 12:03:18 -0600)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-fixes
for you to fetch changes up to 36a0f29442237275abe33b73eac475c410bea6fa:
md: properly unwind when failing to add the kobject in md_alloc (2021-09-22 08:46:00 -0700)
----------------------------------------------------------------
Christoph Hellwig (4):
md: fix a lock order reversal in md_alloc
md: add the bitmap group to the default groups for the md kobject
md: extend disks_mutex coverage
md: properly unwind when failing to add the kobject in md_alloc
Luis Chamberlain (1):
md: add error handling support for add_disk()
drivers/md/md.c | 56 +++++++++++++++++++++++++++++---------------------------
1 file changed, 29 insertions(+), 27 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] md-fixes 20210922
2021-09-22 16:10 [GIT PULL] md-fixes 20210922 Song Liu
@ 2021-09-22 16:14 ` Jens Axboe
2021-09-22 17:38 ` Song Liu
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2021-09-22 16:14 UTC (permalink / raw)
To: Song Liu, linux-raid; +Cc: Christoph Hellwig, Luis Chamberlain
On 9/22/21 10:10 AM, Song Liu wrote:
> Hi Jens,
>
> Please consider pulling the following changes for md-fixes on top of your
> block-5.15 branch. The changes are:
> 1. Fix lock order reversal in md_alloc. (Christoph)
> 2. Handle add_disk error in md_alloc. (Luis)
> 3. Refactor md sysfs attrs, included because of dependency with 1 and 2.
> (Christoph).
I don't think the error handling for add_disk is prudent at this point,
that's something that should go in with the 5.16 cycle. It's been like
that forever, nothing that warrants pushing this for 5.15 at all.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] md-fixes 20210922
2021-09-22 16:14 ` Jens Axboe
@ 2021-09-22 17:38 ` Song Liu
2021-09-22 18:42 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Song Liu @ 2021-09-22 17:38 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-raid, Christoph Hellwig, Luis Chamberlain
> On Sep 22, 2021, at 9:14 AM, Jens Axboe <axboe@kernel.dk> wrote:
>
> On 9/22/21 10:10 AM, Song Liu wrote:
>> Hi Jens,
>>
>> Please consider pulling the following changes for md-fixes on top of your
>> block-5.15 branch. The changes are:
>> 1. Fix lock order reversal in md_alloc. (Christoph)
>> 2. Handle add_disk error in md_alloc. (Luis)
>> 3. Refactor md sysfs attrs, included because of dependency with 1 and 2.
>> (Christoph).
>
> I don't think the error handling for add_disk is prudent at this point,
> that's something that should go in with the 5.16 cycle. It's been like
> that forever, nothing that warrants pushing this for 5.15 at all.
Hmm... I see. The WARN_ON_ONCE at the end of device_add_disk() should be
enough. Then we just need the first commit. Could you please pull the
following change instead?
1. Fix lock order reversal in md_alloc. (Christoph)
Thanks,
Song
The following changes since commit 858560b27645e7e97aca37ee8f232cccd658fbd2:
blk-cgroup: fix UAF by grabbing blkcg lock before destroying blkg pd (2021-09-15 12:03:18 -0600)
are available in the Git repository at:
https://git.kernel.org/pub/scm/linux/kernel/git/song/md.git md-fixes
for you to fetch changes up to 7df835a32a8bedf7ce88efcfa7c9b245b52ff139:
md: fix a lock order reversal in md_alloc (2021-09-22 08:45:58 -0700)
----------------------------------------------------------------
Christoph Hellwig (1):
md: fix a lock order reversal in md_alloc
drivers/md/md.c | 5 -----
1 file changed, 5 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [GIT PULL] md-fixes 20210922
2021-09-22 17:38 ` Song Liu
@ 2021-09-22 18:42 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-09-22 18:42 UTC (permalink / raw)
To: Song Liu; +Cc: linux-raid, Christoph Hellwig, Luis Chamberlain
On 9/22/21 11:38 AM, Song Liu wrote:
>
>
>> On Sep 22, 2021, at 9:14 AM, Jens Axboe <axboe@kernel.dk> wrote:
>>
>> On 9/22/21 10:10 AM, Song Liu wrote:
>>> Hi Jens,
>>>
>>> Please consider pulling the following changes for md-fixes on top of your
>>> block-5.15 branch. The changes are:
>>> 1. Fix lock order reversal in md_alloc. (Christoph)
>>> 2. Handle add_disk error in md_alloc. (Luis)
>>> 3. Refactor md sysfs attrs, included because of dependency with 1 and 2.
>>> (Christoph).
>>
>> I don't think the error handling for add_disk is prudent at this point,
>> that's something that should go in with the 5.16 cycle. It's been like
>> that forever, nothing that warrants pushing this for 5.15 at all.
>
> Hmm... I see. The WARN_ON_ONCE at the end of device_add_disk() should be
> enough.
We've had no error handling in add_disk forever, this is not a new issue.
> Then we just need the first commit. Could you please pull the
> following change instead?
>
> 1. Fix lock order reversal in md_alloc. (Christoph)
Looks better, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-22 18:42 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-22 16:10 [GIT PULL] md-fixes 20210922 Song Liu
2021-09-22 16:14 ` Jens Axboe
2021-09-22 17:38 ` Song Liu
2021-09-22 18:42 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).