[PATCH 1/3] iw_cxgb4: put ep reference in pass_accept_req()

[PATCH 1/3] iw_cxgb4: put ep reference in pass_accept_req()

[Steve Wise]

The listening endpoint should always be dereferenced at the end of
pass_accept_req().

Fixes: f86fac79afec ("RDMA/iw_cxgb4: atomic find and reference for listening endpoints")

Signed-off-by: Steve Wise <swise@opengridcomputing.com>
---
 drivers/infiniband/hw/cxgb4/cm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index e49b34c..6d85a5d 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -2594,9 +2594,9 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb)
 	c4iw_put_ep(&child_ep->com);
 reject:
 	reject_cr(dev, hwtid, skb);
+out:
 	if (parent_ep)
 		c4iw_put_ep(&parent_ep->com);
-out:
 	return 0;
 }
 
-- 
1.8.3.1

Re: [PATCH 1/3] iw_cxgb4: put ep reference in pass_accept_req()

[Greg KH]

On Wed, Sep 13, 2017 at 09:52:32AM -0700, Steve Wise wrote:
> The listening endpoint should always be dereferenced at the end of
> pass_accept_req().
> 
> Fixes: f86fac79afec ("RDMA/iw_cxgb4: atomic find and reference for listening endpoints")
> 
> Signed-off-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index e49b34c..6d85a5d 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -2594,9 +2594,9 @@ static int pass_accept_req(struct c4iw_dev *dev, struct sk_buff *skb)
>  	c4iw_put_ep(&child_ep->com);
>  reject:
>  	reject_cr(dev, hwtid, skb);
> +out:
>  	if (parent_ep)
>  		c4iw_put_ep(&parent_ep->com);
> -out:
>  	return 0;
>  }
>  
> -- 
> 1.8.3.1

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree.  Please read:
    https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH 1/3] iw_cxgb4: put ep reference in pass_accept_req()

[Steve Wise]

> 
> <formletter>
> 
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree.  Please read:
>     https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
> 
> </formletter>
>

Sorry Greg, 

I screwed up and put the CC in the mail header instead of the commit log.  I
have posted a RESEND of the series.

Steve.