* [PATCH rdma-core] iwpmd: fix double mutex unlock
@ 2018-01-31 15:37 Potnuri Bharat Teja
[not found] ` <1517413071-20438-1-git-send-email-bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Potnuri Bharat Teja @ 2018-01-31 15:37 UTC (permalink / raw)
To: jgg-uk2M96/98Pc, dledford-H+wXaHxf7aLQT0dZR+AlfA,
leon-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW,
bharat-ut6Up61K2wZBDgjK7y7TUQ
pthread_mutex_unlock() is used twice and this patch fixes it.
Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
---
iwpmd/iwarp_pm_helper.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
index bebc151f329b..b8c230189d50 100644
--- a/iwpmd/iwarp_pm_helper.c
+++ b/iwpmd/iwarp_pm_helper.c
@@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg *send_msg)
pthread_mutex_lock(&pending_msg_mutex);
list_add(&pending_messages, &pending_msg->entry);
- pthread_mutex_unlock(&pending_msg_mutex);
pthread_mutex_unlock(&pending_msg_mutex);
/* signal the thread that a new message has been posted */
pthread_cond_signal(&cond_pending_msg);
--
2.5.3
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 7+ messages in thread
* RE: [PATCH rdma-core] iwpmd: fix double mutex unlock
[not found] ` <1517413071-20438-1-git-send-email-bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
@ 2018-01-31 15:40 ` Steve Wise
2018-01-31 16:04 ` Steve Wise
0 siblings, 1 reply; 7+ messages in thread
From: Steve Wise @ 2018-01-31 15:40 UTC (permalink / raw)
To: 'Potnuri Bharat Teja',
jgg-uk2M96/98Pc, dledford-H+wXaHxf7aLQT0dZR+AlfA,
leon-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
>
> pthread_mutex_unlock() is used twice and this patch fixes it.
>
> Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
> Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> ---
> iwpmd/iwarp_pm_helper.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
> index bebc151f329b..b8c230189d50 100644
> --- a/iwpmd/iwarp_pm_helper.c
> +++ b/iwpmd/iwarp_pm_helper.c
> @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg
> *send_msg)
>
> pthread_mutex_lock(&pending_msg_mutex);
> list_add(&pending_messages, &pending_msg->entry);
> - pthread_mutex_unlock(&pending_msg_mutex);
> pthread_mutex_unlock(&pending_msg_mutex);
> /* signal the thread that a new message has been posted */
> pthread_cond_signal(&cond_pending_msg);
Good catch.
Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH rdma-core] iwpmd: fix double mutex unlock
2018-01-31 15:40 ` Steve Wise
@ 2018-01-31 16:04 ` Steve Wise
2018-01-31 21:06 ` Doug Ledford
0 siblings, 1 reply; 7+ messages in thread
From: Steve Wise @ 2018-01-31 16:04 UTC (permalink / raw)
To: 'Potnuri Bharat Teja',
jgg-uk2M96/98Pc, dledford-H+wXaHxf7aLQT0dZR+AlfA,
leon-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
> >
> > pthread_mutex_unlock() is used twice and this patch fixes it.
> >
> > Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
> > Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > ---
> > iwpmd/iwarp_pm_helper.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
> > index bebc151f329b..b8c230189d50 100644
> > --- a/iwpmd/iwarp_pm_helper.c
> > +++ b/iwpmd/iwarp_pm_helper.c
> > @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg
> > *send_msg)
> >
> > pthread_mutex_lock(&pending_msg_mutex);
> > list_add(&pending_messages, &pending_msg->entry);
> > - pthread_mutex_unlock(&pending_msg_mutex);
> > pthread_mutex_unlock(&pending_msg_mutex);
> > /* signal the thread that a new message has been posted */
> > pthread_cond_signal(&cond_pending_msg);
>
> Good catch.
>
> Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
And this definitely needs to flow to stable.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH rdma-core] iwpmd: fix double mutex unlock
2018-01-31 16:04 ` Steve Wise
@ 2018-01-31 21:06 ` Doug Ledford
[not found] ` <1517432802.19117.41.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Doug Ledford @ 2018-01-31 21:06 UTC (permalink / raw)
To: Steve Wise, 'Potnuri Bharat Teja',
jgg-uk2M96/98Pc, leon-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 1394 bytes --]
On Wed, 2018-01-31 at 10:04 -0600, Steve Wise wrote:
> > >
> > > pthread_mutex_unlock() is used twice and this patch fixes it.
> > >
> > > Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
> > > Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > ---
> > > iwpmd/iwarp_pm_helper.c | 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
> > > index bebc151f329b..b8c230189d50 100644
> > > --- a/iwpmd/iwarp_pm_helper.c
> > > +++ b/iwpmd/iwarp_pm_helper.c
> > > @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg
> > > *send_msg)
> > >
> > > pthread_mutex_lock(&pending_msg_mutex);
> > > list_add(&pending_messages, &pending_msg->entry);
> > > - pthread_mutex_unlock(&pending_msg_mutex);
> > > pthread_mutex_unlock(&pending_msg_mutex);
> > > /* signal the thread that a new message has been posted */
> > > pthread_cond_signal(&cond_pending_msg);
> >
> > Good catch.
> >
> > Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
>
> And this definitely needs to flow to stable.
>
Applied to master branch, thanks.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH rdma-core] iwpmd: fix double mutex unlock
[not found] ` <1517432802.19117.41.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2018-01-31 21:12 ` Steve Wise
2018-01-31 21:28 ` Doug Ledford
0 siblings, 1 reply; 7+ messages in thread
From: Steve Wise @ 2018-01-31 21:12 UTC (permalink / raw)
To: 'Doug Ledford', 'Potnuri Bharat Teja',
jgg-uk2M96/98Pc, leon-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
> Subject: Re: [PATCH rdma-core] iwpmd: fix double mutex unlock
>
> On Wed, 2018-01-31 at 10:04 -0600, Steve Wise wrote:
> > > >
> > > > pthread_mutex_unlock() is used twice and this patch fixes it.
> > > >
> > > > Fixes: be3fbf85b ("iwpmd: use ccan list.h for pending_messages")
> > > > Signed-off-by: Potnuri Bharat Teja <bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
> > > > ---
> > > > iwpmd/iwarp_pm_helper.c | 1 -
> > > > 1 file changed, 1 deletion(-)
> > > >
> > > > diff --git a/iwpmd/iwarp_pm_helper.c b/iwpmd/iwarp_pm_helper.c
> > > > index bebc151f329b..b8c230189d50 100644
> > > > --- a/iwpmd/iwarp_pm_helper.c
> > > > +++ b/iwpmd/iwarp_pm_helper.c
> > > > @@ -578,7 +578,6 @@ int add_iwpm_pending_msg(iwpm_send_msg
> > > > *send_msg)
> > > >
> > > > pthread_mutex_lock(&pending_msg_mutex);
> > > > list_add(&pending_messages, &pending_msg->entry);
> > > > - pthread_mutex_unlock(&pending_msg_mutex);
> > > > pthread_mutex_unlock(&pending_msg_mutex);
> > > > /* signal the thread that a new message has been posted */
> > > > pthread_cond_signal(&cond_pending_msg);
> > >
> > > Good catch.
> > >
> > > Reviewed-by: Steve Wise <swise-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
> >
> > And this definitely needs to flow to stable.
> >
>
> Applied to master branch, thanks.
>
Thanks Doug. Do I need to do some process magic to get it into stable and spin a 16.x.y point release for the EWG to pull into OFED-4.8-2?
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH rdma-core] iwpmd: fix double mutex unlock
2018-01-31 21:12 ` Steve Wise
@ 2018-01-31 21:28 ` Doug Ledford
[not found] ` <1517434122.19117.45.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 7+ messages in thread
From: Doug Ledford @ 2018-01-31 21:28 UTC (permalink / raw)
To: Steve Wise, 'Potnuri Bharat Teja',
jgg-uk2M96/98Pc, leon-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
[-- Attachment #1: Type: text/plain, Size: 533 bytes --]
On Wed, 2018-01-31 at 15:12 -0600, Steve Wise wrote:
> > Applied to master branch, thanks.
> >
>
> Thanks Doug. Do I need to do some process magic to get it into stable and spin a 16.x.y point release for the EWG to pull into OFED-4.8-2?
I added a comment to the commit on github and tagged you and Nicolas.
He should pull it back for you.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG KeyID: B826A3330E572FDD
Key fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH rdma-core] iwpmd: fix double mutex unlock
[not found] ` <1517434122.19117.45.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
@ 2018-01-31 21:56 ` Steve Wise
0 siblings, 0 replies; 7+ messages in thread
From: Steve Wise @ 2018-01-31 21:56 UTC (permalink / raw)
To: 'Doug Ledford', 'Potnuri Bharat Teja',
jgg-uk2M96/98Pc, leon-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
>
> On Wed, 2018-01-31 at 15:12 -0600, Steve Wise wrote:
> > > Applied to master branch, thanks.
> > >
> >
> > Thanks Doug. Do I need to do some process magic to get it into stable and
> spin a 16.x.y point release for the EWG to pull into OFED-4.8-2?
>
> I added a comment to the commit on github and tagged you and Nicolas.
> He should pull it back for you.
>
Thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-01-31 21:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-31 15:37 [PATCH rdma-core] iwpmd: fix double mutex unlock Potnuri Bharat Teja
[not found] ` <1517413071-20438-1-git-send-email-bharat-ut6Up61K2wZBDgjK7y7TUQ@public.gmane.org>
2018-01-31 15:40 ` Steve Wise
2018-01-31 16:04 ` Steve Wise
2018-01-31 21:06 ` Doug Ledford
[not found] ` <1517432802.19117.41.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-31 21:12 ` Steve Wise
2018-01-31 21:28 ` Doug Ledford
[not found] ` <1517434122.19117.45.camel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-01-31 21:56 ` Steve Wise
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).